Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unauthorised volume mode conversion during volume restore #3141

Open
1 of 4 tasks
RaunakShah opened this issue Jan 14, 2022 · 28 comments
Open
1 of 4 tasks

Prevent unauthorised volume mode conversion during volume restore #3141

RaunakShah opened this issue Jan 14, 2022 · 28 comments
Assignees
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team

Comments

@RaunakShah
Copy link
Contributor

RaunakShah commented Jan 14, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 14, 2022
@RaunakShah
Copy link
Contributor Author

RaunakShah commented Jan 14, 2022

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 14, 2022
@gracenng
Copy link
Member

gracenng commented Jan 18, 2022

Hi @RaunakShah ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting alpha for 1.24, is that correct?.
Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release with latest-milestone: 1.24
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as at risk
Thanks!

@xing-yang
Copy link
Contributor

xing-yang commented Jan 27, 2022

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 27, 2022
@xing-yang
Copy link
Contributor

xing-yang commented Jan 27, 2022

@gracenng Yes, this is targeting Alpha in 1.24.

@gracenng
Copy link
Member

gracenng commented Jan 30, 2022

Hi @RaunakShah , 1.24 Enhancements Team here.

Reaching out as we're less than a week away from Enhancement Freeze on Thursday, February 3rd.
Updated some points on the check list above, let me know if I missed anything.
I'm monitoring #3151 and current status is at risk

@gracenng
Copy link
Member

gracenng commented Feb 4, 2022

All good for 1.24 Enhancements Freeze

@xing-yang
Copy link
Contributor

xing-yang commented Feb 11, 2022

@gracenng Should this have a Tracked/Yes label?

@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 11, 2022
@didicodes
Copy link

didicodes commented Feb 13, 2022

Hi @xing-yang & @RaunakShah, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

@gracenng
Copy link
Member

gracenng commented Mar 16, 2022

Hi @RaunakShah 1.24 Enhancements Team here,

With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked k/k PR. Kindly list them in this issue. Thanks!

@xing-yang
Copy link
Contributor

xing-yang commented Mar 23, 2022

@xing-yang
Copy link
Contributor

xing-yang commented Mar 23, 2022

@gracenng It might be better to label this feature as "tracked/out-of-tree" as all the code changes are out-of-tree.

@gracenng gracenng added the tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team label Mar 26, 2022
@gracenng
Copy link
Member

gracenng commented Mar 26, 2022

All good for Code Freeze!

@nate-double-u
Copy link

nate-double-u commented Apr 4, 2022

Hi @RaunakShah, reminder that tomorrow (April 5th) is the deadline for 1.24 Docs Ready for Review.

Please open a PR (and link it back here), push your docs content for this enhancement, and remove the work-in-progress label when ready for review.

We have a tight turnaround to getting docs reviewed and approved for the release, and we’re hoping to have all docs in for review by tomorrow. Thank you!

@xing-yang
Copy link
Contributor

xing-yang commented Apr 5, 2022

Here's the doc PR: kubernetes/website#32673

@RaunakShah
Copy link
Contributor Author

RaunakShah commented Apr 5, 2022

@nate-double-u @xing-yang I've removed the WIP label from the doc PR.

@sftim
Copy link
Contributor

sftim commented Apr 12, 2022

This enhancement proposal mentions the annotation snapshot.storage.kubernetes.io/allowVolumeModeChange. Would it be possible to deprecate that in favor of a more conventional snapshot.storage.kubernetes.io/allow-volume-mode-change?

@xing-yang
Copy link
Contributor

xing-yang commented Apr 12, 2022

This enhancement proposal mentions the annotation snapshot.storage.kubernetes.io/allowVolumeModeChange. Would it be possible to deprecate that in favor of a more conventional snapshot.storage.kubernetes.io/allow-volume-mode-change?

We could do that in 1.25.

@nate-double-u
Copy link

nate-double-u commented Apr 26, 2022

A note for when this KEP goes to beta (targeting v1.25): the documentation that was added in v1.24 needs to be updated.

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented May 10, 2022

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone May 10, 2022
@RaunakShah
Copy link
Contributor Author

RaunakShah commented May 24, 2022

Updated the KEP description to target beta in 1.26 (as opposed to 1.25).

@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 22, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2022
@RaunakShah
Copy link
Contributor Author

RaunakShah commented Aug 24, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2022
@xing-yang xing-yang added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 7, 2022
@xing-yang
Copy link
Contributor

xing-yang commented Sep 7, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 7, 2022
@rhockenbury rhockenbury added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 20, 2022
@parul5sahoo
Copy link
Member

parul5sahoo commented Sep 22, 2022

Hello @RaunakShah 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage beta for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following before the enhancements freeze:

  • Edit the test plan section in the KEP's README to include the agreement mentioned in the latest template linked above.
  • update the status from provisional to implementable in the kep.yaml and change the stage from alpha to beta.
  • complete the PRR and merge it for the beta stage.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Let us know if you have any queries.
Thank you!

@parul5sahoo
Copy link
Member

parul5sahoo commented Oct 4, 2022

Hello @RaunakShah just a quick remainder the enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

@xing-yang
Copy link
Contributor

xing-yang commented Oct 6, 2022

Hi @parul5sahoo, e2e tests are still WIP so we can't get the KEP merged today. Since the implementation is completely out-of-tree, we will continue to work on it. Please keep the tracked/out-of-tree label.

@parul5sahoo
Copy link
Member

parul5sahoo commented Oct 7, 2022

Hey @xing-yang there isn't a tracked/out-of-tree label available for KEPs at the moment, so maybe you can just file an exception request post enhancement freeze.

@rhockenbury
Copy link

rhockenbury commented Oct 7, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 7, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Oct 7, 2022
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team
Projects
Status: Graduating
Development

No branches or pull requests