Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unauthorised volume mode conversion during volume restore #3141

Open
10 tasks done
RaunakShah opened this issue Jan 14, 2022 · 54 comments
Open
10 tasks done

Prevent unauthorised volume mode conversion during volume restore #3141

RaunakShah opened this issue Jan 14, 2022 · 54 comments
Assignees
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team
Milestone

Comments

@RaunakShah
Copy link
Contributor

RaunakShah commented Jan 14, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 14, 2022
@RaunakShah
Copy link
Contributor Author

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 14, 2022
@gracenng
Copy link
Member

gracenng commented Jan 18, 2022

Hi @RaunakShah ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting alpha for 1.24, is that correct?.
Here’s where this enhancement currently stands:

  • Updated KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for this release with latest-milestone: 1.24
  • KEP has a test plan section filled out.
  • KEP has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is track as at risk
Thanks!

@xing-yang
Copy link
Contributor

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 27, 2022
@xing-yang
Copy link
Contributor

@gracenng Yes, this is targeting Alpha in 1.24.

@gracenng
Copy link
Member

Hi @RaunakShah , 1.24 Enhancements Team here.

Reaching out as we're less than a week away from Enhancement Freeze on Thursday, February 3rd.
Updated some points on the check list above, let me know if I missed anything.
I'm monitoring #3151 and current status is at risk

@gracenng
Copy link
Member

gracenng commented Feb 4, 2022

All good for 1.24 Enhancements Freeze

@xing-yang
Copy link
Contributor

@gracenng Should this have a Tracked/Yes label?

@gracenng gracenng added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 11, 2022
@didicodes
Copy link

Hi @xing-yang & @RaunakShah, 1.24 Docs shadow here. 👋

This enhancement is marked as Needs Docs for the 1.24 release.

Please follow the steps detailed in the documentation to open a PR against the dev-1.24 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 31st March 2022, 18:00 PDT.

Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙌

@gracenng
Copy link
Member

Hi @RaunakShah 1.24 Enhancements Team here,

With Code Freeze approaching on 18:00 PDT Tuesday March 29th 2022, the enhancement status is at risk as there is no linked k/k PR. Kindly list them in this issue. Thanks!

@xing-yang
Copy link
Contributor

@xing-yang
Copy link
Contributor

@gracenng It might be better to label this feature as "tracked/out-of-tree" as all the code changes are out-of-tree.

@gracenng gracenng added the tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team label Mar 26, 2022
@gracenng
Copy link
Member

All good for Code Freeze!

@nate-double-u
Copy link

Hi @RaunakShah, reminder that tomorrow (April 5th) is the deadline for 1.24 Docs Ready for Review.

Please open a PR (and link it back here), push your docs content for this enhancement, and remove the work-in-progress label when ready for review.

We have a tight turnaround to getting docs reviewed and approved for the release, and we’re hoping to have all docs in for review by tomorrow. Thank you!

@xing-yang
Copy link
Contributor

Here's the doc PR: kubernetes/website#32673

@RaunakShah
Copy link
Contributor Author

@nate-double-u @xing-yang I've removed the WIP label from the doc PR.

@sftim
Copy link
Contributor

sftim commented Apr 12, 2022

This enhancement proposal mentions the annotation snapshot.storage.kubernetes.io/allowVolumeModeChange. Would it be possible to deprecate that in favor of a more conventional snapshot.storage.kubernetes.io/allow-volume-mode-change?

@xing-yang
Copy link
Contributor

This enhancement proposal mentions the annotation snapshot.storage.kubernetes.io/allowVolumeModeChange. Would it be possible to deprecate that in favor of a more conventional snapshot.storage.kubernetes.io/allow-volume-mode-change?

We could do that in 1.25.

@nate-double-u
Copy link

A note for when this KEP goes to beta (targeting v1.25): the documentation that was added in v1.24 needs to be updated.

@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 10, 2022
@Priyankasaggu11929
Copy link
Member

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone May 10, 2022
@k8s-ci-robot k8s-ci-robot removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Feb 8, 2023
@jsafrane
Copy link
Member

jsafrane commented Feb 21, 2023

@RaunakShah befora graduating to GA, please update the KEP, the new flag is in external-provisioner and snapshot-controller, not external-snapshotter sidecar:

A new out-of-tree flag named `PreventVolumeModeConversion` will be introduced on
`external-snapshotter` and `external-provisioner`. Both of these components are
out-of-tree so this proposal will not require any in-tree feature gates.

In addition, there could be version skew between the external-provisioner (shipped by a CSI driver vendor) and snapshot-controller (shipped by Kubernetes vendor). I'd appreciate a little more detail in Version skew strategy chapter, now it says it's OK, but it does not say how do we achieve that. What exactly happens when there is new a external-provisioner with old snapshot-controller.

@fsmunoz
Copy link

fsmunoz commented Mar 13, 2023

Hi @RaunakShah 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like all linked PRs are merged.

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

@xing-yang
Copy link
Contributor

Hi @fsmunoz, all code PRs are merged. Just docs/blog remaining. Thanks!

@Atharva-Shinde Atharva-Shinde removed this from the v1.27 milestone May 14, 2023
@Atharva-Shinde Atharva-Shinde removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
@xing-yang xing-yang added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status lead-opted-in Denotes that an issue has been opted in to a release and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jan 17, 2024
@xing-yang xing-yang added this to the v1.30 milestone Jan 17, 2024
@pnbrown
Copy link

pnbrown commented Feb 5, 2024

Hello @RaunakShah 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • The production readiness review should be completed. There is one unanswered question
  • Make sure the PR with the information get merged before enhancement freeze, I just found this PR.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@xing-yang
Copy link
Contributor

@pnbrown The KEP PR is merged. Please let us know if anything is missing. Thanks!
cc @RaunakShah

@pnbrown
Copy link

pnbrown commented Feb 7, 2024

@xing-yang Thank you. I've marked that complete.

There is still one question on the readiness survey that is not answered:

https://github.com/kubernetes/enhancements/blob/42fe9143b211db01ed7e6e636a4e73ac2f77ae0a/keps/sig-storage/3141-prevent-volume-mode-conversion/README.md#what-are-other-known-failure-modes

@pnbrown
Copy link

pnbrown commented Feb 9, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@Princesso
Copy link

Hello @RaunakShah, 👋 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@a-mccarthy
Copy link

Hi @RaunakShah ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@RaunakShah
Copy link
Contributor Author

@Princesso Here is the placeholder PR for the doc updates - kubernetes/website#45262
@a-mccarthy Here is the placeholder PR for the blog - kubernetes/website#45261

@pnbrown
Copy link

pnbrown commented Feb 29, 2024

Hey again @RaunakShah 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@pnbrown
Copy link

pnbrown commented Mar 5, 2024

@RaunakShah, Enhancements team here!
As this enhancement is targeting stable for this release, may you please update the status field in the kep.yaml file to implemented as the code PRs are merged and the feature gates are removed.

https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/3141-prevent-volume-mode-conversion/kep.yaml

@RaunakShah
Copy link
Contributor Author

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

Hi @pnbrown, the only tickets remaining for this KEP are documentation and blog related. There are no other code changes that need to go in.

As this enhancement is targeting stable for this release, may you please update the status field in the kep.yaml file to implemented as the code PRs are merged and the feature gates are removed.

Sure will do!

@a-mccarthy
Copy link

@RaunakShah, looks like the links for the blog and docs placeholder PRs got reversed in your comment above. The correct links are below:

@Princesso Here is the placeholder PR for the doc updates - kubernetes/website#45261
@a-mccarthy Here is the placeholder PR for the blog - kubernetes/website#45262

Please note some important deadlines for comms and docs

Please reach out if you have any questions!

@sreeram-venkitesh
Copy link
Member

Hi @RaunakShah 👋, 1.31 Enhancements Lead here.

Since this KEP has been graduated to GA in v1.30, please make sure to update the status field in the kep.yaml to implemented here, after which we can close this issue.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/out-of-tree Denotes an out-of-tree enhancement issue, which does not need to be tracked by the Release Team
Projects
Status: Graduating
Status: Tracked
Status: Tracked for Code Freeze
Development

No branches or pull requests