Allow informers for getting a stream of data instead of chunking

[p0lyn0mial]

Enhancement Description

• One-line enhancement description (can be used as a release note): informers can get a stream of data to prime the caches
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/3157-watch-list/README.md
• Discussion Link:
• Primary contact (assignee): @p0lyn0mial
• Responsible SIGs: sig-apimachinery, sig-scalability
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.27
  • Beta release target (x.y): 1.29
  • Stable release target (x.y): TBD
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3157: allow informers for getting a stream of data instead of chunking #3142
    • Update KEP 3157 for milestone 1.27 #3822
  • Code (k/k) update PR(s):
    • WIP: POC introduce API streaming kubernetes#106477
    • e2e/apimachinery: Add an e2e test for the API Streaming feature kubernetes#117277
    • cacher avoid double locking kubernetes#117410
  • Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig api-machinery
/sig scalability

[gracenng]

Hi @p0lyn0mial ! 1.24 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00pm PT on Thursday Feb 3rd. This enhancements is targeting alpha for 1.24
Here’s where this enhancement currently stands:

• Updated KEP file using the latest template has been merged into the k/enhancements repo. KEP-3157: allow informers for getting a stream of data instead of chunking #3142
• KEP status is marked as implementable for this release with latest-milestone: 1.24
• KEP has a test plan section filled out.
  - [ ] KEP has up to date graduation criteria. -- not needed for alpha
• KEP has a production readiness review that has been completed and merged into k/enhancements -- PRR not found

The status of this enhancement is track as at risk
Thanks!

[p0lyn0mial]

Hi @gracenng! Many thanks for the heads-up. Could you please double-check the last point? The KEP has the Production Readiness Review Questionnaire. In addition to that, I have filled the required bits for the alpha version - it just hasn't been reviewed yet.

[gracenng]

Hi @p0lyn0mial,
Thanks for the reply. Your PRR Questionaire in the KEP needs to be approved by the PRR team, which will result in a file in
https://github.com/kubernetes/enhancements/tree/master/keps/prod-readiness/
Your sig has not made a folder there yet, please check out the format.

Regarding your second point, I am tracking your KEP files and the first bullet will be checked when the PR is merged. Does that answer your question?

[gracenng]

Hi @p0lyn0mial , 1.24 Enhancements Team here.

Reaching out as we're less than a week away from Enhancement Freeze on Thursday, February 3rd.
There's no update for this enhancement since last checkin, let me know if I missed anything.
Current status is at risk

[p0lyn0mial]

Hi @gracenng, it looks like it won't make it to 1.24. Please leave me some instructions on how to update the KEP so it won't show up on your query.

[gracenng]

No worries I’ll take care of it

…

On Mon, Jan 31, 2022 at 12:42 AM Lukasz Szaszkiewicz < ***@***.***> wrote: Hi @gracenng <https://github.com/gracenng>, it looks like it won't make it to 1.24. Please leave me some instructions on how to update the KEP so it won't show up on your query. — Reply to this email directly, view it on GitHub <#3157 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKCRLOZTCK54ONCDRDEXZCTUYZDP3ANCNFSM5MHDCLRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Dingshujie]

@p0lyn0mial how is feature going? we met a lot of server overloading scene(kube-apiserver oom or master oom), looking forward to this feature. if you need help，you can assign some tasks to me.

[JohnRusk]

@Dingshujie BTW, if you have more than a few hundred nodes, then this fix will probably help to reduce API server load kubernetes/kubernetes#109381 . (If you have more than a few thousand nodes it will definitely help). It solves a bug where the kubelets would keep doing the same listing calls over and over again (typically immediately after a restart of the API server). Obvoiusly, other list issues are possible too, so that fix won't solve them all for you. But it might help.

[Dingshujie]

@Dingshujie BTW, if you have more than a few hundred nodes, then this fix will probably help to reduce API server load kubernetes/kubernetes#109381 . (If you have more than a few thousand nodes it will definitely help). It solves a bug where the kubelets would keep doing the same listing calls over and over again (typically immediately after a restart of the API server). Obvoiusly, other list issues are possible too, so that fix won't solve them all for you. But it might help.

@JohnRusk thanks, i already cherry-pick this to 1.23 branch. but this fixs can't slove the situation that custom-defined operator list issues.
and finally expect all list from watch cache

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[wojtek-t]

/remove-lifecycle rotten

[p0lyn0mial]

/milestone v1.26

[npolshakova]

Hello @p0lyn0mial, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

[wojtek-t]

/label lead-opted-in
/milestone v1.29

[salehsedghpour]

Hello @p0lyn0mial 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.29.
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• Make sure that the production readiness review has been merged into k/enhancements.
• Please also make sure to update the issue description with recent updates and PRs.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[salehsedghpour]

Hi @p0lyn0mial , checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. It looks like #4207 will address all of the requirements.

Let me know if I missed anything. Thanks!
Please also make sure to update the issue description with recent updates and PRs.

[salehsedghpour]

As #4207 is now merged the status of this enhancement can be marked as tracked for enhancement freeze.

[taniaduggal]

Hey there @p0lyn0mial ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

[taniaduggal]

Hey there @p0lyn0mial, The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

[taniaduggal]

Hey there @p0lyn0mial !Could you please update me on the status of docs for this enhancement? Thank you!

[p0lyn0mial]

@taniaduggal Hey, I am planning to write a blog post about the feature. However, at this point, it looks like I won't be able to enable this feature for a control plane component as I was planning, due to additional requirements arising late in the cycle.
So there is no benefit to having a blog post without enabling this feature for a component. Thanks.

[npolshakova]

Hi @p0lyn0mial, 1.29 Enhancements team here- thanks for letting us know, I'll remove this KEP from the tracking board.
/milestone clear

[mengqiy]

@p0lyn0mial It seems the feature gate still needs to be updated.
https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/features/kube_features.go#L324

[wojtek-t]

No - we didn't went beta waiting for a better more generic enablement mechanism [feature gates for client-go].
With the decision during last SIG apimachinery of how to do that, we will be targetting Beta in 1.30 here.