Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up IPTables Chain Ownership #3178

Open
4 tasks done
danwinship opened this issue Jan 23, 2022 · 21 comments
Open
4 tasks done

Cleaning up IPTables Chain Ownership #3178

danwinship opened this issue Jan 23, 2022 · 21 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@danwinship
Copy link
Contributor

danwinship commented Jan 23, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 23, 2022
@danwinship
Copy link
Contributor Author

danwinship commented Jan 23, 2022

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 23, 2022
@thockin thockin added this to New, not evaluated in SIG-Network KEPs via automation Jan 26, 2022
@thockin thockin added this to the v1.25 milestone Jan 26, 2022
@thockin
Copy link
Member

thockin commented Jan 26, 2022

This is tagged for 1.25 - is that right?

@thockin thockin self-assigned this Jan 26, 2022
@danwinship
Copy link
Contributor Author

danwinship commented Jan 27, 2022

@thockin yeah... oh, I explained in the PR but not here. It involves changing the same pieces of code that the internal traffic policy and proxy terminating endpoints and preferlocal traffic policy KEPs are changing, and I wasn't sure we had time to queue another change on top of those ones for 1.24. And it's not like it's urgent or anything anyway...

@k8s-triage-robot
Copy link

k8s-triage-robot commented Apr 27, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented May 27, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2022
@danwinship
Copy link
Contributor Author

danwinship commented May 27, 2022

/remove-lifecycle rotten

@thockin
Copy link
Member

thockin commented Jun 20, 2022

Added to spreadsheet for 25

@danwinship
Copy link
Contributor Author

danwinship commented Jun 21, 2022

Could you please confirm if this KEP targetting to beta in release cycle?

no, it is targeting alpha... so what needs to be done?

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 21, 2022

@danwinship, thanks for confirming. I corrected my above checklist for stage alpha. Thank you!

@danwinship
Copy link
Contributor Author

danwinship commented Jun 23, 2022

@Priyankasaggu11929 I believe this should now be ready for alpha

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 24, 2022

With KEP PR #3418 merged now, the enhancement is ready for the upcoming Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much! 🙂

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jul 25, 2022

Hello @danwinship 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

Please verify, if there are any additional k/k PRs besides the ones listed above.

Please plan to get the open k/k merged by the code freeze deadline. The status of the enhancement is currently marked as at-risk.

Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

@parul5sahoo
Copy link
Member

parul5sahoo commented Aug 1, 2022

Hello @danwinship 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure that the following PR(s) :-

Thanks a lot for updating the issue description with all relevant info.

@danwinship
Copy link
Contributor Author

danwinship commented Aug 1, 2022

all (non-docs) alpha PRs now merged

@danwinship danwinship moved this from Pre-Alpha (we want to do this but the KEP or code is not merged yet) to Alpha gated (code is merged) in SIG-Network KEPs Aug 1, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Aug 1, 2022

Thanks for the update, @danwinship. The status is now marked as tracked.

@sftim
Copy link
Contributor

sftim commented Aug 4, 2022

The KEP states:

We will also document the new KUBE-IPTABLES-HINT chain and its intended use, as well as the best practices for detecting the system iptables mode in previous releases.

This chain was added in v1.24; do we have plans to add that documentation (eg: for v1.25)?

@kcmartin
Copy link

kcmartin commented Aug 4, 2022

@danwinship Hi! 1.25 Docs Lead here! Adding to the comment above, today is the Docs Placeeholder PR deadline and we will need a placeholder PR to k/website today, if the KEP is correct. Please let us know if you have any questions.

@reylejano
Copy link
Member

reylejano commented Aug 10, 2022

@danwinship , we're passed the 1.25 Docs Ready for Review deadline and the KEP for this enhancement states there will be a documentation update

We will also document the new KUBE-IPTABLES-HINT chain and its intended use, as well as the best practices for detecting the system iptables mode in previous releases.

Please create a PR to add documentation to the k/website repo to the dev-1.25 branch

@danwinship
Copy link
Contributor Author

danwinship commented Aug 16, 2022

sorry, belatedly created kubernetes/website#36020

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@thockin thockin modified the milestones: v1.25, 1.27, v1.27 Sep 29, 2022
@thockin
Copy link
Member

thockin commented Sep 29, 2022

Can't proceed until 1.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
SIG-Network KEPs
Alpha gated (code is merged)
Development

No branches or pull requests

10 participants