Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect PodTopologySpread after rolling upgrades #3243

Open
8 tasks done
denkensk opened this issue Mar 18, 2022 · 27 comments
Open
8 tasks done

Respect PodTopologySpread after rolling upgrades #3243

denkensk opened this issue Mar 18, 2022 · 27 comments
Assignees
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@denkensk
Copy link
Member

denkensk commented Mar 18, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 18, 2022
@denkensk
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 18, 2022
@denkensk
Copy link
Member Author

denkensk commented Jun 9, 2022

/assign

@ahg-g
Copy link
Member

ahg-g commented Jun 15, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 15, 2022
@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 15, 2022
@Priyankasaggu11929
Copy link
Member

Hello @denkensk 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For note, the status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Atharva-Shinde
Copy link
Contributor

Hi @denkensk Enhancements team here again 👋

Checking in as we approach Code Freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure that the following items are completed before the code-freeze:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Currently, the status of the enhancement is marked as at-risk

Thanks :)

@Atharva-Shinde
Copy link
Contributor

Hey @denkensk as kubernetes/kubernetes#111441 PR is now merged and included in the issue description, I have marked this enhancement as tracked :)

@ahg-g
Copy link
Member

ahg-g commented Aug 5, 2022

@denkensk can you please open a docs PR?

@denkensk
Copy link
Member Author

denkensk commented Aug 6, 2022

Sorry. I created it before, forgot to link it with this issue. kubernetes/website#35165

@rhockenbury rhockenbury added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 11, 2022
@kerthcet
Copy link
Member

kerthcet commented Dec 6, 2022

Hope to see this feature promoting to beta in v1.27, we delayed our blog about the improvements of PodTopologySpread in recent several releases, and we hope to post one in v1.27, including minDomains, nodeInclusionPolicy.

If you're out of bandwidth, I can help with you @denkensk

@denkensk
Copy link
Member Author

denkensk commented Dec 9, 2022

Thanks. I will promote it to beta in v1.27.

@alculquicondor
Copy link
Member

@denkensk note that the Enhancements freeze has been set for February 10th.

@ahg-g
Copy link
Member

ahg-g commented Jan 11, 2023

@denkensk are you planning to move this to beta? @kerthcet would you like to pick it up if @denkensk can't?

@kerthcet
Copy link
Member

@denkensk are you planning to move this to beta? @kerthcet would you like to pick it up if @denkensk can't?

I can help, but up to @denkensk

@denkensk
Copy link
Member Author

@denkensk note that the Enhancements freeze has been set for February 10th.

OK Thanks. I am working on this and will submit PR this week.

@ahg-g
Copy link
Member

ahg-g commented Jan 12, 2023

/label lead-opted-in
/milestone v1.27

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.25, v1.27 Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2023
@ahg-g
Copy link
Member

ahg-g commented Jan 23, 2023

/stage beta

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jan 23, 2023
@fsmunoz
Copy link

fsmunoz commented Feb 1, 2023

Hello @denkensk 👋, v1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

  • Update kep.yaml to reflect current stage information.
  • Complete the missing PRR sections

#3740 might address this, once it's merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@denkensk
Copy link
Member Author

denkensk commented Feb 2, 2023

Update kep.yaml to reflect current stage information.

Done @fsmunoz

@fsmunoz
Copy link

fsmunoz commented Feb 5, 2023

Thank you @denkensk ! This is almost there, there is a new question in the PRR Scalability that you might want to address:

Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

The Scalability section of the PRR is mandatory for beta, hence why I am mentioning it.

@denkensk
Copy link
Member Author

denkensk commented Feb 8, 2023

This is almost there, there is a new question in the PRR Scalability that you might want to address:

Done @fsmunoz

@fsmunoz
Copy link

fsmunoz commented Feb 8, 2023

Thank you @denkensk !

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

This enhancement is ready to be traced for graduation to beta in v1.27.
/label tracked/yes
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 8, 2023
@fsmunoz
Copy link

fsmunoz commented Mar 13, 2023

Hi @denkensk 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like all linked PRs are merged.

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

@Atharva-Shinde Atharva-Shinde removed this from the v1.27 milestone May 14, 2023
@Atharva-Shinde Atharva-Shinde removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2024
@alculquicondor
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2024
@kerthcet
Copy link
Member

/remove-lifecycle rotten

I think we can consider to update to GA next release.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: Needs Triage
Development

No branches or pull requests

10 participants