Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guarantee PodDisruptionBudget When Preemption Happens #3280

Open
1 of 4 tasks
denkensk opened this issue Apr 19, 2022 · 23 comments
Open
1 of 4 tasks

Guarantee PodDisruptionBudget When Preemption Happens #3280

denkensk opened this issue Apr 19, 2022 · 23 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@denkensk
Copy link
Member

denkensk commented Apr 19, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 19, 2022
@denkensk
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 19, 2022
@denkensk
Copy link
Member Author

/cc @ahg-g @Huang-Wei @alculquicondor

@ahg-g
Copy link
Member

ahg-g commented Apr 19, 2022

I will review it this week.

@denkensk
Copy link
Member Author

denkensk commented May 6, 2022

The early draft: https://docs.google.com/document/d/1g2wj8S04M0yTy2t4l4GzrdARtxBpkBTfkJHw0oqBvXM/edit?usp=sharing
@ahg-g Thank you for giving some comments in it if you have time.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 4, 2022
@jeroenj
Copy link

jeroenj commented Aug 22, 2022

I had a look at the early draft and it exactly describes what we would be in need of.

@sanposhiho
Copy link
Member

/remove-lifecycle stale

@kerthcet
Copy link
Member

kerthcet commented Sep 8, 2022

/cc

@kerthcet
Copy link
Member

kerthcet commented Sep 8, 2022

Another idea is can we add a new field to podSpec like PreemptionPolicy, maybe PreemptedPolicy. For if we apply the so called PreemptLowerPriorityWithoutViolatePDB in scheduler, it will impact all scheduling pods, but maybe some pods can tolerate the preemptions even they have PDB protecting. Then even for PreemptLowerPriority policy, we can also prevent pod from preemption if they want.

This is one approach I thinked of, my intension here is we may come out an idea more flexible.

@denkensk
Copy link
Member Author

denkensk commented Sep 8, 2022

@kerthcet It likes the option1 in my design. option1 Add PreemptLowerPriorityWithoutViolatePDB as an option in the PreemptionPolicy You can give your comments in the google doc https://docs.google.com/document/d/1g2wj8S04M0yTy2t4l4GzrdARtxBpkBTfkJHw0oqBvXM/edit?usp=sharing

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 7, 2022
@kerthcet
Copy link
Member

kerthcet commented Dec 8, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2022
@ahg-g
Copy link
Member

ahg-g commented Jan 11, 2023

@denkensk are you planning to work on this in 1.27?

@denkensk
Copy link
Member Author

@denkensk are you planning to work on this in 1.27?

Yes. Will work on it in 1.27.

@denkensk
Copy link
Member Author

/assign @denkensk

@ahg-g
Copy link
Member

ahg-g commented Jan 23, 2023

/stage alpha
/milestone v1.27
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 23, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 23, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 23, 2023
@npolshakova
Copy link

npolshakova commented Feb 2, 2023

Hello @denkensk 👋, 1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like #3755 will address most of these issues.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@npolshakova
Copy link

Looks like with #3755 merged this enhancement as tracked for v1.27.
Thanks!

/remove-label tracked/no
/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 9, 2023
@k8s-ci-robot
Copy link
Contributor

@npolshakova: Those labels are not set on the issue: tracked/no

In response to this:

Looks like with #3755 merged this enhancement as tracked for v1.27.
Thanks!

/remove-label tracked/no
/label tracked/yes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mickeyboxell
Copy link

Hi @denkensk 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@npolshakova
Copy link

npolshakova commented Mar 9, 2023

Hi @denkensk,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

@npolshakova
Copy link

Hi @denkensk, this is the status as we approach code freeze today:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs need to merge:

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

@npolshakova
Copy link

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed this from the v1.27 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Status: Removed From Milestone
Development

No branches or pull requests

9 participants