Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated Discovery #3352

Open
3 of 4 tasks
Jefftree opened this issue Jun 7, 2022 · 28 comments
Open
3 of 4 tasks

Aggregated Discovery #3352

Jefftree opened this issue Jun 7, 2022 · 28 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@Jefftree
Copy link
Member

Jefftree commented Jun 7, 2022

Enhancement Description

  • One-line enhancement description (can be used as a release note): Aggregated Discovery
  • Kubernetes Enhancement Proposal: KEP
  • Discussion Link:
  • Primary contact (assignee): @Jefftree
  • Responsible SIGs: SIG API Machinery, SIG CLI
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.26
    • Beta release target (x.y): 1.27
    • Stable release target (x.y):
  • Alpha
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 7, 2022
@Jefftree
Copy link
Member Author

Jefftree commented Jun 7, 2022

/sig api-machinery
/sig cli

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 7, 2022
@Priyankasaggu11929 Priyankasaggu11929 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 10, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 10, 2022

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 10, 2022
@Priyankasaggu11929 Priyankasaggu11929 added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 11, 2022
@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 11, 2022

Hello @Jefftree 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage alpha for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would just need to get the open KEP PR #3364 merged by the Enhancements Freeze.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 17, 2022

Hello @Jefftree 👋, just a quick check-in again, as we approach the 1.25 enhancements freeze.

Please plan to get the open KEP PR merged before enhancements freeze on Thursday, June 23, 2022 at 18:00 PM PT.

For note, the current status of the enhancement is atat-risk. Thank you!

@Priyankasaggu11929
Copy link
Member

Priyankasaggu11929 commented Jun 24, 2022

With KEP PR #3364 merged now, the enhancement is ready for the upcoming Enhancements Freeze.

For note, the status is now marked as tracked. Thank you so much!

@didicodes
Copy link

didicodes commented Jul 13, 2022

Hello @Jefftree 👋, 1.25 Release Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for the 1.25 release. Please follow the steps detailed in the documentation to open a PR against the dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by August 4.


Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thank you!

@Atharva-Shinde
Copy link

Atharva-Shinde commented Jul 25, 2022

Hi @Jefftree, Enhancements team here again 👋

Checking in as we approach Code Freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure that the following items are completed before the code-freeze:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Currently, the status of the enhancement is marked as at-risk

Thanks :)

@Atharva-Shinde
Copy link

Atharva-Shinde commented Aug 1, 2022

Hey @Jefftree , reaching out again as we approach Code Freeze at 01:00 UTC on this Wednesday i.e 3rd August 2022.
Try to get this PR kubernetes/kubernetes#111409 merged and update the Issue Description by adding the PR linked, before the code-freeze :)

The status of the enhancement is still marked as at-risk

@Jefftree
Copy link
Member Author

Jefftree commented Aug 1, 2022

Hello, we will be dropping this enhancement for 1.25. Thanks!

@Atharva-Shinde
Copy link

Atharva-Shinde commented Aug 1, 2022

Thanks for the update @Jefftree ! I have marked this enhancement as Removed from milestone in the tracking sheet.
Clearing the milestone
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.25 milestone Aug 1, 2022
@Priyankasaggu11929 Priyankasaggu11929 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 3, 2022
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 16, 2022

If you're moving forward with this, please update the kep.yaml that just merged as it has milestone 1.25 still :)

@deads2k
Copy link
Contributor

deads2k commented Oct 3, 2022

/milestone v1.26
/label lead-opted-in
/label tracked/yes

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Oct 3, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 3, 2022

@deads2k: Can not set label tracked/yes: Must be member in one of these teams: [release-team-enhancements release-team-leads]

In response to this:

/milestone v1.26
/label lead-opted-in
/label tracked/yes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhockenbury
Copy link

rhockenbury commented Oct 3, 2022

/label tracked/yes
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 3, 2022
@ruheenaansari34
Copy link

ruheenaansari34 commented Oct 4, 2022

Hello @Jefftree 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the latest milestone to 1.26 and the milestone at which this feature was, or is targeted to be, at each stage, here

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ruheenaansari34
Copy link

ruheenaansari34 commented Oct 4, 2022

Quick reminder - Enhancement freeze is 2 days away. If you are still looking to get this enhancement into v1.26, please plan to make the updates to the KEP yaml and get the PR merged.

@rhockenbury
Copy link

rhockenbury commented Oct 7, 2022

With #3534 merged, this is tracked for v1.26.

@mickeyboxell
Copy link

mickeyboxell commented Oct 20, 2022

@Jefftree Are docs required for this KEP? If so, who will be opening the docs PR for k/website?

@ruheenaansari34
Copy link

ruheenaansari34 commented Nov 2, 2022

Hi @Jefftree 👋,

Checking in once more as we approach the 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze. If you do have any other k/k PRs open, please link them to this issue.:

As always, we are here to help should questions come up. Thanks!

@mickeyboxell
Copy link

mickeyboxell commented Nov 2, 2022

Hi @Jefftree 👋 This enhancement is marked as Needs Docs for 1.26 release. Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time. It must be created by November 9. For more information, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

@alexzielenski
Copy link
Contributor

alexzielenski commented Nov 6, 2022

@ruheenaansari34 the three PRs you linked were rolled into a single one "Aggregated discovery server changes" linked below:

This KEP has two outstanding PRs needing to be merged by code freeze:

@ruheenaansari34
Copy link

ruheenaansari34 commented Nov 7, 2022

Thanks for the information. Please ensure to link them in the issue description as well.

@mickeyboxell
Copy link

mickeyboxell commented Nov 8, 2022

Hey @Jefftree, please remember to open a PR against dev-1.26 branch in the k/website repo. This PR is needed by November 9 and can be just a placeholder at this time.

@rhockenbury
Copy link

rhockenbury commented Nov 9, 2022

Hello 👋, 1.26 Enhancements Lead here.

Unfortunately, this enhancement did not meet requirements for code freeze.

If you still wish to progress this enhancement in v1.26, please file an exception request. Thanks!

NOTE: PRs are only waiting on queue, and have lgtm and approve.

/milestone clear
/label tracked/no
/remove-label tracked/yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Nov 9, 2022
@k8s-ci-robot k8s-ci-robot removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Nov 9, 2022
@apelisse
Copy link
Member

apelisse commented Nov 14, 2022

Just seeing that now unfortunately. How come this "does not meet the requirements"? The code was merged by code-freeze date.

@lavalamp
Copy link
Member

lavalamp commented Nov 14, 2022

@rhockenbury was this removed in error? Which requirement was missing?

@rhockenbury
Copy link

rhockenbury commented Nov 14, 2022

Yes, I meant to add this one back. The PRs were approved before the code freeze deadline.

/milestone v1.26
/label tracked/yes
/remove-label tracked/no
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels Nov 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 14, 2022
@k8s-ci-robot k8s-ci-robot removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Nov 14, 2022
@jberkus
Copy link
Contributor

jberkus commented Nov 15, 2022

Please link the final KEP from the main text of this Enhancement, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Net New
Development

No branches or pull requests