Minimizing iptables-restore input size

[danwinship]

Enhancement Description

• One-line enhancement description (can be used as a release note): Minimizing iptables-restore input size
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3453-minimize-iptables-restore/README.md
• Discussion Link: minimize iptables-restore input kubernetes#110268 (review)
• Primary contact (assignee): @danwinship
• Responsible SIGs: sig-network
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.26
  • Beta release target (x.y): 1.27
  • Stable release target (x.y): 1.28
• Alpha
  • KEP (k/enhancements) update PR(s): Minimizing iptables-restore input size #3454
  • Code (k/k) update PR(s): minimize iptables-restore input kubernetes#110268, Don't re-run EnsureChain/EnsureRules on partial syncs kubernetes#114181
  • Testing update PR(s): enable kube-proxy feature-gates=MinimizeIPTablesRestore on scalabilit… test-infra#27927, kube-proxy iptables partial restore failures perf-tests#2182, use kube-proxy defaults values for CI kubernetes#114229
  • Docs (k/website) update PR(s): KEP 3453 iptables performance alpha feature docs website#37649, add kube-proxy iptables performance optimization notes website#38435
• Beta
  • KEP (k/enhancements) update PR(s): KEP-3453 minimize iptables-restore to Beta #3577
  • Code (k/k) update PR(s): Move KEP-3453 MinimizeIPTablesRestore to beta kubernetes#115138
  • Docs (k/website) update(s): Update iptables perf / KEP-3453 discussion for 1.27 website#39188
• Stable
  • KEP (k/enhancements) update PR(s): KEP-3453: MinimizeIPTablesRestore to GA for 1.28 #3972
  • Code (k/k) update PR(s): Add new partial/full sync time metrics for iptables kube-proxy kubernetes#117787, MinimizeIPTablesRestore to GA kubernetes#117872, fix sync_proxy_rules_iptables_total metric kubernetes#119140
  • Docs (k/website) update(s): KEP-3453 to GA website#41031
• Post-GA
  • Code (k/k) update PR to remove feature gate: Remove GA featuregate about MinimizeIPTablesRestore in 1.30 kubernetes#122136

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[danwinship]

/sig network

[aojea]

/label lead-opted-in

[aojea]

sudo @thockin /label lead-opted-in

[k8s-ci-robot]

@aojea: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhockenbury]

/label lead-opted-in
/milestone v1.26
/label tracked/yes
/stage alpha
/kind kep

[ruheenaansari34]

Hello @danwinship 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.26
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to merge #3454, which will take care of above requirements.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[thockin]

Candidate for Alpha in 1.26

[danwinship]

@ruheenaansari34 #3454 is merged. Can you confirm that we are OK for Alpha?

[ruheenaansari34]

Here’s where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.26
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up-to-date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[parul5sahoo]

Hi @danwinship 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

For this enhancement, open PR. Please plan to get PRs out for all k/k code so it can be merged up by code freeze. If you do have k/k PRs open, please link them to this issue. Let me know if there aren't any further PRs that need to be created or merged for this enhancements, so that I can mark it as tracked for code freeze.

As always, we are here to help should questions come up. Thanks!

[cathchu]

Hi there @danwinship 👋 1.26 Docs Shadow here.

This enhancement is marked as ‘Needs Docs’ for 1.26 release. I see you've opened kubernetes/website#37649. I'd like to confirm that all Docs related changes will be included in this PR.

If not, please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

[parul5sahoo]

Hey @danwinship ,

As the Code freeze is just a day away, just wanted to confirm that there are no open PRs in the K/K repo or any repo in general for this enhancement other than the ones outlined in the issues description? So that the enhancement can be marked tracked.

[danwinship]

@parul5sahoo There is nothing more to be merged to k/k, but the KEP graduation criteria said we'd enable the feature in some of the periodic scale tests, which has not yet happened. But I guess that would be due by next week's Test Freeze, not tomorrow's Code Freeze, right?

[krol3]

Here another relevant doc-PR kubernetes/website#36675 related this KEP

[marosset]

Hi @danwinship 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

[taniaduggal]

Hi @danwinship 👋 , I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

[danwinship]

This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

There is already a docs PR filed (kubernetes/website#39188). It was waiting for dev-1.27 to be updated for a while but it's rebased now and can be merged once it's approved.

[thockin]

NEXT: Aiming for GA in 1.28

[Atharva-Shinde]

Hello @danwinship 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting for stage stable for v1.28 (correct me if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone:v1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[Atharva-Shinde]

/stage stable

[Atharva-Shinde]

Hey again @danwinship 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

• All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
• All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

These are the code related PR/s that I found on this KEP issue:

• Add new partial/full sync time metrics for iptables kube-proxy kubernetes#117787
• MinimizeIPTablesRestore to GA kubernetes#117872

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

[Atharva-Shinde]

Hey @danwinship 👋 Enhancements Lead here,
With kubernetes/kubernetes#117787 and kubernetes/kubernetes#117872 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

[npolshakova]

Hey @danwinship 👋 1.29 Enhancements Lead here, is there any more work planned for this KEP? Also is the milestone accurate (are you targeting v1.30 instead of v1.29?)

[npolshakova]

/remove-label lead-opted-in

[danwinship]

@npolshakova I'm not sure this needs to be tracked by the release team at this point, since it is already GA. The issue is just being left open to remind us to finish the cleanup 2 releases post-GA (so yes, the next expected change is in 1.30, not 1.29).

[salehsedghpour]

/milestone clear

[danwinship]

implemented, and feature gate removed