Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transient node predicates from KCCM's service controller #3458

Open
2 of 8 tasks
alexanderConstantinescu opened this issue Aug 7, 2022 · 37 comments
Open
2 of 8 tasks
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@alexanderConstantinescu
Copy link
Member

alexanderConstantinescu commented Aug 7, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 7, 2022
@alexanderConstantinescu
Copy link
Member Author

/sig network
/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 7, 2022
@thockin thockin added this to New, not evaluated in SIG-Network KEPs via automation Sep 29, 2022
@thockin thockin moved this from New, not evaluated to Pre-Alpha (we want to do this but the KEP or code is not merged yet) in SIG-Network KEPs Sep 29, 2022
@thockin thockin added this to the v1.27 milestone Sep 29, 2022
@thockin
Copy link
Member

thockin commented Sep 29, 2022

Punting to 1.27

@thockin thockin self-assigned this Sep 29, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2022
@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2023
@thockin
Copy link
Member

thockin commented Feb 2, 2023

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2023
@alexanderConstantinescu
Copy link
Member Author

/retitle Remove transient node predicates from KCCM's service controller

@k8s-ci-robot k8s-ci-robot changed the title Dynamically re-configure LB node set Remove transient node predicates from KCCM's service controller Feb 3, 2023
@marosset
Copy link
Contributor

marosset commented Feb 3, 2023

@thockin @alexanderConstantinescu can one of you confirm that this targeting beta for v1.27.
Thanks!

@alexanderConstantinescu
Copy link
Member Author

Yes, that is correct and what we've discussed / agreed on the KEP. Maybe @thockin wants to give the final confirmation?

@thockin
Copy link
Member

thockin commented Feb 3, 2023

yes please - this one doesn't have APi so doesn't need an alpha

@marosset
Copy link
Contributor

marosset commented Feb 7, 2023

Thanks @thockin @alexanderConstantinescu

@marosset
Copy link
Contributor

marosset commented Feb 7, 2023

Once #3835 merges this enhancement will be ready for inclusion in v1.27

@shatoboar
Copy link

With #3835 merged this enhancement is ready to be tracked for 1.27.
Thanks!

@shatoboar shatoboar added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 12, 2023
@shatoboar
Copy link

shatoboar commented Mar 12, 2023

Hi @thockin 👋,
Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.
Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Please let me know what PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

@thockin thockin moved this from Pre-Alpha (we want to do this but the KEP or code is not merged yet) to Beta gated (merged) in SIG-Network KEPs Mar 16, 2023
@marosset marosset added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Mar 20, 2023
@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 7, 2023
@salehsedghpour
Copy link

Hello @alexanderConstantinescu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage stable for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • The kep.yaml file is a bit confusing for me, is this enhancement targeting1.28 for the stage stable or beta?

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@thockin
Copy link
Member

thockin commented Jun 13, 2023

@alexanderConstantinescu
Copy link
Member Author

Are we on-target for GA iin 1.28?

Sorry for the late reply to this: the KEP says GA in 1.29 that isn't advanced to 1.28 just because the release went well, right?

@alexanderConstantinescu
Copy link
Member Author

@alexanderConstantinescu https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3458-remove-transient-node-predicates-from-service-controller/kep.yaml still says "beta" and needs final PRR signoff (thanks, @wojtek-t for the poke)

Thanks for the reminder! Here's the PR: #4088

I didn't update the stable milestone because of I mentioned above

@thockin thockin modified the milestones: v1.28, v1.29 Jun 14, 2023
@thockin
Copy link
Member

thockin commented Jun 14, 2023

Sorry, somehow I thought it was GA this release. Milestone bumped

@Rishit-dagli
Copy link
Member

Hello @thockin @alexanderConstantinescu 👋, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@alexanderConstantinescu
Copy link
Member Author

@Rishit-dagli : sorry for the late reply

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

No, it does not.

@salehsedghpour
Copy link

Hey again @alexanderConstantinescu 👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .
Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.
    For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@Atharva-Shinde
Copy link
Contributor

Hey @alexanderConstantinescu 👋 Enhancements Lead here,
With kubernetes/kubernetes#115204 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@thockin
Copy link
Member

thockin commented Aug 17, 2023

I am tracking this for GA in 1.29 - is that correct?

@alexanderConstantinescu
Copy link
Member Author

I am tracking this for GA in 1.29 - is that correct?

Yes, that is correct.

@salehsedghpour
Copy link

salehsedghpour commented Sep 20, 2023

Hello @alexanderConstantinescu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implemented for latest-milestone: 1.29.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to add/update the following:

  • KEP readme using the latest template has been merged into the k/enhancements repo
  • The kep.yaml file based on the recent changes
  • Update the issue description.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@BenTheElder
Copy link
Member

I think this PR needs a metadata bump like https://github.com/kubernetes/enhancements/pull/4088/files

@salehsedghpour
Copy link

Hello @alexanderConstantinescu 👋,

checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. But It looks like #4257 addresses most of the requirements. With this the status will be updated to tracked for the enhancement freeze.

Please let me know if I missed anything.

I would like to also ask to keep the issue description up-to-date with proper information such as the link to the merged PR.

@alexanderConstantinescu
Copy link
Member Author

But It looks like #4257 addresses most of the requirements. With this the status will be updated to tracked for the enhancement freeze.

Hi @salehsedghpour ! That PR has merged and should fulfill all necessary requirements for progressing this KEP to the next phase. Let me know if anything is missing, but this KEP should be ready now for the next Kube release.

@salehsedghpour
Copy link

Hi @alexanderConstantinescu, thanks for the update. the status is now tracked for the enhancement freeze.

@harshitasao
Copy link

Hi @alexanderConstantinescu 👋, v1.29 Docs Shadow here
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@salehsedghpour
Copy link

salehsedghpour commented Oct 22, 2023

Hey again @alexanderConstantinescu 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs (including kubernetes/kubernetes#121091, I guess) of this KEP under a new stable section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are any other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@kcmartin
Copy link

Hi @alexanderConstantinescu ! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

@npolshakova
Copy link

npolshakova commented Nov 1, 2023

Hello @alexanderConstantinescu 👋, 1.29 Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

The test freeze is 01:00 UTC Wednesday 15th November 2023 / 18:00 PDT Tuesday 14th November 2023. Please make sure all test PRs are merged in by then. The tracked test PRs for this KEP are:

Please let me know if there are additional test PRs we should track. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: Tracked
Status: Tracked for Code Freeze
SIG-Network KEPs
Beta gated (merged)
Development

No branches or pull requests