Remove transient node predicates from KCCM's service controller

[alexanderConstantinescu]

Enhancement Description

• One-line enhancement description (can be used as a release note): Remove transient node predicates from KCCM's service controller
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3458-remove-transient-node-predicates-from-service-controller/README.md
• Discussion Link: Avoid re-syncing LBs for ETP=local services kubernetes#109706 (comment) / Avoid re-syncing LBs for ETP=local services kubernetes#109706 (comment)
• Primary contact (assignee): @alexanderConstantinescu
• Responsible SIGs: sig-network / sig-cloud-provider
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.26
  • Beta release target (x.y): 1.27
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3458: Remove transient node predicates from KCCM's service controller #3460
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):
• Beta
  • KEP (k/enhancements) update PR(s):
    • KEP 3458: address left over comments / KEP requirements #3835
  • Code (k/k) update PR(s):
    • [KCCM - service controller]: KEP-3458 implementation kubernetes#115204
  • Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[alexanderConstantinescu]

/sig network
/sig cloud-provider

[thockin]

Punting to 1.27

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[thockin]

/label lead-opted-in

[alexanderConstantinescu]

/retitle Remove transient node predicates from KCCM's service controller

[marosset]

@thockin @alexanderConstantinescu can one of you confirm that this targeting beta for v1.27.
Thanks!

[alexanderConstantinescu]

Yes, that is correct and what we've discussed / agreed on the KEP. Maybe @thockin wants to give the final confirmation?

[thockin]

yes please - this one doesn't have APi so doesn't need an alpha

[marosset]

Thanks @thockin @alexanderConstantinescu

[marosset]

Once #3835 merges this enhancement will be ready for inclusion in v1.27

[shatoboar]

With #3835 merged this enhancement is ready to be tracked for 1.27.
Thanks!

[shatoboar]

Hi @thockin 👋,
Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.
Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

Please let me know what PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

[mickeyboxell]

@alexanderConstantinescu was there a Docs PR opened against dev-1.27 branch in the k/website repo?

If not, please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

[alexanderConstantinescu]

Hi @mickeyboxell!

I am not sure what features qualify for a doc PR. My PR introduces no user-facing changes, would that still require a doc PR? I am asking because the link provided states:

Do your best to describe your feature and how to use it.

But there is no "explicit way to use", I guess one can see it as a "performance improvement" of sorts.

[thockin]

I think a release note is all that should be needed here.

…

On Tue, Mar 21, 2023 at 3:48 AM Alexander Constantinescu < ***@***.***> wrote: Hi @mickeyboxell <https://github.com/mickeyboxell>! I am not sure what features qualify for a doc PR. My PR introduces no user-facing changes, would that still require a doc PR? I am asking because the link provided states: Do your best to describe your feature and how to use it. But there is no "explicit way to use", I guess one can see it as a "performance improvement" of sorts. — Reply to this email directly, view it on GitHub <#3458 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKWAVEZZ2EJCH65G3XXFBTW5GBPHANCNFSM552KGYSQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>