Remove transient node predicates from KCCM's service controller

[alexanderConstantinescu]

Enhancement Description

• One-line enhancement description (can be used as a release note): Remove transient node predicates from KCCM's service controller
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/3458-remove-transient-node-predicates-from-service-controller/README.md
• Discussion Link: Avoid re-syncing LBs for ETP=local services kubernetes#109706 (comment) / Avoid re-syncing LBs for ETP=local services kubernetes#109706 (comment)
• Primary contact (assignee): @alexanderConstantinescu
• Responsible SIGs: sig-network / sig-cloud-provider
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.26
  • Beta release target (x.y): 1.27
  • Stable release target (x.y): 1.30
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3458: Remove transient node predicates from KCCM's service controller #3460
  • Code (k/k) update PR(s):
    • [KCCM - service controller]: KEP-3458 implementation kubernetes#115204
  • Docs (k/website) update PR(s):
• Beta
  • KEP (k/enhancements) update PR(s):
    • KEP 3458 - 1.28 milestone bump #4088
  • Code (k/k) update PR(s):
  • Docs (k/website) update(s):
• Stable
  • KEP (k/enhancements) update PR(s):
    • [KEP 3458]: 1.29 milestone bump - stable #4257
  • Code (k/k) update PR(s):
    • KEP 3458 - promote to stable kubernetes#122961
  • Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[alexanderConstantinescu]

/sig network
/sig cloud-provider

[thockin]

Punting to 1.27

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[thockin]

/label lead-opted-in

[alexanderConstantinescu]

/retitle Remove transient node predicates from KCCM's service controller

[marosset]

@thockin @alexanderConstantinescu can one of you confirm that this targeting beta for v1.27.
Thanks!

[alexanderConstantinescu]

Yes, that is correct and what we've discussed / agreed on the KEP. Maybe @thockin wants to give the final confirmation?

[thockin]

yes please - this one doesn't have APi so doesn't need an alpha

[marosset]

Thanks @thockin @alexanderConstantinescu

[marosset]

Once #3835 merges this enhancement will be ready for inclusion in v1.27

[shatoboar]

With #3835 merged this enhancement is ready to be tracked for 1.27.
Thanks!

[danwinship]

@alexanderConstantinescu can you update the checklist in the initial comment with the current state? (Like, it currently shows that alpha is incomplete, but my understanding from reading the comments here is that it's actually GA.)

[alexanderConstantinescu]

I've updated the description to this PR, should be up-to-date now.

[thockin]

GA'ed in 30, Cleanup in 32

[sreeram-venkitesh]

Hi! v1.31 Enhancements lead here 👋🏼

I'm assuming the status will be updated to implemented in v1.32 along with the cleanup, right? I'll remove the lead-opted-in label and remove this KEP from the v1.31 tracking board. Please let me know if this works.

/remove-label lead-opted-in

[alexanderConstantinescu]

GA'ed in 30, Cleanup in 32

@thockin : isn't it cleanup in 31? Ref: https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L1144 - might be that the comment is wrong and that we need to let it soak for 2 releases in stable?

[thockin]

Unless I am losing my mind, cleanup is GA+2

[Shubham82]

Hi @alexanderConstantinescu, as discussed above do you have any plan to update the comment mentioned in the kube_feature.go i.e. instead of GA in 1.30, remove in 1.31 it should be GA in 1.30, remove in 1.32

StableLoadBalancerNodeSet: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // GA in 1.30, remove in 1.32

[Shubham82]

Hi @alexanderConstantinescu, as discussed above do you have any plan to update the comment mentioned in the kube_feature.go i.e. instead of GA in 1.30, remove in 1.31 it should be GA in 1.30, remove in 1.32

StableLoadBalancerNodeSet: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // GA in 1.30, remove in 1.32

I will update it.

[Shubham82]

I have Fixed comment in following PR: kubernetes/kubernetes#126383
PTAL!

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Shubham82]

I think we can close this issue as this KEP is implemented, see reference PR #4799

[Shubham82]

/remove-lifecycle stale

[aojea]

I think we can close this issue as this KEP is implemented, see reference PR #4799

yep kubernetes/kubernetes#126841

Thanks

/close

[k8s-ci-robot]

@aojea: Closing this issue.

In response to this:

I think we can close this issue as this KEP is implemented, see reference PR #4799

yep kubernetes/kubernetes#126841

Thanks

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.