Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transient node predicates from KCCM's service controller #3458

Open
2 of 8 tasks
alexanderConstantinescu opened this issue Aug 7, 2022 · 15 comments
Open
2 of 8 tasks
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@alexanderConstantinescu
Copy link
Member

alexanderConstantinescu commented Aug 7, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 7, 2022
@alexanderConstantinescu
Copy link
Member Author

/sig network
/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 7, 2022
@thockin thockin added this to New, not evaluated in SIG-Network KEPs via automation Sep 29, 2022
@thockin thockin moved this from New, not evaluated to Pre-Alpha (we want to do this but the KEP or code is not merged yet) in SIG-Network KEPs Sep 29, 2022
@thockin thockin added this to the v1.27 milestone Sep 29, 2022
@thockin
Copy link
Member

thockin commented Sep 29, 2022

Punting to 1.27

@thockin thockin self-assigned this Sep 29, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2022
@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2023
@thockin
Copy link
Member

thockin commented Feb 2, 2023

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2023
@alexanderConstantinescu
Copy link
Member Author

/retitle Remove transient node predicates from KCCM's service controller

@k8s-ci-robot k8s-ci-robot changed the title Dynamically re-configure LB node set Remove transient node predicates from KCCM's service controller Feb 3, 2023
@marosset
Copy link
Contributor

marosset commented Feb 3, 2023

@thockin @alexanderConstantinescu can one of you confirm that this targeting beta for v1.27.
Thanks!

@alexanderConstantinescu
Copy link
Member Author

Yes, that is correct and what we've discussed / agreed on the KEP. Maybe @thockin wants to give the final confirmation?

@thockin
Copy link
Member

thockin commented Feb 3, 2023

yes please - this one doesn't have APi so doesn't need an alpha

@marosset
Copy link
Contributor

marosset commented Feb 7, 2023

Thanks @thockin @alexanderConstantinescu

@marosset
Copy link
Contributor

marosset commented Feb 7, 2023

Once #3835 merges this enhancement will be ready for inclusion in v1.27

@shatoboar
Copy link

With #3835 merged this enhancement is ready to be tracked for 1.27.
Thanks!

@shatoboar shatoboar added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 12, 2023
@shatoboar
Copy link

shatoboar commented Mar 12, 2023

Hi @thockin 👋,
Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.
Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Please let me know what PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

@thockin thockin moved this from Pre-Alpha (we want to do this but the KEP or code is not merged yet) to Beta gated (merged) in SIG-Network KEPs Mar 16, 2023
@marosset marosset added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Mar 20, 2023
@mickeyboxell
Copy link

@alexanderConstantinescu was there a Docs PR opened against dev-1.27 branch in the k/website repo?

If not, please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@alexanderConstantinescu
Copy link
Member Author

Hi @mickeyboxell!

I am not sure what features qualify for a doc PR. My PR introduces no user-facing changes, would that still require a doc PR? I am asking because the link provided states:

Do your best to describe your feature and how to use it.

But there is no "explicit way to use", I guess one can see it as a "performance improvement" of sorts.

@thockin
Copy link
Member

thockin commented Mar 21, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked
SIG-Network KEPs
Beta gated (merged)
Development

No branches or pull requests

7 participants