Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transient node predicates from KCCM's service controller #3458

Open
8 of 12 tasks
alexanderConstantinescu opened this issue Aug 7, 2022 · 68 comments
Open
8 of 12 tasks
Assignees
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@alexanderConstantinescu
Copy link
Member

alexanderConstantinescu commented Aug 7, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 7, 2022
@alexanderConstantinescu
Copy link
Member Author

/sig network
/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 7, 2022
@thockin thockin moved this from New, not evaluated to Pre-Alpha (we want to do this but the KEP or code is not merged yet) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Sep 29, 2022
@thockin thockin added this to the v1.27 milestone Sep 29, 2022
@thockin
Copy link
Member

thockin commented Sep 29, 2022

Punting to 1.27

@thockin thockin self-assigned this Sep 29, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2022
@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2023
@thockin
Copy link
Member

thockin commented Feb 2, 2023

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2023
@alexanderConstantinescu
Copy link
Member Author

/retitle Remove transient node predicates from KCCM's service controller

@k8s-ci-robot k8s-ci-robot changed the title Dynamically re-configure LB node set Remove transient node predicates from KCCM's service controller Feb 3, 2023
@marosset
Copy link
Contributor

marosset commented Feb 3, 2023

@thockin @alexanderConstantinescu can one of you confirm that this targeting beta for v1.27.
Thanks!

@alexanderConstantinescu
Copy link
Member Author

Yes, that is correct and what we've discussed / agreed on the KEP. Maybe @thockin wants to give the final confirmation?

@thockin
Copy link
Member

thockin commented Feb 3, 2023

yes please - this one doesn't have APi so doesn't need an alpha

@marosset
Copy link
Contributor

marosset commented Feb 7, 2023

Thanks @thockin @alexanderConstantinescu

@marosset
Copy link
Contributor

marosset commented Feb 7, 2023

Once #3835 merges this enhancement will be ready for inclusion in v1.27

@shatoboar
Copy link

With #3835 merged this enhancement is ready to be tracked for 1.27.
Thanks!

@shatoboar shatoboar added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 12, 2023
@shatoboar
Copy link

shatoboar commented Mar 12, 2023

Hi @thockin 👋,
Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.
Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Please let me know what PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

@thockin thockin moved this from Pre-Alpha (we want to do this but the KEP or code is not merged yet) to Beta gated (merged) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Mar 16, 2023
@marosset marosset added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Mar 20, 2023
@alexanderConstantinescu
Copy link
Member Author

1.30 is next - did you mean 31?

I meant 1.30. My understanding is: if we want to "soak for one more release" then we extend the current milestone by one release. This feature was marked stable: 1.29, but I forgot to update the feature gate in Kube for this feature in 1.29, so it's still in beta. Extending beta by one release therefore means we go to stable in 1.30...does this makes sense?

@aojea : did you mean that we should go to stable in 1.31?

@thockin
Copy link
Member

thockin commented Jan 24, 2024

For context: It's been beta for 1.27, 1.28, 1.29 - majhor providers are all using those versions now.

I'm OK if we want to let it ride one more, but I am not sure it's buying us anything

@alexanderConstantinescu
Copy link
Member Author

I'm OK if we want to let it ride one more, but I am not sure it's buying us anything

+1

I'll let Antonio decide, following how strongly he feels about it

@aojea
Copy link
Member

aojea commented Jan 24, 2024

For context: It's been beta for 1.27, 1.28, 1.29 - majhor providers are all using those versions now.

I'm OK if we want to let it ride one more, but I am not sure it's buying us anything

not really, major providers have to revendor and use to take some time to pick up these changes, all cloud provider code moved to external cloud providers, and it was beta but we had a fix in 1.29 with backports kubernetes/kubernetes@2032b74

@aojea
Copy link
Member

aojea commented Jan 24, 2024

although, we are going to remove the cloud providers tests this release (most probably), so it will be useless to get it another release more, @alexanderConstantinescu go ahead and GA this then

@thockin
Copy link
Member

thockin commented Jan 24, 2024

Also, from the original bug:

"""
This PR should have no effect on >= 1.27 since the predicates are already aligned under the feature gate StableLoadBalancerNodeSet, but this should get in so that we guard against the broken behaviour should someone turn that feature gate off.
"""

It was about a regression on 1.26 or when the gate was disabled.

@aojea
Copy link
Member

aojea commented Jan 25, 2024

It was about a regression on 1.26 or when the gate was disabled.

oh, my fault, sorry, I skipped that super important detail 😓

@salehsedghpour
Copy link
Contributor

Hello @alexanderConstantinescu and @thockin 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Make sure that the KEP has the production readiness review. (For more information on the PRR process, check here).

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@alexanderConstantinescu
Copy link
Member Author

@salehsedghpour : I made a mistake in the last release and got a prr-review for Stable, but forgot to update the code afterwards. In this release we're only updating the code and the prr-review file already exists, see: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-network/3458.yaml

Is this fine?

@salehsedghpour
Copy link
Contributor

Yes, thanks for the clarification. With this information, this enhancements is now tracked for enhancement freeze.

@chanieljdan
Copy link

Hi @alexanderConstantinescu and @thockin 👋, 1.30 Docs Shadow here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@a-mccarthy
Copy link

Hi @thockin,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@salehsedghpour
Copy link
Contributor

salehsedghpour commented Feb 22, 2024

Hey again @alexanderConstantinescu and @thockin 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, I couldn't find any (open) PRs in k/k. With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@alexanderConstantinescu
Copy link
Member Author

@salehsedghpour : this is the only PR which was needed for this release: kubernetes/kubernetes#122961 - the implementation was done a while ago. This PR just promotes the feature to stable

@salehsedghpour
Copy link
Contributor

@alexanderConstantinescu thanks for clarification. As kubernetes/kubernetes#122961 is already merged, this can now be marked as tracked for code freeze.

May you please also make sure that this PR is added to issue description as well?

@salehsedghpour
Copy link
Contributor

@alexanderConstantinescu, Enhancements team here!
As this enhancement is targeting stable for this release, may you please update the status field in the kep.yaml file to implemented after code PRs are merged and the feature gates are removed.

@alexanderConstantinescu
Copy link
Member Author

Hi @salehsedghpour : just to confirm: this feature is going GA in 1.30, so we will remove the feature gate in 1.31. Should I mark it implemented in 1.31 or 1.30 ?

@salehsedghpour
Copy link
Contributor

Thanks @alexanderConstantinescu, with this please consider marking it as implemented in 1.31.

@alexanderConstantinescu
Copy link
Member Author

Thanks @alexanderConstantinescu, with this please consider marking it as implemented in 1.31.

Will do!

@danwinship
Copy link
Contributor

@alexanderConstantinescu can you update the checklist in the initial comment with the current state? (Like, it currently shows that alpha is incomplete, but my understanding from reading the comments here is that it's actually GA.)

@alexanderConstantinescu
Copy link
Member Author

I've updated the description to this PR, should be up-to-date now.

@thockin thockin modified the milestones: v1.30, v1.32 May 8, 2024
@thockin
Copy link
Member

thockin commented May 8, 2024

GA'ed in 30, Cleanup in 32

@sreeram-venkitesh
Copy link
Member

Hi! v1.31 Enhancements lead here 👋🏼

I'm assuming the status will be updated to implemented in v1.32 along with the cleanup, right? I'll remove the lead-opted-in label and remove this KEP from the v1.31 tracking board. Please let me know if this works.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label May 15, 2024
@alexanderConstantinescu
Copy link
Member Author

alexanderConstantinescu commented May 23, 2024

GA'ed in 30, Cleanup in 32

@thockin : isn't it cleanup in 31? Ref: https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L1144 - might be that the comment is wrong and that we need to let it soak for 2 releases in stable?

@thockin
Copy link
Member

thockin commented May 24, 2024

Unless I am losing my mind, cleanup is GA+2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: Tracked
Status: Tracked for Code Freeze
Status: Tracked for Doc Freeze
Status: 04 GA
Development

No branches or pull requests