Kubernetes Component Health SLIs

[logicalhan]

Enhancement Description

• Exposing healthchecks in metric format
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3466-kubernetes-component-health-slis
• Discussion Link:
• Primary contact (assignee): logicalhan
• Responsible SIGs: sig-instrumentation
• Enhancement target (which target equals to which milestone):
  • Alpha release target (1.26):
  • Beta release target (1.27):
  • Stable release target (1.29):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP:3466: Kubernetes Component Health SLIs #3469
  • Code (k/k) update PR(s):
    • add metrics for health checks (for later use in apiserver) kubernetes#111771
    • enable health check SLI metrics for apiserver kubernetes#112741
    • use generic slis as entrypoint for healthcheck metrics  kubernetes#112740
    • add 'metrics/slis' to kcm health checks kubernetes#112978
    • add metrics/slis to kube-scheduler health checks kubernetes#113026
    • add metrics/slis to kubelet health checks kubernetes#113030
    • add metrics/slis to cloud-controller-manager health checks kubernetes#113340
  • Docs (k/website) update PR(s):
    • Add documentation for Component SLIs feature website#37767
• Beta
  • KEP 3753
  • Code (k/k) update PR(s):
    • Enable ComponentSLI as beta feature kubernetes#114997
  • Docs (k/website) update(s):
    • Update documentation on SLI metrics website#40064
• Stable
  • KEP (k/enhancements) update PR(s):
    • bump component slis to stable #4201
    • update kep.yaml with correct values #4241
  • Code (k/k) update PR(s):
    • promote component SLIs to GA; remove feature gates for component slis kubernetes#120574
  • Docs (k/website) update(s):
    • update documentation for component-slis website#43562

[Kanika637]

Hey @logicalhan, can you give some more context on this issue?
I might can work on this

[logicalhan]

/sig instrumentation

[dashpole]

/assign @logicalhan

[rhockenbury]

/milestone 1.26

[k8s-ci-robot]

@rhockenbury: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rhockenbury]

/milestone v1.26

[logicalhan]

/assign @wojtek-t

[ruheenaansari34]

👋 Hello @logicalhan , 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.
This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a updated detailed test plan section filled out
• KEP has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we need to update the PR #3469 to meet the requirements for enhancement freeze, and then get it merged.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[logicalhan]

Looks like for this one, we need to update the PR #3469 to meet the requirements for enhancement freeze, and then get it merged.

@ruheenaansari34 I've updated the KEP using the template. Would you mind re-assessing it?

[ruheenaansari34]

@logicalhan Thank you. I've re-assessed it and looks like we still need KEP owner's acknowledgement in the Test plan section of KEP's README.
Specifically, this statement:

[ ] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

[logicalhan]

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

Would you mind reviewing this: #3564?

[logicalhan]

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

Done.

[ruheenaansari34]

Excellent. Here’s where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.26
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria.
• KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[jberkus]

Please update this issue with the actual location of the KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3466-kubernetes-component-health-slis

[logicalhan]

Please update this issue with the actual location of the KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3466-kubernetes-component-health-slis

Sure done.

[rhockenbury]

Hi @logicalhan 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

Let me know if there's any PRs that aren't mentioned in the issue description that we should be tracking.

As always, we are here to help should questions come up. Thanks!

[npolshakova]

Hi @logicalhan,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.
  • Enable ComponentSLI as beta feature kubernetes#114997

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

[logicalhan]

/stage beta

[mickeyboxell]

Hi @logicalhan 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by tomorrow, March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

[mickeyboxell]

Hi @logicalhan please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This placeholder PR must be created by today, March 16, and should be ready for review on Tuesday, March 21.

[logicalhan]

Hi @logicalhan please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This placeholder PR must be created by today, March 16, and should be ready for review on Tuesday, March 21.

kubernetes/website#40064

[logicalhan]

/stage stable

[npolshakova]

Hello @logicalhan 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• Update the latest-milestone to 1.29 in the kep.yaml

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[logicalhan]

Hello @logicalhan 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• Update the latest-milestone to 1.29 in the kep.yaml

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Done

[npolshakova]

Thanks! With https://github.com/kubernetes/enhancements/pull/4241/files merged in, this KEP is now tracked for enhancement freeze! 🚀

[Princesso]

Hey there @logicalhan ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

[Princesso]

Hi @logicalhan, the deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of the docs for this enhancement? Thank you!

[logicalhan]

Hi @logicalhan, the deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of the docs for this enhancement? Thank you!

kubernetes/website#43562

[kcmartin]

Hi @logicalhan! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

[npolshakova]

Hey again @logicalhan 👋 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs has merged and update in the Issue description:

• promote component SLIs to GA; remove feature gates for component slis kubernetes#120574

With this pr merged and the status updated to implemented, the status of this KEP is tracked for code freeze. 🚀

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[salehsedghpour]

Hi, 👋 v1.30 Enhancements lead here
As it has graduated to Stable and the KEP status is updated to implemented, so it seems that is completed and we can close it. Shall we?

[salehsedghpour]

/remove-label lead-opted-in

[salehsedghpour]

This issue can be closed as it is completed.