Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Component Health SLIs #3466

Open
12 tasks done
logicalhan opened this issue Aug 16, 2022 · 18 comments
Open
12 tasks done

Kubernetes Component Health SLIs #3466

logicalhan opened this issue Aug 16, 2022 · 18 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@logicalhan
Copy link
Contributor

logicalhan commented Aug 16, 2022

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 16, 2022
@Kanika637
Copy link

Kanika637 commented Aug 24, 2022

Hey @logicalhan, can you give some more context on this issue?
I might can work on this

@logicalhan logicalhan added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 7, 2022
@logicalhan
Copy link
Contributor Author

logicalhan commented Sep 7, 2022

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 7, 2022
@dashpole
Copy link
Contributor

dashpole commented Sep 8, 2022

/assign @logicalhan

@dashpole dashpole added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 8, 2022
@rhockenbury
Copy link

rhockenbury commented Sep 11, 2022

/milestone 1.26

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 11, 2022

@rhockenbury: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhockenbury
Copy link

rhockenbury commented Sep 11, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 11, 2022
@logicalhan
Copy link
Contributor Author

logicalhan commented Sep 14, 2022

/assign @wojtek-t

@logicalhan logicalhan changed the title Kubernetes Healthchecks in Metric Format Kubernetes Component Health SLIs Sep 16, 2022
@ruheenaansari34
Copy link

ruheenaansari34 commented Sep 16, 2022

👋 Hello @logicalhan , 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.
This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has a updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we need to update the PR #3469 to meet the requirements for enhancement freeze, and then get it merged.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rhockenbury rhockenbury added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 18, 2022
@wojtek-t wojtek-t assigned logicalhan and unassigned logicalhan and wojtek-t Sep 21, 2022
@logicalhan
Copy link
Contributor Author

logicalhan commented Sep 21, 2022

Looks like for this one, we need to update the PR #3469 to meet the requirements for enhancement freeze, and then get it merged.

@ruheenaansari34 I've updated the KEP using the template. Would you mind re-assessing it?

@ruheenaansari34
Copy link

ruheenaansari34 commented Sep 27, 2022

@logicalhan Thank you. I've re-assessed it and looks like we still need KEP owner's acknowledgement in the Test plan section of KEP's README.
Specifically, this statement:

[ ] I/we understand the owners of the involved components may require updates to existing tests to make this code solid enough prior to committing the changes necessary to implement this enhancement.

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

@logicalhan
Copy link
Contributor Author

logicalhan commented Sep 28, 2022

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

Would you mind reviewing this: #3564?

@logicalhan
Copy link
Contributor Author

logicalhan commented Sep 28, 2022

Once the PR is merged with the above change, the enhancements freeze requirements will be fulfilled.

Done.

@ruheenaansari34
Copy link

ruheenaansari34 commented Sep 29, 2022

Excellent. Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria.
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@jberkus
Copy link
Contributor

jberkus commented Oct 18, 2022

Please update this issue with the actual location of the KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3466-kubernetes-component-health-slis

@logicalhan
Copy link
Contributor Author

logicalhan commented Oct 18, 2022

Please update this issue with the actual location of the KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3466-kubernetes-component-health-slis

Sure done.

@rhockenbury
Copy link

rhockenbury commented Oct 29, 2022

Hi @logicalhan 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Let me know if there's any PRs that aren't mentioned in the issue description that we should be tracking.

As always, we are here to help should questions come up. Thanks!

@krol3
Copy link

krol3 commented Nov 7, 2022

Hello @logicalhan 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@logicalhan
Copy link
Contributor Author

logicalhan commented Nov 8, 2022

Hello @logicalhan 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Done and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Net New
Development

No branches or pull requests

9 participants