Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEL for Admission Control #3488

Open
2 of 4 tasks
jpbetz opened this issue Sep 1, 2022 · 18 comments
Open
2 of 4 tasks

CEL for Admission Control #3488

jpbetz opened this issue Sep 1, 2022 · 18 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Sep 1, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 1, 2022
@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 1, 2022

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 1, 2022
@jpbetz jpbetz changed the title CEL for Admission Extensibility CEL for Admission Control Sep 2, 2022
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 16, 2022

@jpbetz please provide a Discussion Link. It is required that you "link to SIG mailing list thread, meeting, or recording where the Enhancement was discussed before KEP creation" :)

@logicalhan
Copy link
Contributor

logicalhan commented Oct 3, 2022

/lead-opted-in

@logicalhan
Copy link
Contributor

logicalhan commented Oct 3, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 3, 2022
@logicalhan
Copy link
Contributor

logicalhan commented Oct 3, 2022

/lead-opted-in

@logicalhan
Copy link
Contributor

logicalhan commented Oct 3, 2022

/sig api-machinery

@logicalhan logicalhan added lead-opted-in Denotes that an issue has been opted in to a release stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Oct 3, 2022
@rhockenbury
Copy link

rhockenbury commented Oct 3, 2022

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 3, 2022
@parul5sahoo
Copy link
Member

parul5sahoo commented Oct 4, 2022

Hello @jpbetz 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following before enhancements freeze which is approaching soon:

  • update the status of the KEP in the kep.yaml to implemetable.
  • check the agreement in the test plan section and add graduation criteria for alpha phase(if need being).
  • Complete and merge the PRR for the kep

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 5, 2022

#3554 contains PRR, test, graduation and implementable, we are aiming to merge it today

@cici37
Copy link
Contributor

cici37 commented Oct 5, 2022

@parul5sahoo Thanks for reaching out! We have everything merged. The KEP can be tracked now. Please let us know of anything is missing :)

@parul5sahoo
Copy link
Member

parul5sahoo commented Oct 6, 2022

Hello @cici37 , although I see that the release sign off checklist and the test agreement have been included but they are all unchecked. so could you please check the items that meet the criteria in the release check list and also the check the test agreement. And since these are minor details I am marking the KEP as tracked.

@cici37
Copy link
Contributor

cici37 commented Oct 6, 2022

Hello @cici37 , although I see that the release sign off checklist and the test agreement have been included but they are all unchecked. so could you please check the items that meet the criteria in the release check list and also the check the test agreement. And since these are minor details I am marking the KEP as tracked.

#3592 to address this. Thanks for marking this tracked!

@cici37
Copy link
Contributor

cici37 commented Oct 12, 2022

/assign

@katmutua
Copy link

katmutua commented Nov 1, 2022

Hello @jpbetz ! 👋🏾,

@katmutua 1.26 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.
As a reminder, please link all of your docs PR to this issue so we can easily track it.

@ruheenaansari34
Copy link

ruheenaansari34 commented Nov 2, 2022

Hi @jpbetz 👋,

Checking in once more as we approach the 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before the code freeze. If you do have any other k/k PRs open, please link them to this issue :

As always, we are here to help should questions come up. Thanks!

@jpbetz
Copy link
Contributor Author

jpbetz commented Nov 2, 2022

All PRs are now linked and we are working on code review and approvals. We will open a docs PR shortly.

@cici37
Copy link
Contributor

cici37 commented Nov 7, 2022

I have opened the doc place holder PR. Thanks

@jpbetz
Copy link
Contributor Author

jpbetz commented Nov 8, 2022

All alpha feature code has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Net New
Development

No branches or pull requests

9 participants