Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEL for Admission Control #3488

Open
8 of 12 tasks
jpbetz opened this issue Sep 1, 2022 · 64 comments
Open
8 of 12 tasks

CEL for Admission Control #3488

jpbetz opened this issue Sep 1, 2022 · 64 comments
Assignees
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Sep 1, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 1, 2022
@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 1, 2022

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 1, 2022
@jpbetz jpbetz changed the title CEL for Admission Extensibility CEL for Admission Control Sep 2, 2022
@kikisdeliveryservice
Copy link
Member

@jpbetz please provide a Discussion Link. It is required that you "link to SIG mailing list thread, meeting, or recording where the Enhancement was discussed before KEP creation" :)

@logicalhan
Copy link
Contributor

/lead-opted-in

@logicalhan
Copy link
Contributor

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 3, 2022
@logicalhan
Copy link
Contributor

/lead-opted-in

@logicalhan
Copy link
Contributor

/sig api-machinery

@logicalhan logicalhan added lead-opted-in Denotes that an issue has been opted in to a release stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Oct 3, 2022
@rhockenbury
Copy link

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 3, 2022
@parul5sahoo
Copy link
Member

Hello @jpbetz 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following before enhancements freeze which is approaching soon:

  • update the status of the KEP in the kep.yaml to implemetable.
  • check the agreement in the test plan section and add graduation criteria for alpha phase(if need being).
  • Complete and merge the PRR for the kep

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 5, 2022

#3554 contains PRR, test, graduation and implementable, we are aiming to merge it today

@cici37
Copy link
Contributor

cici37 commented Oct 5, 2022

@parul5sahoo Thanks for reaching out! We have everything merged. The KEP can be tracked now. Please let us know of anything is missing :)

@parul5sahoo
Copy link
Member

parul5sahoo commented Oct 6, 2022

Hello @cici37 , although I see that the release sign off checklist and the test agreement have been included but they are all unchecked. so could you please check the items that meet the criteria in the release check list and also the check the test agreement. And since these are minor details I am marking the KEP as tracked.

@cici37
Copy link
Contributor

cici37 commented Oct 6, 2022

Hello @cici37 , although I see that the release sign off checklist and the test agreement have been included but they are all unchecked. so could you please check the items that meet the criteria in the release check list and also the check the test agreement. And since these are minor details I am marking the KEP as tracked.

#3592 to address this. Thanks for marking this tracked!

@cici37
Copy link
Contributor

cici37 commented Oct 12, 2022

/assign

@cici37
Copy link
Contributor

cici37 commented May 31, 2023

Hello @jpbetz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Thursday, 8th June 2023.

Looks like this enhancement is targeting for stage beta for v1.28

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone:v1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would simply need to update the following:

  • Get approval from the PRR authors.
  • Get the KEP PR merged before enhancements freeze.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

@Atharva-Shinde Thanks for the updates! I am working on merging the KEP updates and get PRR review before the deadline!

@cici37
Copy link
Contributor

cici37 commented Jun 15, 2023

Hi @Atharva-Shinde , the KEP update for this one has been merged and we should be on track now. Thank you!

@Atharva-Shinde
Copy link
Contributor

Hey @cici37
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

@Rishit-dagli
Copy link
Member

Hello @jpbetz @cici37 👋, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@Rishit-dagli
Copy link
Member

Hey @jpbetz , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

@Atharva-Shinde
Copy link
Contributor

Hey again @cici37 @jpbetz 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

@cici37
Copy link
Contributor

cici37 commented Jul 17, 2023

Hi @Atharva-Shinde here is the placeholder doc PR: kubernetes/website#42042 Thank you!

@Atharva-Shinde
Copy link
Contributor

Hey @cici37 does this enhancement have any code related pull requests open in kubernetes/kubernetes repository?

@cici37
Copy link
Contributor

cici37 commented Jul 17, 2023

Hey @cici37 does this enhancement have any code related pull requests open in kubernetes/kubernetes repository?

I have updated in issue description. Thank you!

@Atharva-Shinde
Copy link
Contributor

Hello @cici37 @jpbetz 👋, 1.28 Enhancements Lead here.

Unfortunately, the implementation (code related) PRs associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.28 milestone.
kubernetes/kubernetes#119215
kubernetes/kubernetes#119109
kubernetes/kubernetes#118819
kubernetes/kubernetes#118644

If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.28 milestone Jul 19, 2023
@Atharva-Shinde
Copy link
Contributor

Thanks for filling an exception request! I'll reapply the v1.28 milestone if the exception request is approved.

@Rishit-dagli
Copy link
Member

Hello @cici37 @jpbetz 👋 please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: kubernetes/website#42042

@Rishit-dagli
Copy link
Member

Rishit-dagli commented Jul 23, 2023

@Atharva-Shinde was this exception request approved?

@cici37
Copy link
Contributor

cici37 commented Jul 24, 2023

@Rishit-dagli Yes, this exception has been approved and we are on track for 1.28.

@cici37
Copy link
Contributor

cici37 commented Jul 25, 2023

Update: All code was merged before the 1.28 exception deadline. Thank you so much for the support! cc @Atharva-Shinde @Rishit-dagli

@Atharva-Shinde
Copy link
Contributor

Hey again @cici37 👋
As all the code related PRs of this KEP were merged by the additional time approved in the exception request, I am adding this KEP back to v1.28 milestone and changing the status of this enhancement to Tracked :)

/milestone v1.28

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@enj enj removed this from the v1.28 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Net New
Status: Tracked
Status: Tracked
Status: In Progress
Development

No branches or pull requests