Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEL for Admission Control #3488

Open
16 tasks done
jpbetz opened this issue Sep 1, 2022 · 95 comments
Open
16 tasks done

CEL for Admission Control #3488

jpbetz opened this issue Sep 1, 2022 · 95 comments
Assignees
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Sep 1, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 1, 2022
@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 1, 2022

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 1, 2022
@jpbetz jpbetz changed the title CEL for Admission Extensibility CEL for Admission Control Sep 2, 2022
@kikisdeliveryservice
Copy link
Member

@jpbetz please provide a Discussion Link. It is required that you "link to SIG mailing list thread, meeting, or recording where the Enhancement was discussed before KEP creation" :)

@logicalhan
Copy link
Member

/lead-opted-in

@logicalhan
Copy link
Member

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 3, 2022
@logicalhan
Copy link
Member

/lead-opted-in

@logicalhan
Copy link
Member

/sig api-machinery

@logicalhan logicalhan added lead-opted-in Denotes that an issue has been opted in to a release stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Oct 3, 2022
@rhockenbury
Copy link

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 3, 2022
@parul5sahoo
Copy link

Hello @jpbetz 👋, 1.26 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.26
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following before enhancements freeze which is approaching soon:

  • update the status of the KEP in the kep.yaml to implemetable.
  • check the agreement in the test plan section and add graduation criteria for alpha phase(if need being).
  • Complete and merge the PRR for the kep

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 5, 2022

#3554 contains PRR, test, graduation and implementable, we are aiming to merge it today

@cici37
Copy link
Contributor

cici37 commented Oct 5, 2022

@parul5sahoo Thanks for reaching out! We have everything merged. The KEP can be tracked now. Please let us know of anything is missing :)

@parul5sahoo
Copy link

parul5sahoo commented Oct 6, 2022

Hello @cici37 , although I see that the release sign off checklist and the test agreement have been included but they are all unchecked. so could you please check the items that meet the criteria in the release check list and also the check the test agreement. And since these are minor details I am marking the KEP as tracked.

@cici37
Copy link
Contributor

cici37 commented Oct 6, 2022

Hello @cici37 , although I see that the release sign off checklist and the test agreement have been included but they are all unchecked. so could you please check the items that meet the criteria in the release check list and also the check the test agreement. And since these are minor details I am marking the KEP as tracked.

#3592 to address this. Thanks for marking this tracked!

@cici37
Copy link
Contributor

cici37 commented Oct 12, 2022

/assign

@rayandas
Copy link
Member

rayandas commented Oct 5, 2023

As #4272 is now merged, marking this as Tracked for Enhancements Freeze. 🚀 Thanks.

@taniaduggal
Copy link

Hey there @jpbetz ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 11, 2023

^ @cici37

@cici37
Copy link
Contributor

cici37 commented Oct 11, 2023

We might not need a doc PR for this release. We'll raise one later if the doc update is needed.

@rayandas
Copy link
Member

Hey again @jpbetz 👋, 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs of this KEP under the beta section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@a-mccarthy
Copy link

Hi @jpbetz, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 30, 2023

Hi @jpbetz , 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

Not for this release. We're letting this feature settle in as a Beta feature with only relatively minor improvements.

@cici37 please feel free to disagree if you'd like to publish anything.

@npolshakova
Copy link

Hey again @cici37 @jpbetz 👋, 1.29 Enhancements team here! Are there any code PRs going into 1.29 we should track as part of this KEP? Or could you confirm that there are no net new code changes in 1.29?

@npolshakova
Copy link

Confirmed that 1.29 code changes had mainly bug fixes, marking this as tracked for code freeze 🚀

@liggitt
Copy link
Member

liggitt commented Jan 3, 2024

Is this targeting stable in 1.30?

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@cici37
Copy link
Contributor

cici37 commented Jan 23, 2024

Yes we plan to promote this to GA in 1.30.

/milestone v1.30

@jpbetz Could you please tag the leader opt in label here? Thanks!

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 23, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Jan 23, 2024

/lead opt-in

@jpbetz
Copy link
Contributor Author

jpbetz commented Jan 23, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 23, 2024
@sreeram-venkitesh
Copy link
Member

Hello @cici37, @jpbetz 👋, v1.30 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as tracked for enhancement freeze 🎉 Thank you!

@Princesso
Copy link

Hello @jpbetz , 👋 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against the dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@kcmartin
Copy link

Hi @jpbetz, @cici37,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@fkautz
Copy link
Member

fkautz commented Feb 26, 2024

Hi @jpbetz, @cici37

👋 from the v1.30 Communications Team!

We are currently working on the midcycle blog. We are looking for a paragraph or two about significant enhancements. Are you interested in participating?

Here's the link for general access (commenter permissions). We can extend editor permissions if you choose to author an entry in this blog post.

Also, please get in touch with us if there are other changes you believe could impact users that we should highlight. We can be reached at #release-comms in the Kubernetes Slack.

Cheers,
Frederick

@sreeram-venkitesh
Copy link
Member

Hey again @jpbetz, @cici37 👋 v1.30 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the issue description to include all the related PRs of this KEP):

Currently, I'm marking this KEP as At Risk for Code Freeze. Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

@sreeram-venkitesh
Copy link
Member

@cici37, @jpbetz Please let me know if kubernetes/kubernetes#123405 is the only code PR that needs to be merged for this KEP. Pinging again since code freeze is tomorrow.

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 5, 2024

Please let me know if kubernetes/kubernetes#123405 is the only code PR that needs to be merged for this KEP. Pinging again since code freeze is tomorrow.

We're also merging kubernetes/kubernetes#123543. It's in the merge queue now. I've added it to the description for tracking. kubernetes/kubernetes#123405 is ready and will be merged after.

@sreeram-venkitesh
Copy link
Member

Thank you @jpbetz, @cici37!

With all the implementation (code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the 1.30 Code Freeze!

@sreeram-venkitesh
Copy link
Member

Hi @jpbetz 👋, 1.31 Enhancements Lead here.

Since this KEP has graduated to GA in 1.30, please update the status here in the kep.yaml to implemented so that we can close this issue.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Net New
Status: Tracked
Status: Tracked
Status: Tracked for Code Freeze
Status: Tracked for Doc Freeze
Status: In Progress
Development

No branches or pull requests