Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod Scheduling Readiness #3521

Open
8 of 9 tasks
Huang-Wei opened this issue Sep 16, 2022 · 28 comments
Open
8 of 9 tasks

Pod Scheduling Readiness #3521

Huang-Wei opened this issue Sep 16, 2022 · 28 comments
Assignees
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@Huang-Wei
Copy link
Member

Huang-Wei commented Sep 16, 2022

Enhancement Description

Alpha

  1. approved cncf-cla: yes kind/kep lgtm sig/scheduling size/XXL tide/merge-method-squash
    ahg-g wojtek-t
  2. api-review approved area/code-generation area/e2e-test-framework area/test cncf-cla: yes kind/api-change kind/feature lgtm needs-priority release-note sig/apps sig/scheduling sig/testing size/XL triage/accepted
    ahg-g smarterclayton
  3. api-review approved area/code-generation area/e2e-test-framework area/stable-metrics area/test cncf-cla: yes kind/api-change kind/feature lgtm needs-priority release-note sig/api-machinery sig/apps sig/instrumentation sig/scheduling sig/testing size/XL triage/accepted
    ahg-g liggitt
    logicalhan
  4. approved area/code-generation area/e2e-test-framework area/stable-metrics area/test cncf-cla: yes kind/api-change kind/feature lgtm needs-priority release-note-none sig/api-machinery sig/apps sig/instrumentation sig/scheduling sig/testing size/L triage/accepted
    ahg-g aojea
    logicalhan
  5. approved cncf-cla: yes kind/bug lgtm needs-priority needs-triage release-note-none sig/scheduling size/L
    ahg-g
  6. approved cncf-cla: yes language/en lgtm sig/docs sig/scheduling size/L
    krol3

Beta

  1. approved cncf-cla: yes kind/kep lgtm sig/scheduling size/L
    ahg-g wojtek-t
  2. 9 of 10
    lifecycle/stale needs-triage sig/scheduling
    lianghao208
  3. approved cncf-cla: yes language/en lgtm sig/docs size/XS
    tengqm

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 16, 2022
@Huang-Wei
Copy link
Member Author

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 16, 2022
@ahg-g
Copy link
Member

ahg-g commented Sep 19, 2022

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 19, 2022
@ahg-g
Copy link
Member

ahg-g commented Sep 19, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 19, 2022
@rhockenbury rhockenbury added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Sep 20, 2022
@Atharva-Shinde
Copy link
Contributor

Hey @kerthcet 👋, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to:

  • Change the status of kep.yaml to implementable (I've also added a comment review)
  • Include the new updated PR of this KEP in the Issue Description and get it merged before Enhancements Freeze to make this enhancement eligible for 1.26 release.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you :)

@Huang-Wei
Copy link
Member Author

Thanks @Atharva-Shinde.

@Atharva-Shinde
Copy link
Contributor

Hello @Huang-Wei 👋, just a quick check-in again, as we approach the 1.26 Enhancements freeze.

Please plan to get the PR #3522 merged before Enhancements freeze on 18:00 PDT on Thursday 6th October 2022 i.e tomorrow

For note, the current status of the enhancement is marked at-risk :)

@Huang-Wei
Copy link
Member Author

Thanks for the reminder. It's 99% accomplished atm, just some final comments waiting for the approver to +1.

@Huang-Wei Huang-Wei changed the title Pod Schedule Readiness Pod Scheduling Readiness Oct 6, 2022
@rhockenbury
Copy link

With #3522 merged, we have this marked as tracked for v1.26.

@marosset
Copy link
Contributor

Hi @Huang-Wei 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Please ensure all of these PRs are linked to this issue as well and mentioned in the initial issue description.

As always, we are here to help should questions come up. Thanks!

@Huang-Wei
Copy link
Member Author

@marosset yes, those 3 PRs are code implementation for this KEP in alpha stage. I just updated the issue description to get them linked.

@krol3
Copy link

krol3 commented Nov 7, 2022

Hello @Huang-Wei 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@marosset
Copy link
Contributor

marosset commented Nov 7, 2022

Hi @Huang-Wei 👋,

Checking in once more as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

As always, we are here to help should questions come up. Thanks!

@Huang-Wei
Copy link
Member Author

@marosset ACK, I'm working with reviewers to get 2 pending PRs merged by tomorrow.

@Huang-Wei
Copy link
Member Author

I'm working with reviewers to get 2 pending PRs merged by tomorrow.

All dev work has been merged.

@marosset
Copy link
Contributor

/remove-label lead-opted-in
/remove-label tracked/yes
/label tracked/no
/milestone clear

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Dec 14, 2022
@k8s-ci-robot k8s-ci-robot removed lead-opted-in Denotes that an issue has been opted in to a release tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Dec 14, 2022
@alculquicondor
Copy link
Member

Not sure if I should post this here or #2926, but it would be nice if scheduling gates are mutable in the job template.

@ahg-g
Copy link
Member

ahg-g commented Jan 9, 2023

Not sure if I should post this here or #2926, but it would be nice if scheduling gates are mutable in the job template.

Part of the KEP update for mutable scheduling directives already: #3709

@Huang-Wei
Copy link
Member Author

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 9, 2023
@sftim
Copy link
Contributor

sftim commented Jan 18, 2023

If we graduate this to beta, we'll need to update https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/ and maybe other Pod pages, to mention / link to the details about it.

@ahg-g
Copy link
Member

ahg-g commented Jan 23, 2023

/stage beta
/milestone v1.27
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jan 23, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 23, 2023
@npolshakova
Copy link

npolshakova commented Feb 2, 2023

Hello @Huang-Wei 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage beta for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like #3739 will address these issues.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@npolshakova
Copy link

Looks like with #3739 merged this enhancement as tracked for v1.27.
Thanks!

/remove-label tracked/no
/label tracked/yes

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 9, 2023
@npolshakova
Copy link

npolshakova commented Mar 9, 2023

Hi @Huang-Wei,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.
As always, we are here to help should questions come up. Thanks!

@Huang-Wei
Copy link
Member Author

@npolshakova I will have my eye on kubernetes/kubernetes#116201 to ensure it's completed before code freeze.

@pacoxu
Copy link
Member

pacoxu commented May 8, 2023

https://kubernetes.io/docs/concepts/workloads/pods/#pod-update-and-replacement
a document update here may be needed for spec.schedulingGates that is updatable.

@Atharva-Shinde Atharva-Shinde removed this from the v1.27 milestone May 14, 2023
@Atharva-Shinde Atharva-Shinde removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team lead-opted-in Denotes that an issue has been opted in to a release labels May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Net New
Status: Tracked
Development

No branches or pull requests