Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved multi-numa alignment in Topology Manager #3545

Open
8 tasks done
klueska opened this issue Sep 23, 2022 · 48 comments
Open
8 tasks done

Improved multi-numa alignment in Topology Manager #3545

klueska opened this issue Sep 23, 2022 · 48 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@klueska
Copy link
Contributor

klueska commented Sep 23, 2022

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Sep 23, 2022
@klueska klueska changed the title Improved multi-numa alignment in Topology Manage Improved multi-numa alignment in Topology Manager Sep 23, 2022
@klueska
Copy link
Contributor Author

klueska commented Sep 26, 2022

/cc @fromanirh
/cc @swatisehgal

@ffromani
Copy link
Contributor

thanks for the heads up, I'll review shortly

@derekwaynecarr
Copy link
Member

/label lead-opted-in

@derekwaynecarr derekwaynecarr added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 27, 2022
@Atharva-Shinde
Copy link
Contributor

Hey @klueska 👋, 1.26 Enhancements team here!

Just checking in as we approach Enhancements Freeze on 18:00 PDT on Thursday 6th October 2022.

This enhancement is targeting for stage alpha for 1.26

Here's where this enhancement currently stands:

  • KEP file using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable
  • KEP has an updated detailed test plan section filled out
  • KEP has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to:
-Get the PR #3549 merged before Enhancements Freeze to make this enhancement eligible for 1.26 release.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you :)

@Atharva-Shinde
Copy link
Contributor

/milestone v1.26
/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 28, 2022
@k8s-ci-robot
Copy link
Contributor

@Atharva-Shinde: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.26
/label tracked/yes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Atharva-Shinde
Copy link
Contributor

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 28, 2022
@rhockenbury rhockenbury added this to the v1.26 milestone Sep 29, 2022
@Atharva-Shinde
Copy link
Contributor

Hello @klueska 👋, just a quick check-in again, as we approach the 1.26 Enhancements freeze.

Please plan to get the action items mentioned in my comment above done before Enhancements freeze on 18:00 PDT on Thursday 6th October 2022 i.e tomorrow

For note, the current status of the enhancement is marked at-risk :)

@rhockenbury
Copy link

We have this marked as tracked for v1.26 with #3549 merged.

@Atharva-Shinde
Copy link
Contributor

Hi @klueska 👋,

Checking in as we approach 1.26 code freeze at 17:00 PDT on Tuesday 8th November 2022.

Please ensure the following items are completed:

As always, we are here to help should questions come up.
Thanks :)

@Atharva-Shinde
Copy link
Contributor

Hey @klueska 👋, just a quick check-in again before 1.26 code freeze at 17:00 PDT Tuesday 8th November 2022 i.e tomorrow.
Looks like we would at least need to get the code PR/s: kubernetes/kubernetes#112914 (any more PRs?) merged before the code-freeze :)

@krol3
Copy link

krol3 commented Nov 7, 2022

Hello @klueska 👋, 1.26 Release Docs Lead here. This enhancement is marked as ‘Needs Docs’ for 1.26 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.26 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by November 9. Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Any doubt, reach us! Thank you!

@rhockenbury
Copy link

With kubernetes/kubernetes#112914 merged, we have this marked as tracked for code freeze.

@krol3
Copy link

krol3 commented Nov 11, 2022

Hello @klueska 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before deadline Tuesday 15th November 2022. Thank you!

@krol3
Copy link

krol3 commented Nov 14, 2022

Hi @klueska ! thank you for your doc PR here

@marosset
Copy link
Contributor

/remove-label lead-opted-in
/remove-label tracked/yes
/label tracked/no
/milestone clear

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot removed this from the v1.26 milestone Dec 14, 2022
@k8s-ci-robot k8s-ci-robot removed lead-opted-in Denotes that an issue has been opted in to a release tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Dec 14, 2022
@Atharva-Shinde
Copy link
Contributor

Hey @PiotrProkop @ffromani,
We would just need to update beta stage information inside kep.yaml to 1.28 inside of 1.27 and stable to your expectation. Please make the change within 24 hours else you would have to file an exception request.
Thanks :)

@PiotrProkop
Copy link
Contributor

Hey @PiotrProkop @ffromani, We would just need to update beta stage information inside kep.yaml to 1.28 inside of 1.27 and stable to your expectation. Please make the change within 24 hours else you would have to file an exception request. Thanks :)

Thanks for pointing that out. Here is a PR with the fix.

@klueska
Copy link
Contributor Author

klueska commented Jun 16, 2023

Hi @Atharva-Shinde the PR that @PiotrProkop linked to has now been merged.

@Atharva-Shinde
Copy link
Contributor

Awesome @PiotrProkop @klueska !
With all the KEP requirements in place and merged into k/enhancements the status of this enhancement is now marked as tracked. Please keep the issue description up-to-date with appropriate stages as well.

@katcosgrove
Copy link
Contributor

Hello @PiotrProkop ! 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@PiotrProkop
Copy link
Contributor

Hello @PiotrProkop ! 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hey,

Here is the placeholder PR: kubernetes/website#41718

Thanks for the reminder!

@Atharva-Shinde
Copy link
Contributor

Hey again @PiotrProkop @klueska 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

This is the code related PR/s that I found on this KEP issue

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@ffromani
Copy link
Contributor

@PiotrProkop could you please update by editing the first message #3545 (comment) linking the related PRs?

@PiotrProkop
Copy link
Contributor

Hey again @PiotrProkop @klueska 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

* [ ]  **All** the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.

* [ ]  All code related PR/s are merged or are in merge-ready state ( i.e they have `approved` and `lgtm` labels applied) by the code freeze deadline. This includes any tests related PR/s too.

This is the code related PR/s that I found on this KEP issue

* [topologymanager: Promote support for improved multi-numa alignment in Topology Manager to beta kubernetes#118816](https://github.com/kubernetes/kubernetes/pull/118816)

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@Atharva-Shinde @ffromani I don't have edit access to this issue(asked @klueska to update description). Just FYI the implementation PR was merged:

Documentation PR is opened as WIP I am planning to finish it this week:

@ffromani
Copy link
Contributor

Hey again @PiotrProkop @klueska wave
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .
Here’s the enhancement’s state for the upcoming code freeze:

* [ ]  **All** the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.

* [ ]  All code related PR/s are merged or are in merge-ready state ( i.e they have `approved` and `lgtm` labels applied) by the code freeze deadline. This includes any tests related PR/s too.

This is the code related PR/s that I found on this KEP issue

* [topologymanager: Promote support for improved multi-numa alignment in Topology Manager to beta kubernetes#118816](https://github.com/kubernetes/kubernetes/pull/118816)

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@Atharva-Shinde @ffromani I don't have edit access to this issue(asked @klueska to update description). Just FYI the implementation PR was merged:

* [topologymanager: Promote support for improved multi-numa alignment in Topology Manager to beta kubernetes#118816](https://github.com/kubernetes/kubernetes/pull/118816)

Documentation PR is opened as WIP I am planning to finish it this week:

* [topologymanager: document topology manager policy options promotion to beta  website#41718](https://github.com/kubernetes/website/pull/41718)

Hi @PiotrProkop what we usually do in such cases is to create a comment which include (copy-paste) the original checklist adding your items/the new items for GA

@Atharva-Shinde
Copy link
Contributor

@PiotrProkop I've updated the issue description, let me know if there are other PRs that needs to be linked in there.

@PiotrProkop
Copy link
Contributor

@PiotrProkop I've updated the issue description, let me know if there are other PRs that needs to be linked in there.

@Atharva-Shinde Thanks!

@Atharva-Shinde
Copy link
Contributor

Hey @PiotrProkop @klueska 👋 Enhancements Lead here,
With kubernetes/kubernetes#118816 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@vsoch
Copy link

vsoch commented Dec 19, 2023

hey folks! My team is interested in this KEP - it looks like all the alpha/beta check boxes are purple (merged) and the release contender was 1.28? Was this released with 1.28 and I missed it https://kubernetes.io/blog/2023/08/15/kubernetes-v1-28-release/ or is it still TBA (and possibly not documented) because the issue here is still open? Thanks! And apologies for my naivete about this process.

@PiotrProkop
Copy link
Contributor

@vsoch This is available as alpha option since 1.26 and as beta in 1.28. Check current documentation here: https://kubernetes.io/docs/tasks/administer-cluster/topology-manager/#topology-manager-policy-options

@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.28 milestone Jan 16, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 16, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 16, 2024
@PiotrProkop
Copy link
Contributor

/remove-lifecycle rotten
still discussing how to approach e2e for GA

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Net New
Status: Tracked
Development

No branches or pull requests