Improve kubectl plugin resolution for non-shadowing subcommands

[ardaguclu]

Enhancement Description

• One-line enhancement description (can be used as a release note): Improve kubectl plugin resolution for non-shadowing subcommands
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/3638-kubectl-plugin-subcommands
• Discussion Link: September 21, 2022 sig-cli bi-weekly meeting
• Primary contact (assignee): @ardaguclu
• Responsible SIGs: sig-cli
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.27
  • Beta release target (x.y): 1.29
  • Stable release target (x.y): 1.32
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3638: Enable built-in command shadowing by plugins #3639
  • Code (k/k) update PR(s):
    • Enable plugin resolution as subcommand for selected builtin commands kubernetes#116293
  • Docs (k/website) update PR(s):
    • document plugin resolution as subcommand for builtin commands website#39969
• Beta
  • KEP (k/enhancements) update PR(s):
    • KEP-3638: Promotes plugin subcommand resolution to beta #4209
  • Code (k/k) update PR(s):
    • KEP-3638: Promote plugin resolution to beta kubernetes#120663
  • Docs (k/website) update PR(s):
    • Remove alpha environment variable because feature is in beta website#43048

[ardaguclu]

/milestone v1.27

[k8s-ci-robot]

@ardaguclu: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ardaguclu]

/sig cli

[soltysh]

/assign @ardaguclu

[soltysh]

/milestone v1.27
/label lead-opted-in

[soltysh]

/stage alpha

[Atharva-Shinde]

Hello @ardaguclu 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.27
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Add response for this question in the Scalability questionnaire of the KEP readme

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[ardaguclu]

Thanks @Atharva-Shinde. I added response for the newly added Scalability question. Is there anything further I can do aside from waiting for PRR review?

[Atharva-Shinde]

Hey @ardaguclu, aside from getting PRR approved, everything for this KEP looks good for now :)

[ardaguclu]

Thanks @Atharva-Shinde

[Atharva-Shinde]

@ardaguclu With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[sftim]

Docs PR: kubernetes/website#39800

[LukeMwila]

Hi @ardaguclu, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

[Atharva-Shinde]

Hey again @ardaguclu 👋 Enhancements team here,
Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are fully merged by the code freeze deadline.
  • Enable plugin resolution as subcommand for selected builtin commands kubernetes#116293

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[marckhouzam]

@ardaguclu This is pretty cool! Looking at the KEP, I didn't see any mention of shell completion support. As long as the "sub plugins" are kept under the "create" command, there isn't much need for shell completion support. However, if this is meant to be generalized, it may be useful to support shell completion for such sub-plugins as well.

Here is the section of the plugin KEP describing how shell completion is supported: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/2379-kubectl-plugins#shell-completion-support
And here is the PR that add such support kubernetes/kubernetes#105867

[soltysh]

/stage beta
/milestone v1.29
/label lead-opted-in

[salehsedghpour]

Hello @ardaguclu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.29.
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• Ensure that the PR and PRR is merged to k/enhancements

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[salehsedghpour]

Hi @ardaguclu , checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. It looks like #4209 will address all of the requirements.

Let me know if I missed anything. Thanks!

[salehsedghpour]

As #4209 is merged now, the status of this enhancement can marked as tracked for enhancement freeze.

[Princesso]

Hey there @ardaguclu ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

[Princesso]

Hi @ardaguclu ! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

[Princesso]

Hi @salehsedghpour ! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

[ardaguclu]

Hi @Princesso. For this beta stage, there will be no website changes required.

[Princesso]

Hi @ardaguclu , thanks for responding. How about docs changes?

[ardaguclu]

There won't be any doc changes with respect to this feature in beta

[salehsedghpour]

Hey again @ardaguclu 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

• KEP-3638: Promote plugin resolution to beta kubernetes#120663

With this, the status of this KEP is now at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[a-mccarthy]

Hi @ardaguclu, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

[salehsedghpour]

Hi @ardaguclu ,
As the following PR is now merged the status of this PR can now be marked with tracked for the code freeze.
kubernetes/kubernetes#120663

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP

[salehsedghpour]

/remove-label lead-opted-in

[salehsedghpour]

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[eddiezane]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale