Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve kubectl plugin resolution for non-shadowing subcommands #3638

Open
2 of 4 tasks
ardaguclu opened this issue Oct 24, 2022 · 14 comments
Open
2 of 4 tasks

Improve kubectl plugin resolution for non-shadowing subcommands #3638

ardaguclu opened this issue Oct 24, 2022 · 14 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@ardaguclu
Copy link
Member

ardaguclu commented Oct 24, 2022

Enhancement Description

Tasks

No tasks being tracked yet.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 24, 2022
@ardaguclu
Copy link
Member Author

/milestone v1.27

@k8s-ci-robot
Copy link
Contributor

@ardaguclu: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ardaguclu
Copy link
Member Author

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 24, 2022
@soltysh
Copy link
Contributor

soltysh commented Jan 12, 2023

/assign @ardaguclu

@soltysh
Copy link
Contributor

soltysh commented Jan 12, 2023

/milestone v1.27
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2023
@soltysh
Copy link
Contributor

soltysh commented Jan 12, 2023

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 12, 2023
@Atharva-Shinde
Copy link

Hello @ardaguclu 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add response for this question in the Scalability questionnaire of the KEP readme

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ardaguclu
Copy link
Member Author

Thanks @Atharva-Shinde. I added response for the newly added Scalability question. Is there anything further I can do aside from waiting for PRR review?

@Atharva-Shinde
Copy link

Hey @ardaguclu, aside from getting PRR approved, everything for this KEP looks good for now :)

@ardaguclu
Copy link
Member Author

Thanks @Atharva-Shinde

@Atharva-Shinde
Copy link

@ardaguclu With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ardaguclu ardaguclu changed the title kubectl built-in command shadowing by external plugins Improve kubectl plugin resolution for non-shadowing subcommands Feb 14, 2023
@sftim
Copy link
Contributor

sftim commented Mar 6, 2023

Docs PR: kubernetes/website#39800

@LukeMwila
Copy link

Hi @ardaguclu, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@Atharva-Shinde
Copy link

Hey again @ardaguclu 👋 Enhancements team here,
Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Tracked
Development

No branches or pull requests

6 participants