Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplySet : kubectl apply --prune redesign and graduation strategy #3659

Open
3 of 4 tasks
KnVerey opened this issue Nov 15, 2022 · 12 comments
Open
3 of 4 tasks

ApplySet : kubectl apply --prune redesign and graduation strategy #3659

KnVerey opened this issue Nov 15, 2022 · 12 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Nov 15, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Nov 15, 2022
@soltysh
Copy link
Contributor

soltysh commented Jan 12, 2023

/assign @KnVerey
/stage alpha
/milestone v1.27
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 12, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2023
@marosset
Copy link
Contributor

Hello @KnVerey 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for v1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, it looks like #3661 will address most of these requirements.
Please be sure to also:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

@KnVerey
Copy link
Contributor Author

KnVerey commented Feb 9, 2023

@marosset I believe all of the requirements have been met with the merging of #3661 today!

@marosset
Copy link
Contributor

marosset commented Feb 9, 2023

This enhancement meets now meets all of the requirements to be tracked in v1.27.
Thanks!

@marosset marosset added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 9, 2023
@KnVerey KnVerey changed the title kubectl apply --prune redesign and graduation strategy ApplySet : kubectl apply --prune redesign and graduation strategy Mar 6, 2023
@KnVerey
Copy link
Contributor Author

KnVerey commented Mar 6, 2023

Docs placeholder PR: kubernetes/website#39818

@marosset
Copy link
Contributor

marosset commented Mar 8, 2023

Hi @KnVerey 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

Please let me know if there are any PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

@LukeMwila
Copy link

Hi @KnVerey, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@marosset
Copy link
Contributor

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed this from the v1.27 milestone Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 15, 2023
@KnVerey
Copy link
Contributor Author

KnVerey commented Mar 15, 2023

Hi @marosset they did make the release actually! You can see them here: https://github.com/orgs/kubernetes/projects/128/views/2. I will update the issue description. The only feature we were originally targeting as part of the first alpha that did not make it was kubectl diff support. The featureset in kubectl apply is complete as intended for this release.

@marosset
Copy link
Contributor

/milestonve v1.27
/label tracked/yes
/remove-label tracked/no

@k8s-ci-robot k8s-ci-robot added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Mar 15, 2023
@marosset
Copy link
Contributor

Hi @marosset they did make the release actually! You can see them here: https://github.com/orgs/kubernetes/projects/128/views/2. I will update the issue description. The only feature we were originally targeting as part of the first alpha that did not make it was kubectl diff support. The featureset in kubectl apply is complete as intended for this release.

@KnVerey I added this issue back into v1.27.
Thanks for linking all the PRs above!

@sftim
Copy link
Contributor

sftim commented Mar 20, 2023

BTW, nearly all the labels we register are using subdomains of kubernetes.io. This KEP is using *.k8s.io keys.

If you want to make life easier for end users, get an exception in to change the labels, before beta (ideally, before the alpha release). I know it's a bit later, but it looks like we missed that detail in earlier reviews.

See https://kubernetes.io/docs/reference/labels-annotations-taints/ for the list of registered keys that we use for labels and annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked
Development

No branches or pull requests

6 participants