Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve nodeport ranges for dynamic and static allocation #3668

Open
12 tasks done
xuzhenglun opened this issue Nov 28, 2022 · 43 comments
Open
12 tasks done

Reserve nodeport ranges for dynamic and static allocation #3668

xuzhenglun opened this issue Nov 28, 2022 · 43 comments
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@xuzhenglun
Copy link
Contributor

xuzhenglun commented Nov 28, 2022

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 28, 2022
@aojea
Copy link
Member

aojea commented Nov 28, 2022

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 28, 2022
@xuzhenglun xuzhenglun changed the title [WIP] Reserve nodeport ranges for dynamic and static allocation Reserve nodeport ranges for dynamic and static allocation Dec 10, 2022
@wojtek-t
Copy link
Member

@thockin @aojea - I think we want to opt-in this for 1.27, right?

@aojea
Copy link
Member

aojea commented Jan 23, 2023

yes, @xuzhenglun that is the plan , right?

@thockin thockin added this to the v1.27 milestone Jan 24, 2023
@xuzhenglun
Copy link
Contributor Author

yes, @xuzhenglun that is the plan , right?

yes, it is. now PR is ready and waiting for next step review kubernetes/kubernetes#114418

@wojtek-t
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 24, 2023
@Atharva-Shinde
Copy link
Contributor

Hello @xuzhenglun 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@thockin thockin moved this from New, not evaluated to Pre-Alpha (we want to do this but the KEP or code is not merged yet) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Feb 3, 2023
@xuzhenglun
Copy link
Contributor Author

Hello @xuzhenglun 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Atharva-Shinde KEP has fixed in #3809, should I do anything else to remove at risk label?

@xuzhenglun xuzhenglun moved this from Pre-Alpha (we want to do this but the KEP or code is not merged yet) to Alpha gated (code is merged) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Feb 3, 2023
@Atharva-Shinde
Copy link
Contributor

@xuzhenglun
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@mickeyboxell
Copy link

Hi @xuzhenglun 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

Please feel free to reach out with any questions. Thanks!

@xuzhenglun
Copy link
Contributor Author

I think a blog is enough for this KEP, WDYT? @aojea

Placeholder doc PR link: kubernetes/website#39850 @mickeyboxell

@Atharva-Shinde
Copy link
Contributor

Hey again @xuzhenglun 👋 Enhancements team here,
Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@marosset marosset added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Mar 13, 2023
@thockin thockin modified the milestones: v1.27, v1.28 Apr 27, 2023
@thockin
Copy link
Member

thockin commented Apr 27, 2023

NEXT: Aiming for Beta in 1.28

@aojea
Copy link
Member

aojea commented Apr 27, 2023

@xuzhenglun ^^^^

@thockin thockin modified the milestones: v1.28, v1.29 Aug 17, 2023
@xuzhenglun
Copy link
Contributor Author

@thockin

The criteria for GA says that we need 2 beta versions before GA, and this feature was beta in 1.28. So I think it should GA in 1.30. Please correct me if I'm wrong

@thockin
Copy link
Member

thockin commented Aug 20, 2023

Where are you seeing that things must spend 2 releases in beta? If that is new, it's news to me. If that has always been true, I have utterly forgotten, and we certainly have not always followed it.

Especially in this case where we're following pretty exactly the recipe laid out by the equivalent feature for IPs

@xuzhenglun
Copy link
Contributor Author

xuzhenglun commented Aug 21, 2023

@thockin

Where are you seeing that things must spend 2 releases in beta?

  1. It was firstly mentioned in KEP review comment by @aojea .

    1.30, the criteria for GA says

  2. And I saw it in deprecation-policy it says:

    Beta feature to GA: 6 months or 2 releases (whichever is longer)

I'm not pretty sure if I can publish it in 1.29, do we need someone else's opinion? But in my shoes, I'm glad to publish it ASAP.

@aojea
Copy link
Member

aojea commented Aug 21, 2023

@liggitt are we being to strict ? ^^^

@liggitt
Copy link
Member

liggitt commented Aug 21, 2023

There's no requirement to stay in beta for two releases. Some features have more graduation requirements or require more feedback or exposure or proving out, but mechanically it's fine to have a single beta release before graduating.

@aojea
Copy link
Member

aojea commented Aug 21, 2023

ok, so it seems I was too conservative here and we are good to go with one release for this feature, since this is a follow up on a previous feature

Especially in this case where we're following pretty exactly the recipe laid out by the equivalent feature for IPs

@xuzhenglun do you mind updating the KEP and PR kubernetes to go GA in 1.29?

@xuzhenglun
Copy link
Contributor Author

@aojea

do you mind updating the KEP and PR kubernetes to go GA in 1.29?

No problem, I will update the KEP ASAP.


@thockin

I am tracking this for GA in 1.29 - is that correct?

According to the results discussed above, I think this is good to go for GA in 1.29.

@thockin
Copy link
Member

thockin commented Aug 21, 2023

  1. And I saw it in deprecation-policy it says

That speaks to how long the gate will continue to exist after it reaches GA: "Feature gates must function..." :)

@sanchita-07
Copy link
Member

Hello @xuzhenglun 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage stable for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we just need to mark the status as implemented for the latest-milestone: 1.29 as this is targeting for stable.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

Thank you!

@xuzhenglun
Copy link
Contributor Author

@sanchita-07

HI, I'm a little confused about the status implemented.

I noticed that you mentioned that the implemented status should be marked after the feature gates are removed. However, this KEP has just transitioned to GA in version 1.29. The feature gates are still functioning and are planned to be removed in version 1.31.

So in this situation, I'm not sure whether we should change the status to implemented.

@thockin
Copy link
Member

thockin commented Sep 30, 2023 via email

@sanchita-07
Copy link
Member

@npolshakova can you chime in here, and help clarify the doubt, please?

@npolshakova
Copy link

@sanchita-07

HI, I'm a little confused about the status implemented.

I noticed that you mentioned that the implemented status should be marked after the feature gates are removed. However, this KEP has just transitioned to GA in version 1.29. The feature gates are still functioning and are planned to be removed in version 1.31.

So in this situation, I'm not sure whether we should change the status to implemented.

Hi @xuzhenglun, 1.29 Enhancement lead here! To clarify the confusion- KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed. Once the code pr removing the feature gate is merged in, this KEP should be marked as implemented and this issue closed out. Since you are keeping the feature gate until 1.31, this can stay implementable until the feature gates are removed in 1.31. Thanks!

@xuzhenglun
Copy link
Contributor Author

Hi @sanchita-07, as npolshakova clarified above, This KEP will remain implementable for now. So, am I good for the 1.29 release? I'm happy to address any further tasks if needed.

@sanchita-07
Copy link
Member

Hi @xuzhenglun, with all the requirements for this KEP in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀
The status of this enhancement is marked as Tracked for Enhancement Freeze.
Thank you :)

@harshitasao
Copy link

Hi @xuzhenglun 👋, v1.29 Docs Shadow here
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@xuzhenglun
Copy link
Contributor Author

HI @harshitasao,

All documents changed has been merged in kubernetes/website#42774

@sanchita-07
Copy link
Member

Hey again @xuzhenglun 👋, 1.29 Enhancements team here.

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023:

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PR was merged before code freeze:

With all this, the status of this KEP is tracked for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@kcmartin
Copy link

kcmartin commented Oct 30, 2023

Hi @xuzhenglun ! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@thockin thockin added this to the v1.31 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: Tracked
Status: Tracked for Code Freeze
Development

No branches or pull requests