Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Dual-Stack --node-ip Handling #3705

Open
1 of 4 tasks
danwinship opened this issue Dec 30, 2022 · 12 comments
Open
1 of 4 tasks

Cloud Dual-Stack --node-ip Handling #3705

danwinship opened this issue Dec 30, 2022 · 12 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@danwinship
Copy link
Contributor

danwinship commented Dec 30, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 30, 2022
@danwinship
Copy link
Contributor Author

/sig network
/sig node
/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 30, 2022
@thockin thockin added this to New, not evaluated in SIG-Network KEPs via automation Jan 5, 2023
@thockin thockin moved this from New, not evaluated to Evaluated, not committed (undecided whether we want to do this or not) in SIG-Network KEPs Jan 5, 2023
@thockin thockin self-assigned this Jan 28, 2023
@thockin thockin added this to the v1.27 milestone Jan 28, 2023
@wojtek-t
Copy link
Member

wojtek-t commented Feb 2, 2023

/label lead-opted-in

@thockin - FYI ^^

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2023
@Atharva-Shinde
Copy link

Hello @danwinship @thockin 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add response for this question in the Scalability questionnaire of the KEP readme
  • Referring to this discussion, we need to add a reviewer.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Atharva-Shinde
Copy link

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 6, 2023
@Atharva-Shinde
Copy link

Thanks @danwinship, with all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well :)

@thockin thockin moved this from Evaluated, not committed (undecided whether we want to do this or not) to Pre-Alpha (we want to do this but the KEP or code is not merged yet) in SIG-Network KEPs Feb 8, 2023
@Rishit-dagli
Copy link
Member

Hi @danwinship 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

@Atharva-Shinde
Copy link

Atharva-Shinde commented Mar 12, 2023

Hey again @danwinship 👋 Enhancements team here,
Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@marosset
Copy link
Contributor

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

@k8s-ci-robot
Copy link
Contributor

@marosset: Those labels are not set on the issue: tracked/yes

In response to this:

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed this from the v1.27 milestone Mar 15, 2023
@salaxander
Copy link

salaxander commented Mar 15, 2023

/label tracked/yes
/milestone v1.27

@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 15, 2023
@salaxander salaxander added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Mar 15, 2023
@salaxander
Copy link

Hey folks! With that last PR merged I've marked the exception as complete in our tracking. Thanks!!

@thockin thockin moved this from Pre-Alpha (we want to do this but the KEP or code is not merged yet) to Alpha gated (code is merged) in SIG-Network KEPs Mar 16, 2023
@mickeyboxell
Copy link

@danwinship @thockin was there a Docs PR opened against dev-1.27 branch in the k/website repo?

If not, please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

mkowalski added a commit to mkowalski/openshift-api that referenced this issue Mar 22, 2023
In order to allow passing dual-stack IPs to the `--node-ip` when using
cloud provider, we are enabling the CloudDualStackNodeIPs feature gate.

This affects only behaviour of deployments that want to pass 2 IP
addresses as `--node-ip` together with `--cloud-provider`. Before K8s
1.27 this was not possible (you can either have dual-stack Node IPs or
use a cloud provider, but not both).

Upstream KEP kubernetes/enhancements#3705
adds ability to pass exactly 2 IPs as `--node-ip` also when using cloud
provider, but given its alpha stage, feature gate is required here.

Enablement of this feature gate is not affecting in any way single-stack
deployments as well as dual-stack deployments with no cloud provider.

Enablement of this feature gate is not affecting in any way single-stack
deployments that use cloud provider.

Enablement of this feature gate is not changing the behaviour of any
configuration that is working today (i.e. before K8s 1.27).

Relates-to: OPNET-13
Relates-to: OPNET-230
mkowalski added a commit to mkowalski/openshift-api that referenced this issue Mar 22, 2023
In order to allow passing dual-stack IPs to the `--node-ip` when using
cloud provider, we are enabling the CloudDualStackNodeIPs feature gate.

This affects only behaviour of deployments that want to pass 2 IP
addresses as `--node-ip` together with `--cloud-provider`. Before K8s
1.27 this was not possible (you can either have dual-stack Node IPs or
use a cloud provider, but not both).

Upstream KEP kubernetes/enhancements#3705
adds ability to pass exactly 2 IPs as `--node-ip` also when using cloud
provider, but given its alpha stage, feature gate is required here.

Enablement of this feature gate is not affecting in any way single-stack
deployments as well as dual-stack deployments with no cloud provider.

Enablement of this feature gate is not affecting in any way single-stack
deployments that use cloud provider.

Enablement of this feature gate is not changing the behaviour of any
configuration that is working today (i.e. before K8s 1.27).

Relates-to: OPNET-13
Relates-to: OPNET-230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked
SIG-Network KEPs
Alpha gated (code is merged)
Development

No branches or pull requests

9 participants