Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Dual-Stack --node-ip Handling #3705

Open
12 tasks done
danwinship opened this issue Dec 30, 2022 · 29 comments
Open
12 tasks done

Cloud Dual-Stack --node-ip Handling #3705

danwinship opened this issue Dec 30, 2022 · 29 comments
Assignees
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@danwinship
Copy link
Contributor

danwinship commented Dec 30, 2022

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 30, 2022
@danwinship
Copy link
Contributor Author

/sig network
/sig node
/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 30, 2022
@thockin thockin moved this from New, not evaluated to Evaluated, not committed (undecided whether we want to do this or not) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Jan 5, 2023
@thockin thockin self-assigned this Jan 28, 2023
@thockin thockin added this to the v1.27 milestone Jan 28, 2023
@wojtek-t
Copy link
Member

wojtek-t commented Feb 2, 2023

/label lead-opted-in

@thockin - FYI ^^

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2023
@Atharva-Shinde
Copy link
Contributor

Hello @danwinship @thockin 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Add response for this question in the Scalability questionnaire of the KEP readme
  • Referring to this discussion, we need to add a reviewer.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Atharva-Shinde
Copy link
Contributor

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 6, 2023
@Atharva-Shinde
Copy link
Contributor

Thanks @danwinship, with all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well :)

@thockin thockin moved this from Evaluated, not committed (undecided whether we want to do this or not) to Pre-Alpha (we want to do this but the KEP or code is not merged yet) in Obsolete: SIG-Network KEPs (see https://github.com/orgs/kubernetes/projects/148) Feb 8, 2023
@Rishit-dagli
Copy link
Member

Hi @danwinship 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

@Atharva-Shinde
Copy link
Contributor

Atharva-Shinde commented Mar 12, 2023

Hey again @danwinship 👋 Enhancements team here,
Just checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Here's where this enhancement currently stands:

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@marosset
Copy link
Contributor

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

@k8s-ci-robot
Copy link
Contributor

@marosset: Those labels are not set on the issue: tracked/yes

In response to this:

Unfortunately the implementation PRs associated with this enhancement have not merged by code-freeze so this enhancement is getting removed from the release.

If you would like to file an exception please see https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

/milestone clear
/remove-label tracked/yes
/label tracked/no

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Mar 15, 2023
@k8s-ci-robot k8s-ci-robot removed this from the v1.27 milestone Mar 15, 2023
mkowalski added a commit to mkowalski/cluster-cloud-controller-manager-operator that referenced this issue Jul 3, 2023
In order to allow passing dual-stack IPs to the `--node-ip` when using
cloud provider, we need to pass the CloudDualStackNodeIPs feature gate.

In order to do so properly, we are passing all known feature gates
together with their respective configurations directly to the
deployments of vSphere and OpenStack cloud providers.

The CloudDualStackNodeIPs feature gate will only affect setups with 2 IP
addresses as `--node-ip` together with `--cloud-provider`. Before K8s
1.27 this was not possible (you can either have dual-stack Node IPs or
use a cloud provider, but not both).

Upstream KEP kubernetes/enhancements#3705
adds ability to pass exactly 2 IPs as `--node-ip` also when using cloud
provider, but given its alpha stage, feature gate is required here.

Relates-to: OPNET-13
Relates-to: OPNET-230
Fixes: OPNET-319
@danwinship
Copy link
Contributor Author

/assign

@SergeyKanzhelev
Copy link
Member

this targets beta:

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Sep 15, 2023
@npolshakova
Copy link

Hello @danwinship, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 27, 2023
@sreeram-venkitesh
Copy link
Member

Hello @danwinship 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@harshitasao
Copy link

Hi @danwinship 👋, v1.29 Docs Shadow here
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@danwinship
Copy link
Contributor Author

@harshitasao The only docs work needed was kubernetes/website#42875 which has merged since the last time I looked at this enhancement. I updated the checklist to reflect that.

@sreeram-venkitesh
Copy link
Member

sreeram-venkitesh commented Oct 27, 2023

Hey again @danwinship 👋 v1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

This KEP is tracked for code freeze since all the associated code PRs have been merged for the beta stage and has been updated in the issue description 🎉

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

@kcmartin
Copy link

Hi @danwinship ! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@thockin thockin added this to the v1.30 milestone Jan 23, 2024
@thockin thockin added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 23, 2024
@pnbrown
Copy link

pnbrown commented Feb 7, 2024

Hello @danwinship 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for v1.30 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: { CURRENT_RELEASE }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@a-mccarthy
Copy link

Hi @danwinship,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@pnbrown
Copy link

pnbrown commented Feb 29, 2024

Hey again @danwinship 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@thockin
Copy link
Member

thockin commented May 8, 2024

GA'd in 30, cleanup in 32

@thockin thockin modified the milestones: v1.30, v1.32 May 8, 2024
@sreeram-venkitesh
Copy link
Member

Hi! v1.31 Enhancements lead here 👋🏼

I'm assuming the status will be updated to implemented in v1.32 along with the cleanup, right? I'll remove the lead-opted-in label and remove this KEP from the v1.31 tracking board. Please let me know if this works.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Tracked
Status: Tracked for Code Freeze
Status: Tracked for Doc Freeze
Obsolete: SIG-Network KEPs (see https...
Alpha gated (code is merged)
Status: 04 GA
Development

No branches or pull requests