-
Notifications
You must be signed in to change notification settings - Fork 1.5k
CEL-based admission webhook match conditions #3716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is this for admission webhooks only, or for all HTTP callouts (eg https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#imagepolicywebhook and https://kubernetes.io/docs/reference/access-authn-authz/webhook/)? |
Is there a KEP for this I can review for PRR? |
Hello @tallclair 👋, v1.27 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this enhancement, the first thing we need is access to the KEP so we can then confirm the rest. The status of this enhancement is marked as |
If so, should this be tracked separately? I've confused about what I'm supposed to review for PRR here. |
The problem was the original title - the rename fully addressed my concern. |
If we want CEL conditions for |
Hi @logicalhan , an update based on the linked KEP PR. This enhancement is targeting for stage Here's where this enhancement currently stands, assuming #3717 in it's current state:
For this enhancement, the following would need to be updated, assuming #3717 in it's current state:
The status of this enhancement is marked as |
@fsmunoz Thanks for the list. The remaining items are addressed in #3861 @logicalhan sorry for missing your earlier questions! It looks like you figured it out, but please ping me on chat/slack if you have any outstanding questions. |
Hello @tallclair , thank you. I'm marking this as tracked with two comments:
This enhancement is ready to be traced for graduation to alpha in v1.27 /stage alpha |
@fsmunoz: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/stage alpha |
Just raised a PR: #4513 |
Hello @tallclair 👋, 1.30 Docs Shadow here. (At a minimum, please remember to update the feature flags to |
Hi @tallclair, 👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating. To opt in, you need to open a Feature Blog placeholder PR against the website repository. |
/assign @ivelichkovich Igor, can you take a look at the docs & comms requests above? |
Hey again @tallclair, @jpbetz 👋 v1.30 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024. Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the issue description to include all the related PRs of this KEP): Currently, I'm marking this KEP as |
@tallclair, @jpbetz: Are all the code PRs for this KEP merged? Are there any other PRs we should track other than kubernetes/kubernetes#123560? |
Yes. These two PRs were merged to complete the GA promotion:
I've added them to the issue description as well (I also added the doc placeholder PR). Let us know if you see anything missing, our understanding is that this enhancement is fully graduated and should be tracked as such at part of 1.30. Thanks! |
Thank you @jpbetz! With all the implementation (code related) PRs merged as per the issue description:
This enhancement is now marked as |
Raised a docs PR ready to review for this: kubernetes/website#45525 |
Hi @tallclair @jpbetz 👋, 1.31 Enhancements Lead here. Since this KEP graduated to GA in v1.30, please make sure to update the status field from /remove-label lead-opted-in |
Yes I can update this |
PR here: #4637 |
Enhancement Description
k/enhancements
) update PR(s):k/k
) update PR(s):AdmissionWebhookMatchCondition
to beta kubernetes#119380k/website
) update PR(s):k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):k/enhancements
) update PR(s): KEP-3716: graduate to stable for 1.30 #4435k/k
) update PR(s):k/website
) update(s): [docs placeholder] Matchconditions 1.30 website#45279Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: