Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEL-based admission webhook match conditions #3716

Open
2 of 4 tasks
tallclair opened this issue Jan 10, 2023 · 19 comments
Open
2 of 4 tasks

CEL-based admission webhook match conditions #3716

tallclair opened this issue Jan 10, 2023 · 19 comments
Assignees
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@tallclair
Copy link
Member

tallclair commented Jan 10, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 10, 2023
@tallclair tallclair added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 10, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 10, 2023
@tallclair tallclair added this to the v1.27 milestone Jan 10, 2023
@tallclair tallclair added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jan 10, 2023
@tallclair tallclair self-assigned this Jan 10, 2023
@sftim
Copy link
Contributor

sftim commented Jan 10, 2023

@tallclair tallclair changed the title CEL-based webhook filters CEL-based admission webhook match conditions Jan 19, 2023
@tallclair
Copy link
Member Author

@sftim this is only for admission webhooks (updated the title). We've also had conversations about doing something similar for authorization webhooks, but that will probably be folded in with #3221

@logicalhan
Copy link
Contributor

Is there a KEP for this I can review for PRR?

@fsmunoz
Copy link

fsmunoz commented Feb 1, 2023

Hello @tallclair 👋, v1.27 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023.

This enhancement is targeting for stage alpha for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, the first thing we need is access to the KEP so we can then confirm the rest.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@logicalhan
Copy link
Contributor

@sftim this is only for admission webhooks (updated the title). We've also had conversations about doing something similar for authorization webhooks, but that will probably be folded in with #3221

If so, should this be tracked separately? I've confused about what I'm supposed to review for PRR here.

@sftim
Copy link
Contributor

sftim commented Feb 2, 2023

The problem was the original title - the rename fully addressed my concern.

@sftim
Copy link
Contributor

sftim commented Feb 2, 2023

If we want CEL conditions for admission authz webhooks, that change won't be part of this KEP.

@fsmunoz
Copy link

fsmunoz commented Feb 8, 2023

Hi @logicalhan , an update based on the linked KEP PR.

This enhancement is targeting for stage alpha for 1.27 (please correct me, if otherwise)

Here's where this enhancement currently stands, assuming #3717 in it's current state:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.27
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this enhancement, the following would need to be updated, assuming #3717 in it's current state:

  • Use the latest version of the template. There is an additional question on the Scalability section of the PRR, although in one that isn't mandatory for alpha, it would be a good time to add it and sync with the latest template structure.
  • An updated Test Plan, with the sections filled.
  • Up-to-date graduation criteria filled.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@tallclair
Copy link
Member Author

@fsmunoz Thanks for the list. The remaining items are addressed in #3861

@logicalhan sorry for missing your earlier questions! It looks like you figured it out, but please ping me on chat/slack if you have any outstanding questions.

@fsmunoz
Copy link

fsmunoz commented Feb 9, 2023

Hello @tallclair , thank you.

I'm marking this as tracked with two comments:

  • The Test Plan has TBD information that should be analysed and reviewed.
  • The Graduation Criteria would benefit from including other stages, but it does contain the alpha one.

This enhancement is ready to be traced for graduation to alpha in v1.27

/stage alpha
/label tracked/yes

@k8s-ci-robot
Copy link
Contributor

@fsmunoz: The label(s) /label stage/alpha cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, lead-opted-in, tracked/no, tracked/out-of-tree, tracked/yes. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

Hello @tallclair , thank you.

I'm marking this as tracked with two comments:

  • The Test Plan has TBD information that should be analysed and reviewed.
  • The Graduation Criteria would benefit from including other stages, but it does contain the alpha one.

This enhancement is ready to be traced for graduation to alpha in v1.27

/label stage/alpha
/label tracked/yes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 9, 2023
@fsmunoz
Copy link

fsmunoz commented Feb 9, 2023

/stage alpha

@katmutua
Copy link

katmutua commented Mar 9, 2023

Hello @tallclair 👋🏾 !

@katmutua 1.27 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

If you already have existing open PRs please link them to the description so we can easily track them. Thanks!

@fsmunoz
Copy link

fsmunoz commented Mar 13, 2023

Hi @tallclair 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are fully merged by the code freeze deadline.

For this enhancement, it looks like the following PRs need to be merged before code freeze:

Please let me know what other PRs in k/k I should be tracking for this KEP.

As always, we are here to help should questions come up. Thanks!

@ivelichkovich
Copy link

This should be graduation criteria for beta: kubernetes/kubernetes#116588

@ivelichkovich
Copy link

another beta graduation requirement: kubernetes/kubernetes#116609

@salaxander
Copy link

Hey folks! With everything merged, I've marked the exception as complete on our tracking. Thanks!!

@mickeyboxell
Copy link

Hi @tallclair, as @katmutua mentioned, please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This placeholder PR must be created by today, March 16, and should be ready for review on Tuesday, March 21.

@tallclair
Copy link
Member Author

Docs PR: kubernetes/website#40058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked
Status: In Progress
Development

No branches or pull requests

9 participants