New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CEL-based admission webhook match conditions #3716
Comments
Is this for admission webhooks only, or for all HTTP callouts (eg https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#imagepolicywebhook and https://kubernetes.io/docs/reference/access-authn-authz/webhook/)? |
Is there a KEP for this I can review for PRR? |
Hello @tallclair Just checking in as we approach enhancements freeze on 18:00 PDT Thursday 9th February 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this enhancement, the first thing we need is access to the KEP so we can then confirm the rest. The status of this enhancement is marked as |
If so, should this be tracked separately? I've confused about what I'm supposed to review for PRR here. |
The problem was the original title - the rename fully addressed my concern. |
If we want CEL conditions for |
Hi @logicalhan , an update based on the linked KEP PR. This enhancement is targeting for stage Here's where this enhancement currently stands, assuming #3717 in it's current state:
For this enhancement, the following would need to be updated, assuming #3717 in it's current state:
The status of this enhancement is marked as |
@fsmunoz Thanks for the list. The remaining items are addressed in #3861 @logicalhan sorry for missing your earlier questions! It looks like you figured it out, but please ping me on chat/slack if you have any outstanding questions. |
Hello @tallclair , thank you. I'm marking this as tracked with two comments:
This enhancement is ready to be traced for graduation to alpha in v1.27 /stage alpha |
@fsmunoz: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/stage alpha |
Hello @tallclair 👋🏾 ! @katmutua 1.27 Release Docs shadow here. This enhancement is marked as ‘Needs Docs’ for 1.27 release. Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release. If you already have existing open PRs please link them to the description so we can easily track them. Thanks! |
Hi @tallclair Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023. Please ensure the following items are completed:
For this enhancement, it looks like the following PRs need to be merged before code freeze: Please let me know what other PRs in k/k I should be tracking for this KEP. As always, we are here to help should questions come up. Thanks! |
This should be graduation criteria for beta: kubernetes/kubernetes#116588 |
another beta graduation requirement: kubernetes/kubernetes#116609 |
Hey folks! With everything merged, I've marked the exception as complete on our tracking. Thanks!! |
Hi @tallclair, as @katmutua mentioned, please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This placeholder PR must be created by today, March 16, and should be ready for review on Tuesday, March 21. |
Docs PR: kubernetes/website#40058 |
Enhancement Description
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: