Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Application Protocols #3726

Closed
4 tasks done
LiorLieberman opened this issue Jan 11, 2023 · 9 comments
Closed
4 tasks done

Standard Application Protocols #3726

LiorLieberman opened this issue Jan 11, 2023 · 9 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network.
Milestone

Comments

@LiorLieberman
Copy link
Member

LiorLieberman commented Jan 11, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 11, 2023
@LiorLieberman
Copy link
Member Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 11, 2023
@thockin thockin self-assigned this Jan 28, 2023
@thockin thockin added this to the v1.27 milestone Jan 28, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2023
@thockin thockin added this to New, not evaluated in SIG-Network KEPs via automation Apr 28, 2023
@thockin thockin removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 28, 2023
@thockin
Copy link
Member

thockin commented Apr 28, 2023

What's the next step? This has no gates and is already GA - should we close it as complete?

@thockin thockin moved this from New, not evaluated to GA (merged, gate not removed) in SIG-Network KEPs Apr 28, 2023
@thockin thockin moved this from GA (merged, gate not removed) to DONE (GA, merged, gate removed) in SIG-Network KEPs Apr 28, 2023
@LiorLieberman
Copy link
Member Author

LiorLieberman commented Apr 28, 2023

I spoke with @aojea offline, it looks like this was not tracked for the release for some reason, and I missed updating the docs. (my bad, it was my first KEP 😕).

I opened kubernetes/website#40881 for updating the doc and converted a draft PR I had opened to update the KEP according to what we merged.

You could either mark it as complete or I will ping you here again when the docs PR is merged.

@thockin
Copy link
Member

thockin commented Apr 28, 2023

Come back here and close it when docs are in.

Are we going to revisit GRPC?

@LiorLieberman
Copy link
Member Author

Will do.
Probably will bring up the idea of changing appProtocol to a list to one of the sig meetings before revisiting GRPC standard name.

@aojea
Copy link
Member

aojea commented May 3, 2023

Probably will bring up the idea of changing appProtocol to a list to one of the sig meetings before revisiting GRPC standard name.

one advice if you want to introduce the topic in the meeting, is to bring examples of the existing API and the proposal on how it will look like,

@dprotaso
Copy link
Contributor

dprotaso commented May 5, 2023

Curious if people here think it's possible to address GRPC without requiring appProtocol to support a list?

I don't deny the use case for multiple appProtocols - since you could have servers multiplexing protocols on the same port.

It would be just great to see if we could decouple adding protocol constants from changing the K8s API.

@LiorLieberman
Copy link
Member Author

Docs PR merged today. Still waiting for #3912 to have @johnbelamaric approval but this is just an update of the KEP based on whats already merged upstream.

Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
SIG-Network KEPs
DONE (GA, merged, gate removed)
Development

No branches or pull requests

6 participants