Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive Read-only (RRO) mounts #3857

Open
13 tasks done
AkihiroSuda opened this issue Feb 8, 2023 · 45 comments
Open
13 tasks done

Recursive Read-only (RRO) mounts #3857

AkihiroSuda opened this issue Feb 8, 2023 · 45 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Feb 8, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 8, 2023
@AkihiroSuda
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2023
@SergeyKanzhelev
Copy link
Member

adding sig storage as participating sig

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 5, 2023
@SergeyKanzhelev
Copy link
Member

@AkihiroSuda do you want to target this KEP for 1.28?

@AkihiroSuda
Copy link
Member Author

@AkihiroSuda do you want to target this KEP for 1.28?

Not necessary.

@AkihiroSuda AkihiroSuda changed the title Recursively Read-only (RRO) hostPath mounts Recursively Read-only (RRO) mounts May 30, 2023
@AkihiroSuda AkihiroSuda changed the title Recursively Read-only (RRO) mounts Recursive Read-only (RRO) mounts Jun 2, 2023
@AkihiroSuda
Copy link
Member Author

@kubernetes/sig-node-leads
Any chance to get this lead-opted-in for v1.29?

@AkihiroSuda
Copy link
Member Author

ping @kubernetes/sig-node-leads 🙏

@AkihiroSuda
Copy link
Member Author

@kubernetes/sig-node-leads
Will this be considered for lead-opted-in in the v1.30 milestone?

@AkihiroSuda
Copy link
Member Author

cc @mrunalp @derekwaynecarr @dchen1107 @SergeyKanzhelev for the question above about v1.30 milestone

@pacoxu
Copy link
Member

pacoxu commented Oct 16, 2023

+1 for v1.30

  • We may tag this as v1.30 and get some early input.

adding sig storage as participating sig

@SergeyKanzhelev do we have to check with sig storage leads about this KEP?

@AkihiroSuda
Copy link
Member Author

@mrunalp @derekwaynecarr @dchen1107 @SergeyKanzhelev

PTAL.
If this KEP isn't going to be accepted, I'll just modify the default behavior of containerd to treat "readonly" as "recursive readonly".
Small portion of users may find this to be a breaking change, but probably this is subtle enough.
#3858 (comment)

@carlory
Copy link
Member

carlory commented Jan 17, 2024

@SergeyKanzhelev added sig storage as participating sig for this KEP. The proposal makes sense to me, but I still want to hear from the sig storage members. cc @jsafrane @msau42 @xing-yang Can you please review the proposal and provide your feedback? Thanks! If accepted, this KEP may be able to have an alpha implement in 1.30.

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jan 30, 2024

Didn't get lead-opted-in. Giving up.

Alternative:

@AkihiroSuda AkihiroSuda closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
@AkihiroSuda
Copy link
Member Author

Reopening

#3858 (comment)

@mrunalp
Copy link
Contributor

mrunalp commented Feb 5, 2024

/milestone 1.30
/stage alpha
/label lead-opted-in

@k8s-ci-robot
Copy link
Contributor

@mrunalp: The provided milestone is not valid for this repository. Milestones in this repository: [v1.25, v1.27, v1.28, v1.29, v1.30, v1.31]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.30
/stage alpha
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 5, 2024
@mrunalp
Copy link
Contributor

mrunalp commented Feb 5, 2024

/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 5, 2024
@sreeram-venkitesh
Copy link
Member

Hi @AkihiroSuda 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label May 15, 2024
@SergeyKanzhelev
Copy link
Member

@AkihiroSuda do you plan to progress it in 1.31?

@AkihiroSuda
Copy link
Member Author

@AkihiroSuda do you plan to progress it in 1.31?

Yes,

@AkihiroSuda
Copy link
Member Author

@kubernetes/sig-node-leads Could you lead-opt-in ?

@mrunalp
Copy link
Contributor

mrunalp commented Jun 4, 2024

/milestone v1.31
/stage beta
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.30, v1.31 Jun 4, 2024
@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status lead-opted-in Denotes that an issue has been opted in to a release labels Jun 4, 2024
@dipesh-rawat
Copy link
Member

Hello @AkihiroSuda 👋, 1.31 Enhancements team here.

Just checking in as we approach enhancements freeze on on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage beta for 1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • Please update kep.yaml to reflect beta for v1.31
  • Please submit a PRR for beta

It looks like #4668 will address most of these issues.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat
Copy link
Member

Hi @AkihiroSuda 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment #3857 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat
Copy link
Member

Hi @AkihiroSuda 👋, 1.31 Enhancements team here,

Now that PR #4668 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nits could be addressed:

  • Update issue description to mention the following:
    • Beta release target (x.y): 1.31

Aside from the minor nit mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@AkihiroSuda
Copy link
Member Author

Update issue description to mention the following:

done

@hacktivist123
Copy link

Hello @AkihiroSuda 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

@AkihiroSuda
Copy link
Member Author

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

No, not required AFAICS

@hacktivist123
Copy link

hacktivist123 commented Jun 18, 2024

Thanks @AkihiroSuda

@rashansmith
Copy link

Hi @johnbelamaric,

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@rashansmith
Copy link

Hey @johnbelamaric, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

@dipesh-rawat
Copy link
Member

Hey again @AkihiroSuda👋, 1.31 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With all the implementation(code related) PRs merged as per the issue description:

Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

This enhancement is now marked as tracked for code freeze for the 1.31 Code Freeze!

@kannon92
Copy link
Contributor

Given that it was promoted to beta in 1.31, I am not sure we will make progress on stable for 1.32. Please let us know if you need some cycles from reviewers for 1.32.

@AkihiroSuda
Copy link
Member Author

No action is planned for v1.32.

#### GA
- Two beta releases of Kubernetes at least
- containerd, CRI-O, and cri-dockerd supports the feature with their GA releases

@tjons
Copy link
Contributor

tjons commented Sep 16, 2024

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked for Doc Freeze
Status: Not for release
Status: Tracked for Doc Freeze
Development

No branches or pull requests