Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive Read-only (RRO) mounts #3857

Open
2 of 10 tasks
AkihiroSuda opened this issue Feb 8, 2023 · 25 comments
Open
2 of 10 tasks

Recursive Read-only (RRO) mounts #3857

AkihiroSuda opened this issue Feb 8, 2023 · 25 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Feb 8, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 8, 2023
@AkihiroSuda
Copy link
Member Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2023
@SergeyKanzhelev
Copy link
Member

adding sig storage as participating sig

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 5, 2023
@SergeyKanzhelev
Copy link
Member

@AkihiroSuda do you want to target this KEP for 1.28?

@AkihiroSuda
Copy link
Member Author

@AkihiroSuda do you want to target this KEP for 1.28?

Not necessary.

@AkihiroSuda AkihiroSuda changed the title Recursively Read-only (RRO) hostPath mounts Recursively Read-only (RRO) mounts May 30, 2023
@AkihiroSuda AkihiroSuda changed the title Recursively Read-only (RRO) mounts Recursive Read-only (RRO) mounts Jun 2, 2023
@AkihiroSuda
Copy link
Member Author

@kubernetes/sig-node-leads
Any chance to get this lead-opted-in for v1.29?

@AkihiroSuda
Copy link
Member Author

ping @kubernetes/sig-node-leads 🙏

@AkihiroSuda
Copy link
Member Author

@kubernetes/sig-node-leads
Will this be considered for lead-opted-in in the v1.30 milestone?

@AkihiroSuda
Copy link
Member Author

cc @mrunalp @derekwaynecarr @dchen1107 @SergeyKanzhelev for the question above about v1.30 milestone

@pacoxu
Copy link
Member

pacoxu commented Oct 16, 2023

+1 for v1.30

  • We may tag this as v1.30 and get some early input.

adding sig storage as participating sig

@SergeyKanzhelev do we have to check with sig storage leads about this KEP?

@AkihiroSuda
Copy link
Member Author

@mrunalp @derekwaynecarr @dchen1107 @SergeyKanzhelev

PTAL.
If this KEP isn't going to be accepted, I'll just modify the default behavior of containerd to treat "readonly" as "recursive readonly".
Small portion of users may find this to be a breaking change, but probably this is subtle enough.
#3858 (comment)

@carlory
Copy link
Member

carlory commented Jan 17, 2024

@SergeyKanzhelev added sig storage as participating sig for this KEP. The proposal makes sense to me, but I still want to hear from the sig storage members. cc @jsafrane @msau42 @xing-yang Can you please review the proposal and provide your feedback? Thanks! If accepted, this KEP may be able to have an alpha implement in 1.30.

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jan 30, 2024

Didn't get lead-opted-in. Giving up.

Alternative:

@AkihiroSuda AkihiroSuda closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
@AkihiroSuda
Copy link
Member Author

Reopening

#3858 (comment)

@mrunalp
Copy link
Contributor

mrunalp commented Feb 5, 2024

/milestone 1.30
/stage alpha
/label lead-opted-in

@k8s-ci-robot
Copy link
Contributor

@mrunalp: The provided milestone is not valid for this repository. Milestones in this repository: [v1.25, v1.27, v1.28, v1.29, v1.30, v1.31]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.30
/stage alpha
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 5, 2024
@mrunalp
Copy link
Contributor

mrunalp commented Feb 5, 2024

/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 5, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 5, 2024
@johnbelamaric johnbelamaric self-assigned this Feb 6, 2024
@pnbrown
Copy link

pnbrown commented Feb 7, 2024

Hello @AkihiroSuda 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • The production readiness review should be completed. One question appears unanswered.
  • Make sure the PR with the information get merged before enhancement freeze, I just found this PR.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@AkihiroSuda
Copy link
Member Author

KEP readme using the latest template has been merged into the k/enhancements repo.

Updated to the latest template

The production readiness review should be completed. One question appears unanswered.

Answered.

@pnbrown
Copy link

pnbrown commented Feb 7, 2024

Thank you. I will move it from At Risk when the PR gets merged.

@pnbrown
Copy link

pnbrown commented Feb 9, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@Checksumz
Copy link

Hi @AkihiroSuda ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@Vyom-Yadav
Copy link
Member

Hello @AkihiroSuda @johnbelamaric 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

Reading the KEP, this requires a good amount of documentation, marking this as Need Docs. Thanks!

@AkihiroSuda
Copy link
Member Author

docs

Here:

@AkihiroSuda
Copy link
Member Author

To opt in, you need to open a Feature Blog placeholder PR against the website repository. The placeholder PR deadline is 27th February, 2024. Here's the 1.30 Release Calendar

Opened a placeholder PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Tracked for Enhancements Freeze
Development

No branches or pull requests

10 participants