Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the KEP template better clarify the difference of integration vs. e2e tests #3860

Closed
SergeyKanzhelev opened this issue Feb 8, 2023 · 1 comment · Fixed by #3907
Closed

In the KEP template better clarify the difference of integration vs. e2e tests #3860

SergeyKanzhelev opened this issue Feb 8, 2023 · 1 comment · Fixed by #3907
Assignees
@deads2k
Labels
area/enhancements Issues or PRs related to the Enhancements subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.

Comments

@SergeyKanzhelev
Copy link
Member

As discussed today a SIG Arch: Production Readiness Office Hours the sections Integration tests and e2e tests are often confused - same text placed in both or one of the sections got ignored.

Integration tests are likely referring to the tests under the folder test/integration in k/k. This would be great to clarify it in PRR template.

/kind cleanup
/assign @deads2k
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 8, 2023
@kikisdeliveryservice kikisdeliveryservice added the sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 16, 2023
@kikisdeliveryservice kikisdeliveryservice added the area/enhancements Issues or PRs related to the Enhancements subproject label Feb 16, 2023
Closed
@kikisdeliveryservice
Copy link
Member

There was a similar bug open here. Tracking integration test issues via this bug for clarity.

cc: @MikeSpreitzer

@deads2k deads2k mentioned this issue Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deads2k deads2k

Labels
area/enhancements Issues or PRs related to the Enhancements subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3860: add explanation of integration tests deads2k/enhancements
4 participants
@kikisdeliveryservice @deads2k @SergeyKanzhelev @k8s-ci-robot