Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple TaintManager from NodeLifecycleController #3902

Open
6 of 10 tasks
yuanchen8911 opened this issue Mar 7, 2023 · 70 comments
Open
6 of 10 tasks

Decouple TaintManager from NodeLifecycleController #3902

yuanchen8911 opened this issue Mar 7, 2023 · 70 comments
Assignees
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@yuanchen8911
Copy link
Member

yuanchen8911 commented Mar 7, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 7, 2023
@yuanchen8911
Copy link
Member Author

yuanchen8911 commented Mar 7, 2023

/sig apps node scheduling

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 7, 2023
@yuanchen8911 yuanchen8911 changed the title KEP: Decouple taint-manager from NodeLifecycleController Decouple taint-manager from NodeLifecycleController Mar 7, 2023
@yuanchen8911
Copy link
Member Author

@yuanchen8911
Copy link
Member Author

/cc @atiratree @Huang-Wei

@SergeyKanzhelev
Copy link
Member

It was discussed at SIG Node meeting: https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit#bookmark=id.vecoal31xqar Let's track it for 1.28 to get more feedback on this as per comments at the meeting.

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 5, 2023
@yuanchen8911 yuanchen8911 changed the title Decouple taint-manager from NodeLifecycleController Decouple TaintManager from NodeLifecycleController May 24, 2023
@alculquicondor
Copy link
Member

/lead-opted-in

@alculquicondor
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 31, 2023
@salehsedghpour
Copy link

salehsedghpour commented Jun 3, 2023

Hello @yuanchen8911 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage beta for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Address questions inside the Production Readiness Review Questionnaire.
  • Ensure that the PRs are merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@yuanchen8911 yuanchen8911 changed the title Decouple TaintManager from NodeLifecycleController KEP-3902: Decouple TaintManager from NodeLifecycleController Jun 3, 2023
@yuanchen8911 yuanchen8911 changed the title KEP-3902: Decouple TaintManager from NodeLifecycleController Decouple TaintManager from NodeLifecycleController Jun 3, 2023
@yuanchen8911
Copy link
Member Author

Hello @yuanchen8911 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Address questions inside the Production Readiness Review Questionnaire.
  • Ensure that the PRs are merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Thanks for checking in. The status was updated. The proposal has been reviewed extensively and is pending for final approvals. /cc @Huang-Wei @alculquicondor

@yuanchen8911
Copy link
Member Author

/assign @yuanchen8911

@k8s-ci-robot
Copy link
Contributor

@yuanchen8911: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member

/milestone 1.28

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Huang-Wei
Copy link
Member

@yuanchen8911 it's tagged as milestone 1.28 already. You're good to go.

@yuanchen8911
Copy link
Member Author

@yuanchen8911 it's tagged as milestone 1.28 already. You're good to go.

Thanks, Wei. The KEP PR will need to be approved and merged by the deadline, won't it?

KEP readme using the latest template has been merged into the k/enhancements repo.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2024
@carlory
Copy link
Member

carlory commented Aug 17, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2024
@kannon92 kannon92 moved this from Triage to Not for release in SIG Node 1.32 KEPs planning Aug 24, 2024
@kannon92
Copy link
Contributor

Reading this, I'm not sure this needs to be in tracked sig-node KEPs for 1.32. If you need reviewers from sig-node, please let us know!

@alculquicondor
Copy link
Member

There is an open PR #4392

@yuanchen8911, can you update the description?

@carlory
Copy link
Member

carlory commented Sep 13, 2024

@alculquicondor Can you give me a lead-opted-in label?

@alculquicondor
Copy link
Member

/lead-opted-in

@alculquicondor
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 18, 2024
@soltysh
Copy link
Contributor

soltysh commented Sep 19, 2024

/milestone v1.32
/stage stable

@k8s-ci-robot k8s-ci-robot removed the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 19, 2024
@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Sep 19, 2024
@dipesh-rawat
Copy link
Member

Hello @yuanchen8911 @carlory 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • Update kep.yaml to mention latest-milestone: v1.32 and stable: "v1.32"
  • Complete the PRR review process for stable stage and merge it into k/enhancements.

It looks like #4392 will address most of these issues.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat dipesh-rawat moved this to At risk for enhancements freeze in 1.32 Enhancements Tracking Sep 25, 2024
@dipesh-rawat
Copy link
Member

Hi @yuanchen8911 @carlory 👋, v1.32 Enhancements team here.

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment #3902 (comment) that still need to be completed.

It looks like PR #4392 will address most of these issues. The PR #4392 needs to be merged before the enhancements freeze.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@tjons
Copy link
Contributor

tjons commented Oct 11, 2024

Hello 👋, v1.32 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in 1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

@tjons
Copy link
Contributor

tjons commented Oct 11, 2024

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.32 milestone Oct 11, 2024
@tjons tjons moved this from At risk for enhancements freeze to Removed from Milestone in 1.32 Enhancements Tracking Oct 11, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2025
@carlory
Copy link
Member

carlory commented Jan 10, 2025

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2025
@dipesh-rawat
Copy link
Member

Hello 👋, 1.33 Enhancements Lead here.

If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.33 using /milestone v1.33.
Thanks!

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Removed from Milestone
Status: Tracked for Code Freeze
Status: Removed from Milestone
Status: In Progress
Status: In Progress
Status: Removed from Milestone
Status: Sig Node Consulting
Development

No branches or pull requests