Decouple TaintManager from NodeLifecycleController

[yuanchen8911]

Enhancement Description

• One-line enhancement description (can be used as a release note): Decouple taint-manager from NodeLifecycleController
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/3902-decoupled-taint-manager/README.md
• Discussion Link: Decouple Taint-based Pod Eviction from Node LifeCycle Controller  kubernetes#115779
• Primary contact (assignee): @yuanchen8911
• Responsible SIGs: sig-scheduling
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): Since there are no new API changes, we can skip Alpha and go to Beta directly.
  • Beta release target (x.y): 1.29
  • Stable release target (x.y): 1.30
• Beta
  • KEP (k/enhancements) update PR(s): KEP-3902: Decouple TaintManager from NodeLifeCycleController #3901
  • Code (k/k) update PR(s): Decouple TaintManager from NodeLifeCycleController (KEP-3902) kubernetes#119208
  • Docs (k/website) update(s):
    • [WIP] Docs for Decoupled TaintManager from NodeLifeCycleController (KEP-3902) website#41970
    • Docs for Decoupled TaintManager from NodeLifeCycleController (KEP-3902) website#43555
    • Blog: Add a blog post about decoupled taint eviction controller website#43676

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[yuanchen8911]

/sig apps node scheduling

[yuanchen8911]

/cc @ddebroy @atosatto @ravisantoshgudimetla

[yuanchen8911]

/cc @atiratree @Huang-Wei

[SergeyKanzhelev]

It was discussed at SIG Node meeting: https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit#bookmark=id.vecoal31xqar Let's track it for 1.28 to get more feedback on this as per comments at the meeting.

/milestone v1.28

[alculquicondor]

/lead-opted-in

[alculquicondor]

/label lead-opted-in

[salehsedghpour]

Hello @yuanchen8911 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage beta for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Address questions inside the Production Readiness Review Questionnaire.
• Ensure that the PRs are merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[yuanchen8911]

Hello @yuanchen8911 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Address questions inside the Production Readiness Review Questionnaire.
• Ensure that the PRs are merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Thanks for checking in. The status was updated. The proposal has been reviewed extensively and is pending for final approvals. /cc @Huang-Wei @alculquicondor

[yuanchen8911]

/assign @yuanchen8911

[k8s-ci-robot]

@yuanchen8911: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alculquicondor]

/milestone 1.28

[k8s-ci-robot]

@alculquicondor: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Huang-Wei]

@yuanchen8911 it's tagged as milestone 1.28 already. You're good to go.

[yuanchen8911]

@yuanchen8911 it's tagged as milestone 1.28 already. You're good to go.

Thanks, Wei. The KEP PR will need to be approved and merged by the deadline, won't it?

KEP readme using the latest template has been merged into the k/enhancements repo.

[yuanchen8911]

Hello @yuanchen8911 👋, Enhancements team here.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)
Hi @salehsedghpour, a correction, the enhancement is targeting for stage beta for 1.28.

[Atharva-Shinde]

Hi @salehsedghpour, a correction, the enhancement is targeting for stage beta for 1.28.

/stage beta

[Rishit-dagli]

Hello @yuanchen8911 👋, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[yuanchen8911]

Hello @yuanchen8911 👋, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Thanks, we'll take a look.
/cc @atosatto

[atosatto]

@Rishit-dagli just to confirm that we have opened a placeholder PR with the doc updates for this feature - kubernetes/website#41970

[salehsedghpour]

Hey again @yuanchen8911 👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .
Here’s the enhancement’s state for the upcoming code freeze:

• All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
• All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.
  For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :
  • Decouple TaintManager from NodeLifeCycleController (KEP-3902) kubernetes#119208

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[Atharva-Shinde]

Hello @yuanchen8911 👋, 1.28 Enhancements Lead here.

Unfortunately, the implementation (code related) PR associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.28 milestone.

If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks!

/milestone clear

[yuanchen8911]

Hello @yuanchen8911 👋, 1.28 Enhancements Lead here.

Unfortunately, the implementation (code related) PR associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.28 milestone.

If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks!

/milestone clear

Thanks, the PR review has been deployed due to the unavailability of a reviewer. Unfortunately, it won't make the 1.28 release.
/cc @atosatto @Huang-Wei

[soltysh]

This slipped 1.28, but we're pushing this through in 1.29 updating milestone accordingly.

/milestone v1.29

[npolshakova]

Hello @yuanchen8911 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as tracked for enhancement freeze 🚀 . Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[yuanchen8911]

Hello @yuanchen8911 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as tracked for enhancement freeze 🚀 . Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Apologize for the the late reply. Yes, it's on track for 1.29 and the PR has been reviewed and ready to merge. kubernetes/kubernetes#119208. Thanks!
/cc @atosatto @Huang-Wei

[drewhagen]

Hello @yuanchen8911 👋, v1.29 Docs Shadow here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[drewhagen]

Hi @yuanchen8911 ! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Can you confirm this is the placeholder PR here? kubernetes/website#41970

Thank you! :)

[yuanchen8911]

Hi Drew, sorry for the late reply. Yes, this is the placeholder we had before. @atosatto, can you confirm it?

[yuanchen8911]

Hi @drewhagen, here is the updated placeholder PR for k/website: kubernetes/website#43555? Thank you! /cc @atosatto

[a-mccarthy]

Hi @yuanchen8911, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

[yuanchen8911]

Hi @yuanchen8911, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

Thanks, we've filed a PR for document update kubernetes/website#43555. Do we need another for a blog? /cc @atosatto

[a-mccarthy]

@yuanchen8911, correct. If you plan to write up a blog, please open a separate placeholder PR for that.

[yuanchen8911]

@yuanchen8911, correct. If you plan to write up a blog, please open a separate placeholder PR for that.

Thanks, will do it.

[npolshakova]

Hey again @yuanchen8911👋 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• Decouple TaintManager from NodeLifeCycleController (KEP-3902) kubernetes#119208

This KEP is currently marked as at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[yuanchen8911]

Thanks, the PR is almost ready to be merged. I'll update the status once it's merged.

[yuanchen8911]

Hi @yuanchen8911, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

Here's the blog PR (placeholder). kubernetes/website#43676
/cc @atosatto

[npolshakova]

Hey again @yuanchen8911, 1.29 Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

[yuanchen8911]

Thank you!