Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple TaintManager from NodeLifecycleController #3902

Open
6 tasks done
yuanchen8911 opened this issue Mar 7, 2023 · 55 comments
Open
6 tasks done

Decouple TaintManager from NodeLifecycleController #3902

yuanchen8911 opened this issue Mar 7, 2023 · 55 comments
Assignees
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@yuanchen8911
Copy link
Member

yuanchen8911 commented Mar 7, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 7, 2023
@yuanchen8911
Copy link
Member Author

yuanchen8911 commented Mar 7, 2023

/sig apps node scheduling

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 7, 2023
@yuanchen8911 yuanchen8911 changed the title KEP: Decouple taint-manager from NodeLifecycleController Decouple taint-manager from NodeLifecycleController Mar 7, 2023
@yuanchen8911
Copy link
Member Author

@yuanchen8911
Copy link
Member Author

/cc @atiratree @Huang-Wei

@SergeyKanzhelev
Copy link
Member

It was discussed at SIG Node meeting: https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit#bookmark=id.vecoal31xqar Let's track it for 1.28 to get more feedback on this as per comments at the meeting.

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 5, 2023
@yuanchen8911 yuanchen8911 changed the title Decouple taint-manager from NodeLifecycleController Decouple TaintManager from NodeLifecycleController May 24, 2023
@alculquicondor
Copy link
Member

/lead-opted-in

@alculquicondor
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 31, 2023
@salehsedghpour
Copy link
Contributor

salehsedghpour commented Jun 3, 2023

Hello @yuanchen8911 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage beta for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Address questions inside the Production Readiness Review Questionnaire.
  • Ensure that the PRs are merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@yuanchen8911 yuanchen8911 changed the title Decouple TaintManager from NodeLifecycleController KEP-3902: Decouple TaintManager from NodeLifecycleController Jun 3, 2023
@yuanchen8911 yuanchen8911 changed the title KEP-3902: Decouple TaintManager from NodeLifecycleController Decouple TaintManager from NodeLifecycleController Jun 3, 2023
@yuanchen8911
Copy link
Member Author

Hello @yuanchen8911 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Address questions inside the Production Readiness Review Questionnaire.
  • Ensure that the PRs are merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

Thanks for checking in. The status was updated. The proposal has been reviewed extensively and is pending for final approvals. /cc @Huang-Wei @alculquicondor

@yuanchen8911
Copy link
Member Author

/assign @yuanchen8911

@k8s-ci-robot
Copy link
Contributor

@yuanchen8911: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alculquicondor
Copy link
Member

/milestone 1.28

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Huang-Wei
Copy link
Member

@yuanchen8911 it's tagged as milestone 1.28 already. You're good to go.

@yuanchen8911
Copy link
Member Author

@yuanchen8911 it's tagged as milestone 1.28 already. You're good to go.

Thanks, Wei. The KEP PR will need to be approved and merged by the deadline, won't it?

KEP readme using the latest template has been merged into the k/enhancements repo.

@yuanchen8911
Copy link
Member Author

Hello @yuanchen8911 👋, Enhancements team here.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)
Hi @salehsedghpour, a correction, the enhancement is targeting for stage beta for 1.28.

@Atharva-Shinde
Copy link
Contributor

Hi @salehsedghpour, a correction, the enhancement is targeting for stage beta for 1.28.

/stage beta

@yuanchen8911
Copy link
Member Author

Hi @yuanchen8911, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository. The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

Here's the blog PR (placeholder). kubernetes/website#43676
/cc @atosatto

@npolshakova
Copy link

Hey again @yuanchen8911, 1.29 Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description, this enhancement is now marked as tracked for code freeze for the 1.29 Code Freeze! 🚀

@yuanchen8911
Copy link
Member Author

Thank you!

@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@carlory
Copy link
Member

carlory commented Feb 4, 2024

Hi @alculquicondor I raise a pr to promote it to stable in 1.30. can you give a lead-opted-in label in this issue?

@alculquicondor
Copy link
Member

/label lead-opted-in

@alculquicondor
Copy link
Member

/remove-label lead-opted-in

Actually, we recommend at least 2 releases in beta before graduation.

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Those labels are not set on the issue: lead-opted-in

In response to this:

/remove-label lead-opted-in

Actually, we recommend at least 2 releases in beta before graduation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 5, 2024
@salehsedghpour
Copy link
Contributor

/remove-label lead-opted-in

Actually, we recommend at least 2 releases in beta before graduation.

Hello @alculquicondor, with your previous message, I assume that I should remove this enhancement from this release. Right?

@alculquicondor
Copy link
Member

Yes
/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Feb 6, 2024
@salehsedghpour
Copy link
Contributor

/milestone clear

@carlory
Copy link
Member

carlory commented Apr 19, 2024

Hi @yuanchen8911 This feature is not GA now. Why it is closed as completed?

@alculquicondor
Copy link
Member

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Apr 19, 2024
@k8s-ci-robot
Copy link
Contributor

@alculquicondor: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuanchen8911
Copy link
Member Author

Sorry about the mistake. Thanks, @carlory @alculquicondor !

@mouuii
Copy link

mouuii commented May 17, 2024

@yuanchen8911
Copy link
Member Author

@atosatto
Copy link
Contributor

Why the featureGate enabled line has an "!" ? could you explain to me ,thanks? @yuanchen8911
https://github.com/kubernetes/kubernetes/pull/119208/files#diff-62d886bf35c4945f56ff8cfd3d60e9f47a0deb8f6b3d09d89f48aacf3ba7b70eR416

That is to fall back to the old logic which is running TaintManager as part of NodeLifecycleController. TaintManager has been moved to a separated controller with this change: https://github.com/kubernetes/kubernetes/pull/119208/files#diff-d8678e6e5a66a509c8262ae17a3fa9753da3a8d3c8934d3993f4621514d14d46R77

@mouuii
Copy link

mouuii commented May 19, 2024

Why the featureGate enabled line has an "!" ? could you explain to me ,thanks? 为什么启用 featureGate 的行有一个“!” ?你能给我解释一下吗,谢谢?@yuanchen8911
https://github.com/kubernetes/kubernetes/pull/119208/files#diff-62d886bf35c4945f56ff8cfd3d60e9f47a0deb8f6b3d09d89f48aacf3ba7b70eR416

That is to fall back to the old logic which is running TaintManager as part of NodeLifecycleController. TaintManager has been moved to a separated controller with this change: https://github.com/kubernetes/kubernetes/pull/119208/files#diff-d8678e6e5a66a509c8262ae17a3fa9753da3a8d3c8934d3993f4621514d14d46R77也就是说,回到旧的逻辑,将 TaintManager 作为 NodeLifecycleController 的一部分运行。通过此更改,TaintManager 已移至单独的控制器:https://github.com/kubernetes/kubernetes/pull/119208/files#diff-d8678e6e5a66a509c8262ae17a3fa9753da3a8d3c8934d3993f4621514d14d46R77

ok,thank you very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Removed from Milestone
Status: Tracked for Code Freeze
Status: Removed from Milestone
Status: In Progress
Status: In Progress
Development

No branches or pull requests