Handling undecryptable resources

[stlaz]

Handling undecryptable resources

• One-line enhancement description (can be used as a release note): Improve the identification of resources that won't decrypt. Make it possible to remove undecryptable resources by using the API.
• Kubernetes Enhancement Proposal: link
• Discussion Link: sig-auth meeting, 01.03.2023 - 40:41
• Primary contact (assignee): @stlaz
• Responsible SIGs: sig-auth, sig-api-machinery
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.32
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-3926: handling undecryptable resources #3927
  • Code (k/k) update PR(s):
    • 1.32:
      • KEP-3926: refactor: extract etcd3 store decode functions into an interface kubernetes#127982
      • KEP-3926: storage.InternalError should retain the inner error kubernetes#127984
      • KEP-3926: refactor: add delete options for Delete method in storage interface kubernetes#127777
      • KEP-3926: refactor: etcd store conditional delete kubernetes#127778
      • KEP-3926: unsafe deletion of corrupt objects kubernetes#127513
      • KEP-3926: add a new type to represent a corrupt object in storage error kubernetes#128056
      • KEP-3926: refactor: extend newTransformTest to enable RBAC kubernetes#128191
    • 1.33:
      • KEP-3926: skip admission validation for unsafe delete kubernetes#130595
      • KEP-3926: test the delete handler with unsafe deletion flow kubernetes#128726
      • KEP-3926: Add a test to verify list error aggregation kubernetes#129129
  • Docs (k/website) update PR(s):
    • add doc for new delete option ignoreStoreReadErrorWithClusterBreakingPotential website#48463

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[stlaz]

/sig auth
/sig api
/assign

[k8s-ci-robot]

@stlaz: The label(s) sig/api cannot be applied, because the repository doesn't have them.

In response to this:

/sig auth
/sig api
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stlaz]

/sig api-machinery

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[stlaz]

/remove-lifecycle stale

[sanchita-07]

Hello @stlaz 👋, 1.29 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.29. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would need to add/update the following:

• The status should be marked as implementable in the kep.yaml file.
• Ensure the KEP readme using the latest template has been merged into the k/enhancements repo
• Ensure that the PR including the production readiness review has been merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.
Thank you!

[sanchita-07]

Hi @stlaz , checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze. It looks like #3927 will address the requirements. Let me know if I missed anything. Thanks!

[stlaz]

Hello 👋
Indeed, #3927 should indeed address the requirements. I'm trying to move it forward but it's not yet clear if it'll make it in time.

[npolshakova]

With KEP PR #3927 approved, the enhancement is ready for the enhancements freeze. The status is now marked as tracked for enhancement freeze for 1.29. 🚀 Thank you!

[katcosgrove]

Hey there @stlaz! 👋, v1.29 Docs Lead here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[katcosgrove]

Hi again @stlaz ! The deadline to open a placeholder PR against k/website for required documentation is this Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

[stlaz]

Hello,
Sorry for late reply. Unfortunately, due to external circumstances, we won't be able to deliver the work for the 1.29 milestone 😞

[tkashem]

other refactor PRs that have already merged:

• KEP-3926: refactor: extract etcd3 store decode functions into an interface kubernetes#127982
• KEP-3926: storage.InternalError should retain the inner error kubernetes#127984
• KEP-3926: refactor: add delete options for Delete method in storage interface kubernetes#127777
• KEP-3926: refactor: etcd store conditional delete kubernetes#127778

[tjons]

Hello @stlaz 👋 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.32 milestone.

If you still wish to progress this enhancement in 1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

[tkashem]

@tjons the implementation pr kubernetes/kubernetes#127513 merged in time.

kubernetes/kubernetes#128056 and kubernetes/kubernetes#128191 were closed since they were included in #127513

[pacoxu]

/milestone v1.32

[spurin]

Based on the thread, I’ve moved this back to "Tracked for Code Freeze" in the tracker. However, I’m uncertain if this aligns with the intended approach for this task. cc: @tjons

[tkashem]

the doc PR: kubernetes/website#48463 is ready for review

[tkashem]

Adding more tests:

• KEP-3926: Add a test to verify list error aggregation kubernetes#129129
• KEP-3926: test the delete handler with unsafe deletion flow kubernetes#128726

[dipesh-rawat]

Hello 👋, 1.33 Enhancements Lead here.

I’m closing milestone 1.32 now. If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.33 using /milestone v1.33.
Thanks!

/remove-label lead-opted-in
/milestone clear

[lzung]

Hello @stlaz @tkashem 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)
/stage alpha

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.33.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

• Please update KEP status for milestone v1.33

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[tkashem]

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)

Hi @lzung, we achieved ALPHA in 1.32

[tkashem]

KEP status is marked as implementable for latest-milestone: v1.33.

Hi @lzung, latest-milestone is set to v1.33 #5143

[lzung]

Hello @tkashem 👋,

Now that PR #5143 has been merged, all the KEP requirements are in place and merged into k/enhancements. This enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Thank you!

[rytswd]

Hi @stlaz @tkashem 👋 -- this is Ryota (@rytswd) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

• This introduces some breaking change(s)
• This has significant impacts and/or implications to users
• ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
• Monday, 7th April, 2025: Feature blogs ready for review
• You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[sn3hay]

Hi @stlaz @tkashem 👋, 1.33 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. To opt in, please let us know and open a Feature Blog placeholder PR against [k/website](https://github.com/kubernetes/website) by the deadline. If you have any questions, please feel free to reach out to us!

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
• Monday, 7th April, 2025: Feature blogs ready for review
• You can find more in the [release document](https://github.com/kubernetes/sig-release/tree/master/releases/release-1.33#timeline)

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[lzung]

Hey again @stlaz @tkashem 👋, 1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With all the implementation (code related) PRs merged as per the issue description:

• KEP-3926: refactor: extract etcd3 store decode functions into an interface kubernetes#127982
• KEP-3926: storage.InternalError should retain the inner error kubernetes#127984
• KEP-3926: refactor: add delete options for Delete method in storage interface kubernetes#127777
• KEP-3926: refactor: etcd store conditional delete kubernetes#127778
• KEP-3926: unsafe deletion of corrupt objects kubernetes#127513

Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

This enhancement is now marked as tracked for code freeze for the 1.33 Code Freeze!

[tkashem]

Hi @lzung, we have these following PRs:

• KEP-3926: skip admission validation for unsafe delete kubernetes#130595
• KEP-3926: test the delete handler with unsafe deletion flow kubernetes#128726
• KEP-3926: Add a test to verify list error aggregation kubernetes#129129