Introducing Sleep Action for PreStop Hook

[AxeZhan]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add Sleep Action for PreStop Hook
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/3960-pod-lifecycle-sleep-action/
• Discussion Link:
  • related issue
  • google doc
• Primary contact (assignee): @AxeZhan @charles-chenzz
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.29
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-3960: Introducing Sleep Action for PreStop Hook #3961
  • Code (k/k) update PR(s): Introducing Sleep Action for PreStop Hook kubernetes#119026
  • Docs (k/website) update PR(s):Add information about PodLifecycleSleepAction (KEP3960) website#43428
• Beta
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[AxeZhan]

/sig node

[AxeZhan]

/cc @thockin

[SergeyKanzhelev]

/milestone v1.28

adding to the milestone for tracking

[Atharva-Shinde]

Hello @AxeZhan 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on Thursday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

• Add approver/s to prod-readiness yaml file
• Change the status of the KEP to implementable
• Get approval from the PRR authors

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[Atharva-Shinde]

/stage alpha

[Atharva-Shinde]

Hey @AxeZhan,
We would just need to update the status inside kep.yaml to implementable instead of provisional as mentioned in my comment above. Please make the change within 24 hours else you would have to file an exception request.
Thanks :)

[SergeyKanzhelev]

this should be updated now. Since there were no material change, can we get it tracked for 1.28?

[Atharva-Shinde]

With all the KEP requirements in place and merged into k/enhancements, the status of this enhancement is now marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[AdminTurnedDevOps]

Hey @AxeZhan

1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[charles-chenzz]

hi @AdminTurnedDevOps , we currently working on the implement in k/k repos, when we finish it, we will start to add docs. Thanks.

[AxeZhan]

Hey @AdminTurnedDevOps
Thank you for your remind!

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

This definitely needs some new docs :)
I've created a draft pr for place holder, and have updated the link in the Description above, we'll get back to finish the detail after the code changes are done.
We are not very familiar with updating the documentation, so we may need some assistance from your team when the time comes. Thank you in advance!

[AxeZhan]

Hi all, I've created kubernetes/kubernetes#119026 for some discussion(because I'm not certain of some implementations/e2e tests), I'd be super glad if some of you can have a look and give me a help😊。

[Atharva-Shinde]

Hey again @AxeZhan 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

• All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
• All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :

• Introducing Sleep Action for PreStop Hook kubernetes#119026

This is the code related PR/s that I found on this KEP issue

• Introducing Sleep Action for PreStop Hook kubernetes#119026

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

[Atharva-Shinde]

Hello @AxeZhan 👋, 1.28 Enhancements Lead here.

Unfortunately, the implementation (code related) PR associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.28 milestone.

If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks!

/milestone clear

[AxeZhan]

@thockin Should we postpone this one?

[thockin]

Sorry, I was out today - I swear I approved this, did nobody from node give final review? I don't think this is "urgent", so no exception is warranted, IMO.

…

On Tue, Jul 18, 2023, 9:33 PM Sheng Zhan ***@***.***> wrote: @thockin <https://github.com/thockin> Should we postpone this one? — Reply to this email directly, view it on GitHub <#3960 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKWAVEYB5PVPWCRRLIUDDLXQ5PRTANCNFSM6AAAAAAXHWZB7U> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[AxeZhan]

did nobody from node give final review?

Yes 😂. Guess we'll postpone this to 1.29 now.

[pacoxu]

The PR seems in healthy progress and we hopefully can see this feature in v1.29. Would you update the KEP for the version?

[AxeZhan]

The PR seems in healthy progress and we hopefully can see this feature in v1.29. Would you update the KEP for the version?

created #4182

[gjkim42]

/cc

[SergeyKanzhelev]

/milestone v1.29

[salehsedghpour]

Hello @AxeZhan 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage alpha for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.29.
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[drewhagen]

Hello @AxeZhan 👋, v1.29 Docs Shadow here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[drewhagen]

Hi @AxeZhan! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement?

Is this is the correct placeholder PR? kubernetes/website#43428

Let me know, thank you!

[AxeZhan]

Hi @AxeZhan! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement?

@drewhagen Sry... I opened the pr for k/website before and I forgot to update the description in this pr. Updated.

Is this is the correct placeholder PR? kubernetes/website#43428

Yes!

[salehsedghpour]

Hey again @AxeZhan 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With all this, the status of this KEP is now tracked for the code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[AxeZhan]

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks!

@salehsedghpour There's no other PRs for this kep in this release cycle. Thanks!

[a-mccarthy]

Hi @AxeZhan, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar