New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing Sleep Action for PreStop Hook #3960
Comments
/sig node |
/cc @thockin |
/milestone v1.28 adding to the milestone for tracking |
Hello @AxeZhan 👋, Enhancements team here. Just checking in as we approach Enhancements freeze on Thursday, 16th June 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would need to update the following:
The status of this enhancement is marked as |
/stage alpha |
Hey @AxeZhan, |
this should be updated now. Since there were no material change, can we get it tracked for 1.28? |
With all the KEP requirements in place and merged into k/enhancements, the status of this enhancement is now marked as |
Hey @AxeZhan 1.28 Docs Shadow here. Does this enhancement work planned for 1.28 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you! |
hi @AdminTurnedDevOps , we currently working on the implement in k/k repos, when we finish it, we will start to add docs. Thanks. |
Hey @AdminTurnedDevOps
This definitely needs some new docs :) |
Hi all, I've created kubernetes/kubernetes#119026 for some discussion(because I'm not certain of some implementations/e2e tests), I'd be super glad if some of you can have a look and give me a help😊。 |
Hey again @AxeZhan 👋 Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 . Here’s the enhancement’s state for the upcoming code freeze:
For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences : This is the code related PR/s that I found on this KEP issue Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP. As always, we are here to help if any questions come up. Thanks! |
Hello @AxeZhan 👋, 1.28 Enhancements Lead here. Unfortunately, the implementation (code related) PR associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.28 milestone. If you still wish to progress this enhancement in v1.28, please file an exception request. Thanks! /milestone clear |
@thockin Should we postpone this one? |
Sorry, I was out today - I swear I approved this, did nobody from node give
final review?
I don't think this is "urgent", so no exception is warranted, IMO.
…On Tue, Jul 18, 2023, 9:33 PM Sheng Zhan ***@***.***> wrote:
@thockin <https://github.com/thockin> Should we postpone this one?
—
Reply to this email directly, view it on GitHub
<#3960 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKWAVEYB5PVPWCRRLIUDDLXQ5PRTANCNFSM6AAAAAAXHWZB7U>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes 😂. Guess we'll postpone this to 1.29 now. |
The PR seems in healthy progress and we hopefully can see this feature in v1.29. Would you update the KEP for the version? |
created #4182 |
/cc |
/milestone v1.29 |
Hello @AxeZhan 👋, Enhancements team here. Just checking in as we approach enhancements freeze on Friday, 6th October 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
The status of this enhancement is marked as |
Hello @AxeZhan 👋, v1.29 Docs Shadow here. |
Hi @AxeZhan! The deadline to open a placeholder PR against Is this is the correct placeholder PR? kubernetes/website#43428 Let me know, thank you! |
@drewhagen Sry... I opened the pr for k/website before and I forgot to update the description in this pr. Updated.
Yes! |
Hey again @AxeZhan 👋 Enhancements team here, Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November. Here's where this enhancement currently stands:
With all this, the status of this KEP is now Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. |
@salehsedghpour There's no other PRs for this kep in this release cycle. Thanks! |
Hi @AxeZhan, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release. If so, you need to open a PR placeholder in the website repository. |
Enhancement Description
k/enhancements
) update PR(s): KEP-3960: Introducing Sleep Action for PreStop Hook #3961k/k
) update PR(s): Introducing Sleep Action for PreStop Hook kubernetes#119026k/website
) update PR(s):Add information about PodLifecycleSleepAction (KEP3960) website#43428k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: