Consider Terminating Pods in Deployments

[kannon92]

Enhancement Description

• One-line enhancement description (can be used as a release note): For Deployment controllers we want to optionally include a way for users to include terminating pods in the active pod count.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/3973-consider-terminating-pods-deployment/README.md
• Discussion Link: Jobs create replacement Pods as soon as a Pod is marked for deletion kubernetes#115844
• Primary contact (assignee): @atiratree
• Responsible SIGs: sig-apps
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.31
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3973: Consider Terminating Pods in Deployments #4357
    • KEP-3973: Update PodReplacementPolicy for Deployments #4670
  • Code (k/k) update PR(s):
    • ignore replicaset-replicas-before-scale annotation in deployment rollbacks kubernetes#123670
    • add PodReplacementPolicy for Deployments kubernetes#123430
  • Docs (k/website) update PR(s):
    • [KEP-3973]: docs for DeploymentPodReplacementPolicy website#45266
    • [WIP] [KEP-3973]: feature blog for DeploymentPodReplacementPolicy website#45268

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[kannon92]

/sig apps

[atiratree]

@kannon92 can you please link a correct KEP in the description?

[dejanzele]

As discussed with @kannon92, I will be taking over this KEP.

/assign dejanzele

[atiratree]

@dejanzele I had a similar discussion with @kannon92 some time ago about this as well. And I have the KEP mostly written, just need to finish it..

[atiratree]

@kannon92 @dejanzele I have opened the new version of the KEP in #4357.

[kannon92]

/assign @atiratree

[atiratree]

/label lead-opted-in
/milestone v1.30
/stage alpha

[k8s-ci-robot]

@atiratree: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/label lead-opted-in
/milestone v1.30
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@atiratree: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in
/milestone v1.30
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[soltysh]

/label lead-opted-in
/milestone v1.30
/stage alpha

[meganwolf0]

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: { CURRENT_RELEASE }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• The KEP and PRR look good in the Pull Request, this is just a reminder to make sure they're all merged before enhancements freeze

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[meganwolf0]

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is still at risk for enhancement freeze. Please make sure you get all changes merged before the enhancement freeze deadline. Thank you!

[salehsedghpour]

With all the requirements fulfilled in #4357 this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

[celestehorgan]

Hello @kannon92 👋, 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[natalisucks]

Hi @atiratree and @dejanzele,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

[atiratree]

hi, I have opened placeholder PRs:

• feature: add PodReplacementPolicy for Deployments kubernetes#123430
• docs: [KEP-3973]: docs for DeploymentPodReplacementPolicy website#45266
• blog: [WIP] [KEP-3973]: feature blog for DeploymentPodReplacementPolicy website#45268

[meganwolf0]

Hey again @atiratree 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

• add PodReplacementPolicy for Deployments kubernetes#123430

With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[atiratree]

I have updated the kubernetes/kubernetes#123430 PR with an implementation, but I am still missing the tests, so we will not be able to merge this feature in 1.30 due to not enough time.

Even though it might be possible to finish this if we had enough review capacity, I would prefer not to for the following reasons:

• to allow proper review process to make sure we have not looked over something
• I have identified that we will need a new annotation deployment.kubernetes.io/replicaset-replicas-before-scale (please see ignore replicaset-replicas-before-scale annotation in deployment rollbacks kubernetes#123670) to support partial scalling of older revision replica sets for deployments with TerminationComplete podReplacementPolicy. It would be great if we could merge this now, to make sure N-1 kubectl works with cluster that turn on the DeploymentPodReplacementPolicy feature.

[meganwolf0]

Thank you @atiratree - In this case I will mark this enhancement Removed from Milestone

[kannon92]

updated links.

[atiratree]

In today's sig-apps call, we have decided to postpone the introduction of the annotation into 1.31 along with the alpha version of the feature. We will specifically document in the KEP/docs that this feature should be used with the latest kubectl. In the next release (1.32), the rollbacks should be backwards compatible.

[salehsedghpour]

/milestone clear

[sreeram-venkitesh]

Hi @atiratree 👋, 1.31 Enhancements Lead here.

If you wish to progress this enhancement in v1.31, please have the SIG lead opt-in your enhancement by adding the lead-opted-in label and set the milestone to v1.31 before the Production Readiness Review Freeze.

/remove-label lead-opted-in

[atiratree]

I would like to land this enhancement in 1.31.

KEP update: #4670

[soltysh]

/label lead-opted-in
/milestone v1.31

[ArkaSaha30]

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024..

This enhancement is targeting stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP before the enhancements freeze.

For this KEP, we would need to update the following:

• PR needs to be reviewed and merged within the mentioned timeline. It updates the latest-milestone to v1.31 along with updates to README.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[sreeram-venkitesh]

With #4670 merged, we can mark this KEP as tracked for enhancements freeze! 🎉

[edithturn]

Hello, @atiratree and @dejanzele!

👋 from the v1.31 Communications Team!

We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[atiratree]

@edithturn I have opened a placeholder PR for the blog post: kubernetes/website#45268

[edithturn]

@edithturn I have opened a placeholder PR for the blog post: kubernetes/website#45268

Thank you so much @atiratree , please te us know if you need any help! :)

[ArkaSaha30]

Hey again @atiratree 👋, Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Regarding this enhancement, it appears that there is currently 1 open PR in the k/k repository which is in draft state. The other PR listed in the description has been closed.

For this KEP, we would need to do the following:

• Ensure all PRs to the Kubernetes repo related to your enhancement are linked in the above issue description (for tracking purposes).
• Ensure the draft PR merge conflict is resolved and moved from draft state.
• Ensure all PRs are prepared for merging (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

[ArkaSaha30]

Hey again @SergeyKanzhelev 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach code freeze in about 2 days, at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

The current status of this enhancement is marked as at risk for code freeze. A few requirements mentioned in the comment #3973 (comment) still need to be completed. The following open PR as per the description still needs to be merged, PR mentioned in the description has been marked as closed:

• add PodReplacementPolicy for Deployments kubernetes#123430

If you anticipate missing code freeze, you can file an exception request in advance.

[sreeram-venkitesh]

Hello @atiratree 👋 v1.31 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.31 milestone.

If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

[sreeram-venkitesh]

We've received an exception request for this KEP: https://groups.google.com/g/kubernetes-sig-release/c/SLTNXQvnOtM