Consider Terminating Pods in Deployments

[kannon92]

Enhancement Description

• One-line enhancement description (can be used as a release note): For Deployment controllers we want to optionally include a way for users to include terminating pods in the active pod count.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-apps/3973-consider-terminating-pods-deployment/README.md
• Discussion Link: Jobs create replacement Pods as soon as a Pod is marked for deletion kubernetes#115844
• Primary contact (assignee): @atiratree
• Responsible SIGs: sig-apps
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.33
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s):
    • KEP-3973: Consider Terminating Pods in Deployments #4357
    • KEP-3973: Update PodReplacementPolicy for Deployments #4670
    • KEP-3973: Update PodReplacementPolicy alpha to 1.32 #4903
    • KEP-3973: Consider deployment completion in DeploymentPodReplacementPolicy #4976
  • Code (k/k) update PR(s):
    • 1.34 add PodReplacementPolicy for Deployments kubernetes#123430
    • 1.33 add PodReplacementPolicy for Deployments: terminating pods kubernetes#128546
  • Docs (k/website) update PR(s):
    • [KEP-3973]: document .status.terminatingReplicas enabled by DeploymentPodReplacementPolicy feature website#49896
    • [KEP-3973]: docs for DeploymentPodReplacementPolicy website#48370
    • [WIP] [KEP-3973]: feature blog for DeploymentPodReplacementPolicy website#45268

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[kannon92]

/sig apps

[atiratree]

@kannon92 can you please link a correct KEP in the description?

[dejanzele]

As discussed with @kannon92, I will be taking over this KEP.

/assign dejanzele

[atiratree]

@dejanzele I had a similar discussion with @kannon92 some time ago about this as well. And I have the KEP mostly written, just need to finish it..

[atiratree]

@kannon92 @dejanzele I have opened the new version of the KEP in #4357.

[kannon92]

/assign @atiratree

[atiratree]

/label lead-opted-in
/milestone v1.30
/stage alpha

[k8s-ci-robot]

@atiratree: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/label lead-opted-in
/milestone v1.30
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@atiratree: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/label lead-opted-in
/milestone v1.30
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[soltysh]

/label lead-opted-in
/milestone v1.30
/stage alpha

[meganwolf0]

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: { CURRENT_RELEASE }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

• The KEP and PRR look good in the Pull Request, this is just a reminder to make sure they're all merged before enhancements freeze

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[meganwolf0]

Hello @atiratree 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is still at risk for enhancement freeze. Please make sure you get all changes merged before the enhancement freeze deadline. Thank you!

[salehsedghpour]

With all the requirements fulfilled in #4357 this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

[celestehorgan]

Hello @kannon92 👋, 1.30 Docs Shadow here.
Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

[natalisucks]

Hi @atiratree and @dejanzele,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

[soltysh]

@kannon92 @tenzen-y @mimowo any plans to GA this feature in 1.33?
Wrong tab 🤦 - apologies to all three of you, you can safely ignore this comment 😉

[fykaa]

Hello @atiratree @dejanzele @kannon92 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)
/stage alpha

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v.133. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
• KEP readme has up-to-date graduation criteria.
• KEP has submitted a production readiness review request for approval and has a reviewer assigned.
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as Tracked for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[rayandas]

Hello @atiratree @dejanzele @kannon92 👋, v1.33 Docs Lead here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[atiratree]

hi @rayandas, I have opened the docs PR for 1.33: kubernetes/website#49896

[rayandas]

Thanks @atiratree

[fykaa]

Hey again @atiratree @kannon92 @dejanzele 👋, v1.33 Enhancements team here,

Just checking in as we approach Code Freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• add PodReplacementPolicy for Deployments kubernetes#123430

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

The status of this enhancement is marked as At risk for code freeze.

As always, we are here to help if any questions come up. Thanks!

[aakankshabhende]

Hi @atiratree 👋 -- this is Aakanksha (@aakankshabhende ) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

• This introduces some breaking change(s)
• This has significant impacts and/or implications to users
• ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
• Monday, 7th April, 2025: Feature blogs ready for review
• You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[aakankshabhende]

Hi @atiratree @kannon92 @dejanzele 👋 -- this is Aakanksha (@aakankshabhende ) from 1.33 Communications Team here again!

This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 5th March, 2025. To opt in, please let us know and open a Feature Blog placeholder PR against k/website by the deadline. If you have any questions, please feel free to reach out to us!

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
• Monday, 7th April, 2025: Feature blogs ready for review
• You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[atiratree]

@aakankshabhende sorry for the delay. The placeholder PR is already opened kubernetes/website#45268

[dipesh-rawat]

Hi @atiratree 👋, v1.33 Enhancements team here,

Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment #3973 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

[dipesh-rawat]

Hello @atiratree 👋, v1.33 Enhancements team here,

Unfortunately, the implementation (code-related) PRs associated with this enhancement are not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.33 milestone.

If you still wish to progress this enhancement in v1.33, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

/milestone clear

[atiratree]

Hi @dipesh-rawat, we have merged a smaller part of the enhacement kubernetes/kubernetes#128546 which has user visible changes. However, the main part kubernetes/kubernetes#123430 has not been merged yet.

[atiratree]

I have opened a kubernetes/website#49896 PR to document the terminating replicas change in 1.33.

[dipesh-rawat]

@atiratree Thanks for reaching out! It’s interesting that part of the KEP implementation, which is user visible, has already been merged. Since the partially implemented functionality isn’t breaking any tests and appears low-risk as its opt-in alpha feature, I’m inclined to leave it in and document the current state - which I see you’ve already started as part of docs PR kubernetes/website#49896 .

I’ll also get input from the v1.33 Release Lead (@npolshakova), but unless there are any major concerns, I’m fine with moving forward as is. If Release Team agrees, we can add it back to the milestone and mark it as tracked.

(cc: @npolshakova)

[npolshakova]

Hi @atiratree, since the user-visible changes have already merged I think it's fine to add it back to the milestone and document the current state in kubernetes/website#49896, and then have the KEP keep target alpha in the next release.

I'll add it back to the milestone and we can mark this as tracked. Please update the issue description to make it clear which code PRs will be tracked in 1.33

Thanks!

/milestone v1.33

[atiratree]

Thanks! Updated.