Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for a drop-in kubelet configuration directory #3983

Open
6 of 9 tasks
haircommander opened this issue May 4, 2023 · 37 comments
Open
6 of 9 tasks

Add support for a drop-in kubelet configuration directory #3983

haircommander opened this issue May 4, 2023 · 37 comments
Assignees
@sohankunkerkar
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status

Comments

@haircommander
Copy link
Contributor

haircommander commented May 4, 2023 •
edited by pacoxu

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 4, 2023
@haircommander
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 4, 2023
@SergeyKanzhelev
Copy link
Member

/milestone v1.28

Adding to the milestone for tracking based on discussions at sig node meeting.

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 5, 2023
@ffromani
Copy link
Contributor

ffromani commented May 9, 2023

+1!!! (non binding)
@haircommander I'd love to help here to get this in kubelet

@yuqi-zhang yuqi-zhang mentioned this issue May 24, 2023
Merged
@SergeyKanzhelev
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 6, 2023
@SergeyKanzhelev
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 8, 2023
@ruheenaansari34
Copy link

Hello @haircommander 👋, 1.28 Enhancements team here.

Just checking in as we approach enhancements freeze on 1:00 UTC on Friday 16th June 2023.

This enhancement is targeting stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to take care of:

  • Merging KEP update PR
  • The KEP number seems to be incorrect ie., should this be 3983 instead of 3893?

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@yuqi-zhang
Copy link
Contributor

Hi @ruheenaansari34 , I've updated the ID, thanks for pointing that out!

Is there anything else needed at the moment other than getting consensus to merge the enhancement?

@ruheenaansari34
Copy link

@yuqi-zhang Please take care of the following before the Enhancement freeze to meet the requirements:

The status of this enhancement is still marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@yuqi-zhang
Copy link
Contributor

Thanks! I've marked it as implementable after discussion with @haircommander . We will work to get it merged

@Atharva-Shinde
Copy link
Contributor

Thanks @yuqi-zhang :)
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀.
The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well.

@Rishit-dagli
Copy link
Member

Hello @haircommander 👋, 1.28 Docs Lead here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@Rishit-dagli
Copy link
Member

Hey @haircommander , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

@haircommander
Copy link
Contributor Author

yes I will take care of it, thanks @Rishit-dagli !

@haircommander
Copy link
Contributor Author

done! kubernetes/website#42013

@ruheenaansari34
Copy link

Hey again @haircommander 👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

@Atharva-Shinde
Copy link
Contributor

Hey @haircommander 👋 Enhancements Lead here,
With kubernetes/kubernetes#119390 merged as per the issue description I updated above, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@Rishit-dagli
Copy link
Member

Hello @haircommander wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: kubernetes/website#42013

@haircommander
Copy link
Contributor Author

thank you! I have moved it out of draft

@katcosgrove
Copy link

Hey y'all! I'm swinging by for the v1.28 Docs team. Today is the docs deadline. Is there anything we can help you with to get this merged?

@haircommander
Copy link
Contributor Author

sorry I am updating it now, I will get this done soon.

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@SergeyKanzhelev
Copy link
Member

/milestone v1.29
/stage beta
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.28, v1.29 Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Sep 15, 2023
@SergeyKanzhelev
Copy link
Member

@haircommander please send the PR to update KEP details for beta in 1.29

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 15, 2023
@neolit123 neolit123 mentioned this issue Sep 18, 2023
Open
5 tasks
@salehsedghpour
Copy link

Hello @haircommander 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Update the latest-milestone: 1.29 in the kep.yaml file
  • Update the Readme perhaps

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@sohankunkerkar sohankunkerkar mentioned this issue Sep 25, 2023
Merged
@kannon92
Copy link
Contributor

/assign @sohankunkerkar

@k8s-ci-robot
Copy link
Contributor

@kannon92: GitHub didn't allow me to assign the following users: sohankunkerkar.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sohankunkerkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sohankunkerkar
Copy link
Contributor

I'm working on this issue.

@kannon92
Copy link
Contributor

/assign @sohankunkerkar

@salehsedghpour
Copy link

Hi @haircommander @sohankunkerkar , checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. It looks like #4242 will address all of the requirements.

Let me know if I missed anything. Thanks!

Please keep the issue description up-to-date with appropriate information such that PR.

@salehsedghpour
Copy link

As #4242 is merged, the status of this enhancement is marked as tracked for enhancement freeze.

@drewhagen
Copy link
Member

drewhagen commented Oct 10, 2023 •
edited

Hello @haircommander @sohankunkerkar 👋, v1.29 Docs Shadow here.
Does this enhancement work planned for v1.29 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@sohankunkerkar sohankunkerkar mentioned this issue Oct 12, 2023
Merged
@drewhagen
Copy link
Member

Hi @haircommander @sohankunkerkar! The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@sohankunkerkar
Copy link
Contributor

@drewhagen Thanks for your patience. Here's the link for the placeholder PR: kubernetes/website#43542

@kcmartin
Copy link

Hi @sohankunkerkar @haircommander! 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here's the 1.29 Calendar

@salehsedghpour
Copy link

Hey again @sohankunkerkar @haircommander 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Please update the Issue description to include all the related PRs (including kubernetes/kubernetes#121193, I guess) of this KEP under beta section in the Github Issue description. The status for this KEP is currently at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@npolshakova
Copy link

Hello @sohankunkerkar @haircommander 👋 1.29 Enhancements lead here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone.

If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Nov 1, 2023
@npolshakova
Copy link

With kubernetes/kubernetes#121193 merged this is now marked as tracked for code freeze for 1.29! 🚀

@pacoxu pacoxu mentioned this issue Nov 9, 2023
Open
jpbetz added a commit to jpbetz/enhancements that referenced this issue Nov 22, 2023
@jpbetz
Request to be promoted to PRR approver
85bbe9f 
Shadow contributions:
- 1.27 shadow reviews: 6
- 1.28 shadow reviews: 9
- 1.29 - did not shadow due to time constraints with new SIG API Machinery TL role

Planned contributions:
- 1.30+ contribute to PRR, able to review roughly 12 KEPs per release.  I am happy to PRR more than 12 so long as they are SIG API Machinery KEPs, since I'll be reviewing those anyway..

Shadow reviewer promotion criteria:

Transitions from new to alpha

- kubernetes#3983
- kubernetes#3751

Transitions from alpha to beta

- kubernetes#3107
- kubernetes#2485

Transitions from beta to GA

- kubernetes#2268

Three enhancements that require coordination between multiple components.

- kubernetes#3751
- kubernetes#2485
- kubernetes#3107

Three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile.

- kubernetes#2268 (component skew)
- kubernetes#2485 (component skew)
- kubernetes#3751 (HA skew - feature gated fields, component skew)
kubernetes#2268 (HA skew of controller considered)

Three enhancements that are outside your primary domain.

- kubernetes#3983 (SIG Node)
- kubernetes#3751 (SIG Storage)
- kubernetes#2268 (SIG Node)
- kubernetes#3107 (SIG Storage)

Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking.

- Yes. E.g. kubernetes#2268 (ability to analyze cluster in aggregate considered, rescheduling considered)

Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.

- Yes. E.g. kubernetes#3751 (new API call, volume of calls considered)
@jpbetz jpbetz mentioned this issue Nov 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sohankunkerkar sohankunkerkar

Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
1.28 Enhancements Tracking
Status: Tracked
1.29 Enhancements Tracking
Status: Tracked for Code Freeze
Milestone
No milestone
Development

No branches or pull requests