Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD Validation Ratcheting #4008

Open
7 of 8 tasks
alexzielenski opened this issue May 15, 2023 · 27 comments
Open
7 of 8 tasks

CRD Validation Ratcheting #4008

alexzielenski opened this issue May 15, 2023 · 27 comments
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@alexzielenski
Copy link
Contributor

alexzielenski commented May 15, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 15, 2023
@alexzielenski
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 15, 2023
@deads2k
Copy link
Contributor

deads2k commented Jun 2, 2023

/milestone v1.28
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 2, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 2, 2023
@alexzielenski alexzielenski changed the title [WIP] CRD Validation Ratcheting CRD Validation Ratcheting Jun 5, 2023
@Atharva-Shinde
Copy link
Contributor

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 5, 2023
@Kasambx
Copy link

Kasambx commented Jun 7, 2023

Hello @alexzielenski 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for v1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:
-Fill out questions on e2e test,Rollout, Upgrade and Rollback Planning, monitoring requirements.
-Ensure the Pr is merged

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@Atharva-Shinde
Copy link
Contributor

Thanks @alexzielenski :)
With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀.
The status of this enhancement is marked as tracked. Please keep the issue description up-to-date with appropriate stages as well.

@katcosgrove
Copy link

Hello @alexzielenski! 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@alexzielenski
Copy link
Contributor Author

alexzielenski commented Jun 22, 2023

Thanks @katcosgrove I've created the placeholder PR and edited the description.

This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Hopefully I am in time. I'm assuming that since you posted on Wed Jul 21, you meant Thu Jul 22, instead of 20.

@Atharva-Shinde
Copy link
Contributor

Hey @alexzielenski Enhancements team here 👋

Just checking in as we approach Code freeze at 01:00 UTC Wednesday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

I don't see any code (k/k) update PR(s) in the issue description so if there are any k/k related PR(s) that we should be tracking for this KEP please link them in the issue description above.

As always, we are here to help if any questions come up. Thanks!

@jpbetz
Copy link
Contributor

jpbetz commented Jul 19, 2023

Just confirming that code for this feature has merged: kubernetes/kubernetes#118990 (and it included in the description for tracking purposes)

@Atharva-Shinde
Copy link
Contributor

Hey @alexzielenski 👋 Enhancements Lead here,
With kubernetes/kubernetes#118990 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze! Thanks :)

@Rishit-dagli
Copy link
Member

Hello @alexzielenski wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: kubernetes/website#41737

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@npolshakova
Copy link

Hi @alexzielenski, is this KEP targeting 1.29? If it is, can you make sure the lead-opted-in label is set on the issue so it is correctly tracked by the enhancements project board? Thanks!

@sftim
Copy link
Contributor

sftim commented Oct 2, 2023

BTW, the issue description (still) reads: “Draft KEP for upcoming SIG API Machinery proposal

@jpbetz
Copy link
Contributor

jpbetz commented Oct 2, 2023

/label lead-opted-in

@salehsedghpour
Copy link

Hello @alexzielenski 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, 6th October 2023.

This enhancement is targeting for stage beta for 1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • Make sure that the production readiness review has been merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@npolshakova npolshakova modified the milestones: v1.28, v1.29 Oct 4, 2023
@salehsedghpour
Copy link

Hi @alexzielenski , checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk. It looks like #4246 will address all of the requirements.

Let me know if I missed anything. Thanks!

@salehsedghpour
Copy link

As #4246 is now merged, the status of this enhancement can be marked as tracked for enhancement freeze.

@taniaduggal
Copy link

Hey there @alexzielenski ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@taniaduggal
Copy link

Hey there @alexzielenski, The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@alexzielenski
Copy link
Contributor Author

Hi @taniaduggal! Sorry for the delay, I've created the placeholder and updated and description with its link

@salehsedghpour
Copy link

Hey again @alexzielenski 👋 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

With all this, the status of this KEP is at risk for code freeze.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@a-mccarthy
Copy link

Hi @alexzielenski, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

@npolshakova
Copy link

Hi @alexzielenski, 1.29 Enhancement lead here. This KEP is currently at risk for code freeze. We have received your exception request and are reviewing it. Thanks!

@npolshakova
Copy link

This is deffering to 1.30 as per: https://kubernetes.slack.com/archives/C2C40FMNF/p1698797744244589

@npolshakova
Copy link

We will keep this as tracked for code freeze for Alpha 2 on the enhancements tracking board as this will require docs changes for 1.29 since new fields have been added already in 1.29 to CRDs for this feature.

@taniaduggal
Copy link

Hyy @alexzielenski , Just a reminder that the deadline for docs merge is Tuesday (November 28).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Tracked
Status: Tracked for Code Freeze
Development

No branches or pull requests