Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDI devices to device plugin API #4009

Open
10 of 12 tasks
klueska opened this issue May 15, 2023 · 49 comments · May be fixed by kubernetes/kubernetes#123315
Open
10 of 12 tasks

Add CDI devices to device plugin API #4009

klueska opened this issue May 15, 2023 · 49 comments · May be fixed by kubernetes/kubernetes#123315
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@klueska
Copy link
Contributor

klueska commented May 15, 2023

Enhancement Description

@SergeyKanzhelev
Copy link
Member

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 26, 2023
@SergeyKanzhelev
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 6, 2023
@SergeyKanzhelev
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 8, 2023
@npolshakova
Copy link

Hi @klueska 👋, 1.28 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise.)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like #4011 will address most of these issues

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@npolshakova
Copy link

Hi @klueska, checking in once more as we approach the 1.28 enhancement freeze deadline on 01:00 UTC Friday, 16th June 2023. The status of this enhancement is marked as at risk. It looks like #4011 will address most of the requirements. Let me know if I missed anything. Thanks!

@klueska
Copy link
Contributor Author

klueska commented Jun 16, 2023

@npolshakova #4011 has been merged

@Atharva-Shinde
Copy link
Contributor

Hey @klueska
With all the KEP requirements in place and merged into k/enhancements, the status of this enhancement is now marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

@VibhorChinda
Copy link

Hello @klueska 👋, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@npolshakova
Copy link

Hey again @klueska 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@Rishit-dagli
Copy link
Member

Hey @klueska , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

@klueska
Copy link
Contributor Author

klueska commented Jul 12, 2023

/cc @elezar who is working on this feature

@elezar
Copy link
Contributor

elezar commented Jul 12, 2023

I have created a draft PR: kubernetes/website#42001

@Atharva-Shinde
Copy link
Contributor

Hey @klueska 👋 Enhancements Lead here,
With kubernetes/kubernetes#118254 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@Rishit-dagli
Copy link
Member

Hello @klueska @elezar wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: kubernetes/website#42001

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@klueska
Copy link
Contributor Author

klueska commented Sep 25, 2023

I have added a KEP update link to this issue, to transition this feature to beta in 1.29

@npolshakova
Copy link

Hello @klueska, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@bart0sh
Copy link
Contributor

bart0sh commented Oct 3, 2023

@mrunalp @SergeyKanzhelev Can you add lead-opted-in label to this issue, please? The issue was included into the SIG-Node 1.29 planning document long time ago.

@bart0sh
Copy link
Contributor

bart0sh commented Oct 3, 2023

@mrunalp @SergeyKanzhelev can you also change milestone to 1.29 ?

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 6, 2024
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Jan 21, 2024

@mrunalp @SergeyKanzhelev We're going to promote this to GA in 1.30.
Can you change milestone to 1.30 and label this issue with lead-opted-in?

@aojea
Copy link
Member

aojea commented Jan 21, 2024

@mrunalp @SergeyKanzhelev We're going to promote this to GA in 1.30. Can you change milestone to 1.30 and label this issue with lead-opted-in?

@bart0sh please ensure then that this CRI fields does not depend in an alpha feature #3731, as mentioning that CDI CRI fields are independent on DRA , You can not make something GA that depends on another feature that is not GA, because if something happens and those fields change or are removed we'll have a problem

@bart0sh
Copy link
Contributor

bart0sh commented Jan 21, 2024

@aojea It's the other way around. DRA depends on the CDIDevice CRI field, at least to my understanding. We can't easily change that field as this feature (CDI devices support in Device Plugins) depends on it and it's already graduated to Beta in 1.29.

@aojea
Copy link
Member

aojea commented Jan 21, 2024

@aojea It's the other way around. DRA depends on the CDIDevice CRI field, at least to my understanding. We can't easily change that field as this feature (CDI devices support in Device Plugins) depends on it and it's already graduated to Beta in 1.29.

I see, I didn't have it clear so that is why I asked, I'm completely +1 on this, learned about CDI from @klueska the other day and seems a really nice additon

@SergeyKanzhelev
Copy link
Member

/stage stable
/milestone v1.30

@k8s-ci-robot k8s-ci-robot removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Jan 26, 2024
@salehsedghpour
Copy link
Contributor

Hello @bart0sh, 1.30 Enhancements team here! Is this enhancement targeting 1.30? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@bart0sh
Copy link
Contributor

bart0sh commented Jan 29, 2024

Hello @bart0sh, 1.30 Enhancements team here! Is this enhancement targeting 1.30? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@SergeyKanzhelev @mrunalp Can you add lead-opted-in label to this issue please?

@mrunalp
Copy link
Contributor

mrunalp commented Feb 1, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 1, 2024
@meganwolf0
Copy link

Hello @klueska, @elezar 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage stable for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • KEP Readme missing a Proposal section
  • Update the kep.yaml for stage and latest-milestone
  • Update the PRR with stable

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@bart0sh
Copy link
Contributor

bart0sh commented Feb 6, 2024

@meganwolf0 Thank you for the review!

For this KEP, we would just need to update the following:

- KEP Readme missing a Proposal section
- Update the kep.yaml for stage and latest-milestone
- Update the PRR with stable

#4446 updates kep.yaml and PRR as suggested.
@klueska @elezar Can you help to fill Proposal section?

@elezar
Copy link
Contributor

elezar commented Feb 7, 2024

Thanks @bart0sh. I have created #4487

@bart0sh
Copy link
Contributor

bart0sh commented Feb 7, 2024

@meganwolf0 All requested changes should be in the KEP when #4487 and #4446 are merged.

@bart0sh
Copy link
Contributor

bart0sh commented Feb 7, 2024

@meganwolf0 both PRs got merged, please review the KEP again, thanks!

@meganwolf0
Copy link

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@celestehorgan
Copy link

Hi @klueska @elezar!

Reminder that this needs a docs PR by the end of the week for the 1.30 release! :)

Even if there's no other updates to functionality as this is going stable, please remember to update your feature flags to stable

@Checksumz
Copy link

Hi @klueska ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@bart0sh
Copy link
Contributor

bart0sh commented Feb 15, 2024

@celestehorgan

Reminder that this needs a docs PR by the end of the week for the 1.30 release! :)

Thank you for the reminder. Submitted documentation update: Device Plugins: add info about GA graduation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Tracked
Status: Tracked for Code Freeze
Status: Tracked for Enhancements Freeze
Development

Successfully merging a pull request may close this issue.