Add CDI devices to device plugin API

[klueska]

Enhancement Description

• One-line enhancement description (can be used as a release note):
  An enhancement to the DevicePlugin API to include a field for CDI devices.

• Kubernetes Enhancement Proposal:
  https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4009-add-cdi-devices-to-device-plugin-api/

• Discussion Link:
  Private slack messages

• Primary contact (assignee):
  @klueska, @elezar

• Responsible SIGs:
  /sig node

• Enhancement target (which target equals to which milestone):

  • Alpha release target: 1.28
  • Beta release target: 1.29
  • Stable release target: 1.31

• Alpha

  • KEP (k/enhancements) update PR(s):
    • KEP4009: Add CDI Devices to device plugin API #4011
  • Code (k/k) update PR(s):
    • Add CDI devices to device plugin API kubernetes#118254
    • 4009/add e2e tests for cdi devices kubernetes#119280
  • Docs (k/website) update PR(s):
    • Add CDI Devices to Device Plugin API website#42001

• Beta

  • KEP (k/enhancements) update PR(s):
    • Update CDI for device plugins KEP for beta graduation #4238
  • Code (k/k) update PR(s):
    • e2e_node: test device plugin support of CDI devices kubernetes#121440
    • Graduate DevicePluginCDIDevices to Beta kubernetes#121254
  • Docs (k/website) update(s):
    • Device Plugins: add an info about beta graduation website#43435

• Stable

  • KEP (k/enhancements) update PR(s):
    • KEP-4009: Adding a proposal section #4487
    • Update CDI for device plugins KEP for GA graduation #4446
    • CDI for device plugins: update test grid and triage links #4521
  • Code (k/k) update PR(s):
    • Graduate DevicePluginCDIDevices to GA kubernetes#123315
  • Docs (k/website) update(s):
    • Device Plugins: add info about GA graduation website#45144

[SergeyKanzhelev]

/milestone v1.28

[SergeyKanzhelev]

/stage alpha

[SergeyKanzhelev]

/label lead-opted-in

[npolshakova]

Hi @klueska 👋, 1.28 Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise.)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like #4011 will address most of these issues

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[npolshakova]

Hi @klueska, checking in once more as we approach the 1.28 enhancement freeze deadline on 01:00 UTC Friday, 16th June 2023. The status of this enhancement is marked as at risk. It looks like #4011 will address most of the requirements. Let me know if I missed anything. Thanks!

[klueska]

@npolshakova #4011 has been merged

[Atharva-Shinde]

Hey @klueska
With all the KEP requirements in place and merged into k/enhancements, the status of this enhancement is now marked as tracked. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[VibhorChinda]

Hello @klueska 👋, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[npolshakova]

Hey again @klueska 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

• All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
• All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :

• Add CDI devices to device plugin API kubernetes#118254

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[Rishit-dagli]

Hey @klueska , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

[klueska]

/cc @elezar who is working on this feature

[elezar]

I have created a draft PR: kubernetes/website#42001

[Atharva-Shinde]

Hey @klueska 👋 Enhancements Lead here,
With kubernetes/kubernetes#118254 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

[Rishit-dagli]

Hello @klueska @elezar wave: please take a look at Documenting for a release - PR Ready for Review to get your docs PR ready for review before Tuesday 25th July 2023. Thank you!

Ref: kubernetes/website#42001

[npolshakova]

/remove-label lead-opted-in

[klueska]

I have added a KEP update link to this issue, to transition this feature to beta in 1.29

[npolshakova]

Hello @klueska, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

[rashansmith]

Hey @klueska, @elezar @bart0sh, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

[ArkaSaha30]

Hello again @klueska @elezar 👋, 1.31 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With all the implementation(code related) PRs merged as per the issue description:

• Graduate DevicePluginCDIDevices to GA kubernetes#123315

This enhancement is now marked as tracked for code freeze for the 1.31 Code Freeze!

[klueska]

Does it make sense to close this issue now that it has reached GA, or should we wait until the feature gate has been removed? At what point do we do this removal?

[bart0sh]

I think it would be better to keep it and add cleanup item to the description. We'll finally clean it up in 1.33, in 2 releases after GA.

[tjons]

Hi @bart0sh - in preparation for the next release, now that this KEP has been implemented, would you kindly update the KEP status to implemented and then close this out?

[bart0sh]

@tjons: done: #4837 Thank you for the reminder! I thought that it should be done after removing feature gate.

[tjons]

Hello 👋 1.32 Enhancements Lead here,

I'm closing milestone 1.31 now,
If you have more work on this enhancement to complete in v1.32, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.32. Thanks!

/milestone clear

[tjons]

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

[bart0sh]

no problem. This issue is going to be closed as soon as #4837 is merged, as you've suggested above. I don't think we should add it to 1.32.

[bart0sh]

@klueska #4837 has just been merged, please close this issue, thanks!

[bart0sh]

/assign @klueska

[pohly]

/wg device-management

[haircommander]

I believe this can be closed, according to #4009 (comment)