Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job creation timestamp to job annotations #4026

Closed
9 tasks done
helayoty opened this issue May 22, 2023 · 38 comments
Closed
9 tasks done

Add job creation timestamp to job annotations #4026

helayoty opened this issue May 22, 2023 · 38 comments
Assignees
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@helayoty
Copy link
Member

helayoty commented May 22, 2023

Enhancement Description

Note: We will release the feature directly in the Beta state since there is no benefit in having an alpha release, as we are simply adding a new annotation which is very little risk (unlike removing an
existing one).

@helayoty
Copy link
Member Author

/sig apps
/assign

@soltysh
Copy link
Contributor

soltysh commented May 30, 2023

/stage beta
/milestone v1.28
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label May 30, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 30, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 30, 2023
@npolshakova
Copy link

npolshakova commented May 30, 2023

Hi @helayoty 👋, Enhancements team here!

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage beta for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

It looks like #4027 will address some of these issues.

For this KEP, we would just need to update the following:

  • Address questions inside the Production Readiness Review Questionnaire

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@helayoty
Copy link
Member Author

For this KEP, we would just need to update the following:

  • Address questions inside the Production Readiness Review Questionnaire

@npolshakova This section requires to have reviewers from the
prod-readiness-approvers
team which I already added to the reviewers/approvals list.

@npolshakova
Copy link

Hi @helayoty, looks like now that the PRR is approved and #4027 has gone in this enhancement is now tracked for 1.28!

@npolshakova npolshakova moved this from At Risk to Tracked in 1.28 Enhancements Tracking Jun 14, 2023
@Rishit-dagli
Copy link
Member

Hello @helayoty 👋, 1.28 Docs Lead here.

Could you please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@helayoty
Copy link
Member Author

helayoty commented Jul 3, 2023

Hello @helayoty 👋, 1.28 Docs Lead here.

Could you please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @Rishit-dagli , PR has been created. kubernetes/website#41857

@sftim
Copy link
Contributor

sftim commented Jul 6, 2023

@npolshakova
Copy link

Hey again @helayoty 👋

Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .

Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.

Also please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

@soltysh
Copy link
Contributor

soltysh commented Jul 12, 2023

@npolshakova all the PRs are listed in the issue description, we try to keep up-to-date, the only one remaining PR is docs kubernetes/website#41857 but that shouldn't block atm.

@Atharva-Shinde
Copy link
Contributor

Hey @helayoty 👋 Enhancements Lead here,
With kubernetes/kubernetes#118137 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze!

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Sep 29, 2023
@salehsedghpour
Copy link

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.28 milestone Jan 16, 2024
@atiratree
Copy link
Member

@helayoty are you able to work on graduating this to GA in 1.30?

@helayoty helayoty moved this from Needs Triage to Backlog in SIG Apps Apr 6, 2024
@shecodesmagic shecodesmagic moved this to Tracked for enhancements freeze in 1.32 Enhancements Tracking Sep 25, 2024
@shecodesmagic
Copy link

Hello @helayoty 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@shecodesmagic shecodesmagic moved this to At risk for enhancements freeze in 1.32 Enhancements Tracking Sep 28, 2024
@soltysh
Copy link
Contributor

soltysh commented Sep 30, 2024

@shecodesmagic #4868 should handle all of the above.

@shecodesmagic
Copy link

@soltysh sounds good. Once that's merged we can mark it as tracked.

@shecodesmagic
Copy link

@soltysh Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.32. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@shecodesmagic shecodesmagic moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.32 Enhancements Tracking Oct 9, 2024
@michellengnx
Copy link

Hello @helayoty 👋, 1.32 Docs Shadow here.
Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@rashansmith
Copy link

Hello @helayoty 👋 from the v1.32 Communications Team!
We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

@michellengnx
Copy link

Hello @helayoty 👋, 1.32 Docs Shadow here. Does this enhancement work planned for 1.32 require any new docs or modification to existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. Thank you!

Hello @helayoty 👋,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is 4 days away at Thursday October 24, 2024 18:00 PDT.

Thanks,
Michelle

@soltysh
Copy link
Contributor

soltysh commented Oct 22, 2024

Draft opened at kubernetes/website#48498

@rashansmith
Copy link

Hello @helayoty 👋 from the v1.32 Communications Team! We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Hello @helayoty , this is a reminder for the feature blog post!

We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Please feel free to reach out if you have any questions!

@shecodesmagic
Copy link

Hello @helayoty @soltysh 👋, Enhancements team here (again 😁 )

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

Please note that KEPs targeting stable need to have the status field marked as implemented in the kep.yaml file after code PRs are merged and the feature gates are removed.

@shecodesmagic shecodesmagic moved this from Tracked for enhancements freeze to Tracked for code freeze in 1.32 Enhancements Tracking Oct 30, 2024
@soltysh
Copy link
Contributor

soltysh commented Nov 4, 2024

Hello @helayoty , this is a reminder for the feature blog post!

Hey @rashansmith, we believe the feature is so small that it's not worth pushing for a blog post about it.

janetkuo added a commit to janetkuo/website that referenced this issue Nov 26, 2024
…rmation to CronJob page

### Description
Add `batch.kubernetes.io/cronjob-scheduled-timestamp` annotation information to CronJob page
 
### Issue
[kubernetes/enhancements#4026](kubernetes/enhancements#4026)
janetkuo added a commit to janetkuo/website that referenced this issue Nov 26, 2024
…rmation to CronJob page

### Description
Add `batch.kubernetes.io/cronjob-scheduled-timestamp` annotation information to CronJob page
 
### Issue
[kubernetes/enhancements#4026](kubernetes/enhancements#4026)
Andygol pushed a commit to Andygol/k8s-website that referenced this issue Dec 31, 2024
…rmation to CronJob page

### Description
Add `batch.kubernetes.io/cronjob-scheduled-timestamp` annotation information to CronJob page
 
### Issue
[kubernetes/enhancements#4026](kubernetes/enhancements#4026)
@dipesh-rawat
Copy link
Member

Hi @helayoty @soltysh, 👋 1.33 Enhancements lead here,

Now that this KEP has graduated to stable, could we update the KEP status in kep.yaml (here) from implementable to implemented? If yes, once the PR for the status change is merged, we could also close this issue.

@dipesh-rawat
Copy link
Member

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2025
@soltysh
Copy link
Contributor

soltysh commented Jan 20, 2025

Now that this KEP has graduated to stable, could we update the KEP status in kep.yaml (here) from implementable to implemented? If yes, once the PR for the status change is merged, we could also close this issue.

Done in #5056. I'll close the issue once we get that PR merged.

@soltysh
Copy link
Contributor

soltysh commented Jan 20, 2025

/close

@k8s-ci-robot
Copy link
Contributor

@soltysh: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Backlog to Closed in SIG Apps Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Tracked
Status: Closed
Status: Tracked for code freeze
Development

No branches or pull requests