Discover cgroup driver from CRI

[marquiz]

Enhancement Description

• One-line enhancement description (can be used as a release note): Extend CRI API for the kubelet to discover the cgroup driver from the container runtime.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/4033-group-driver-detection-over-cri
• Discussion Link: match the kubelet and CRI implementer cgroup drivers kubernetes#99808, also SIG Node meeting Feb 14th, 2023,
• Primary contact (assignee): @marquiz @haircommander
• Responsible SIGs: SIG Node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.28
  • Beta release target (x.y): 1.31
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-4033: Discover cgroup driver from CRI #4034
  • Code (k/k) update PR(s):
    • kubelet: get cgroup driver config from CRI kubernetes#118770
  • Docs (k/website) update PR(s):
    • docs: document kubelet cgroup driver detection from the runtime website#42160
• Beta
  • KEP (k/enhancements) update PR(s): KEP-4033: bump to beta #4682
  • Code (k/k) update PR(s):
    • kubelet: update documentation of the cgroupDriver setting kubernetes#119441
    • KEP-4033: fulfill beta criteria kubernetes#125828
  • Docs (k/website) update(s): KEP-4033: cgroup driver from CRI beta blog website#47054

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[marquiz]

/sig node

[SergeyKanzhelev]

/milestone v1.28

[SergeyKanzhelev]

/label lead-opted-in

[SergeyKanzhelev]

/stage alpha

[salehsedghpour]

Hello @marquiz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: 1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

• Update the detailed test plan section in the readme file.
• Update the reviewer and approver fields in kep.yaml.
• Ensure that the PRs are merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[salehsedghpour]

Hi @marquiz 👋, just checking in before the enhancements freeze on 01:00 UTC Friday, 16th June 2023.

The status for this enhancement is at risk.

For this KEP, we would just need to update the following:

• Update the detailed test plan section in the readme file.
• Update the reviewer and approver fields in kep.yaml.
• Ensure that the PRs are merged.

Let me know if I missed anything. Thanks!

[marquiz]

Thanks @salehsedghpour. The first two of the items should now be addressed:

• Test plan section in the readme file has been updated
• Reviewer and approver fields in kep.yaml have been filled

[salehsedghpour]

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀

The status of this enhancement is marked as tracked.

[VibhorChinda]

Hello @marquiz 👋, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[Rishit-dagli]

Hey @marquiz , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

[salehsedghpour]

Hey again @marquiz 👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .
Here’s the enhancement’s state for the upcoming code freeze:

• All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
• All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.
  For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :
  • kubelet: get cgroup driver config from CRI kubernetes#118770

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

[VibhorChinda]

Hey @marquiz , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.
Thanks.

[marquiz]

@VibhorChinda thanks 🫡 I will work on that tomorrow

[Atharva-Shinde]

Hey @marquiz 👋 Enhancements Lead here,
With kubernetes/kubernetes#118770 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

[VibhorChinda]

Hello @marquiz 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

[marquiz]

@VibhorChinda argh, I had submitted the documentation to the main branch, against the guidance 🙈 I now re-submitted towards dev-1.28 (kubernetes/website#42160).

[haircommander]

thanks for the reminder @dipesh-rawat , I have opened #4769

[haircommander]

I'm unable to edit the issue description and I think @marquiz is out, but kubernetes/kubernetes#125828 is the only implementation PR needed

[dipesh-rawat]

I'm unable to edit the issue description and I think @marquiz is out

I see in the edit history that @pacoxu has previously edited the issue description. We could request him this time as well. I’ll also check if anyone from the Release Team has access to this.

Once the milestone update PR #4769 is merged, this should be ready for code freeze.

[neolit123]

edited the OP to have kubernetes/kubernetes#125828 where the ? was.

[sreeram-venkitesh]

Looks like the implementation PR kubernetes/kubernetes#125828 has been merged. @haircommander @neolit123 We don't have any other code PRs for this KEP right?

[haircommander]

nope! this is done :)

[dipesh-rawat]

Hi @haircommander Thanks for confirmation.

Everything seems to be in place for this KEP issue now that the following code implementation PR have been merged.

• KEP-4033: fulfill beta criteria kubernetes#125828

This enhancement is now marked as tracked for code freezefor the 1.31 Code Freeze!

[dipesh-rawat]

@haircommander It would be appreciated if following update to the KEP milestone would also be merged (ideally before the release):

• KEP-4033: update metadata to reflect beta status #4769

[haircommander]

Since this went to beta in 1.31, I'm moving this to Not for release

[tjons]

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[marquiz]

/remove-lifecycle stale