Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover cgroup driver from CRI #4033

Open
3 of 8 tasks
marquiz opened this issue May 25, 2023 · 19 comments
Open
3 of 8 tasks

Discover cgroup driver from CRI #4033

marquiz opened this issue May 25, 2023 · 19 comments
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@marquiz
Copy link
Contributor

marquiz commented May 25, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 25, 2023
@marquiz
Copy link
Contributor Author

marquiz commented May 25, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 25, 2023
@SergeyKanzhelev
Copy link
Member

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 26, 2023
@SergeyKanzhelev
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jun 8, 2023
@SergeyKanzhelev
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 8, 2023
@salehsedghpour
Copy link
Contributor

Hello @marquiz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC Friday, 16th June 2023.

This enhancement is targeting for stage alpha for 1.28 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.28
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

  • Update the detailed test plan section in the readme file.
  • Update the reviewer and approver fields in kep.yaml.
  • Ensure that the PRs are merged.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@salehsedghpour
Copy link
Contributor

Hi @marquiz 👋, just checking in before the enhancements freeze on 01:00 UTC Friday, 16th June 2023.

The status for this enhancement is at risk.

For this KEP, we would just need to update the following:

  • Update the detailed test plan section in the readme file.
  • Update the reviewer and approver fields in kep.yaml.
  • Ensure that the PRs are merged.

Let me know if I missed anything. Thanks!

@marquiz
Copy link
Contributor Author

marquiz commented Jun 15, 2023

Thanks @salehsedghpour. The first two of the items should now be addressed:

  • Test plan section in the readme file has been updated
  • Reviewer and approver fields in kep.yaml have been filled

@salehsedghpour
Copy link
Contributor

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze 🚀

The status of this enhancement is marked as tracked.

@VibhorChinda
Copy link

Hello @marquiz 👋, 1.28 Docs Shadow here.

Does this enhancement work planned for 1.28 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.28 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 20th July 2023.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@Rishit-dagli
Copy link
Member

Hey @marquiz , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.

@salehsedghpour
Copy link
Contributor

Hey again @marquiz 👋
Just checking in as we approach Code freeze at 01:00 UTC Friday, 19th July 2023 .
Here’s the enhancement’s state for the upcoming code freeze:

  • All the PRs that are related to your enhancement are linked in the above issue description (for tracking purposes). This includes code, tests, and documentation related PR/s.
  • All code related PR/s are merged or are in merge-ready state ( i.e they have approved and lgtm labels applied) by the code freeze deadline. This includes any tests related PR/s too.
    For this enhancement, it looks like the following code related PR/s are open and they need to be merged or should be in merge-ready state before the code freeze commences :

Please keep the issue description up-to-date with all the PR/s that are associated with this KEP and let me know if there are other PR/s in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@VibhorChinda
Copy link

Hey @marquiz , could you please create a docs PR even if it is a draft PR with no content yet against dev-1.28 branch in the k/website repo. The deadline to create this draft PR is Thursday 20th July 2023.
Thanks.

@marquiz
Copy link
Contributor Author

marquiz commented Jul 18, 2023

@VibhorChinda thanks 🫡 I will work on that tomorrow

@Atharva-Shinde
Copy link
Contributor

Hey @marquiz 👋 Enhancements Lead here,
With kubernetes/kubernetes#118770 merged as per the issue description, this enhancement is now tracked for v1.28 Code Freeze. Thanks!

@VibhorChinda
Copy link

Hello @marquiz 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

@marquiz
Copy link
Contributor Author

marquiz commented Jul 24, 2023

@VibhorChinda argh, I had submitted the documentation to the main branch, against the guidance 🙈 I now re-submitted towards dev-1.28 (kubernetes/website#42160).

@npolshakova
Copy link

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Aug 27, 2023
@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.28 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.28 milestone Jan 16, 2024
@marquiz
Copy link
Contributor Author

marquiz commented Jan 30, 2024

Plan is for beta in v1.31 (description updated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Tracked
Development

No branches or pull requests

8 participants