Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Static Policy Proposal - Spread HT across physical CPUs #4176

Open
4 tasks
Jeffwan opened this issue Sep 5, 2023 · 20 comments
Open
4 tasks

New Static Policy Proposal - Spread HT across physical CPUs #4176

Jeffwan opened this issue Sep 5, 2023 · 20 comments
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@Jeffwan
Copy link
Contributor

Jeffwan commented Sep 5, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 5, 2023
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Sep 5, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 5, 2023
@ffromani
Copy link
Contributor

ffromani commented Sep 5, 2023

/cc

@SergeyKanzhelev
Copy link
Member

/stage alpha
/milestone v1.29

Applying the milestone as discussed at SIG Node meeting this week

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 15, 2023
@npolshakova
Copy link

npolshakova commented Sep 22, 2023

Hello @Jeffwan, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@salehsedghpour
Copy link
Contributor

Hello 👋 1.30 Enhancements Lead here,

I'm closing milestone 1.29 now,
If you wish to progress this enhancement in v1.30, please follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board and finally add /milestone v1.30. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Jan 16, 2024
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jan 19, 2024

Sounds good. I will follow the instruction and move it to v1.30. We plan to polish it for further review.

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Jan 23, 2024

@salehsedghpour This is the initial issue and the PR is not merged yet. Could you help add v1.30 milestone? @SergeyKanzhelev @ffromani We will put some time to address all the comments recently

@salehsedghpour
Copy link
Contributor

Thanks for the info @Jeffwan, may you please follow it up so that you could also have the lead-opted-in label and the milestone with the SIG leads?

@SergeyKanzhelev
Copy link
Member

/stage alpha
/milestone v1.30

As discussed this is conditioned on the discussion on whether NRI approach will work better for this scenario

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 26, 2024
@mrunalp
Copy link
Contributor

mrunalp commented Feb 2, 2024

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2024
@jpbetz
Copy link
Contributor

jpbetz commented Feb 6, 2024

PRR reviewer here, is there a KEP PR for 1.30 for this enhancement?

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Feb 7, 2024

@jpbetz I see you've already left comments in the PR. #4177 Let's discuss more details there.

@sreeram-venkitesh
Copy link
Member

Hello @Jeffwan 👋, v1.30 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we need to do the following:

  • Update the latest-milestone here in the kep.yaml to 1.30
  • Update the alpha milestone to 1.30 instead of 1.29.
  • Make sure to create the prod-readiness/<sig>/<KEP number>.yaml file as mentioned by @jpbetz here. More about

The status of this enhancement is marked as At risk for enhancements freeze. Please make sure to do all the above tasks and get your PRs merged before the enhancements freeze. Please let us know if you have any questions!

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Feb 8, 2024

@sreeram-venkitesh Thanks for the reminder. All the TODO items have been addressed and it's pending review.

@sreeram-venkitesh
Copy link
Member

Hello 👋, v1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.30, please file an exception request. Thanks!

@salehsedghpour
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Feb 9, 2024
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Feb 9, 2024

@sreeram-venkitesh @salehsedghpour I filed an exception and waiting for sig-node to approve it.

@salehsedghpour salehsedghpour added this to the v1.30 milestone Feb 10, 2024
@celestehorgan
Copy link

Hello @Jeffwan!

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@Checksumz
Copy link

Hi @Jeffwan ,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Feb 19, 2024

@celestehorgan kubernetes/website#45216
@Checksumz kubernetes/website#45217

I have filed placeholder PRs for doc and blog change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Tracked for Enhancements Freeze
Development

No branches or pull requests