-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBOR Serializer #4222
Comments
/sig api-machinery |
/milestone v1.29 |
Hello @benluddy 👋, v1.29 Enhancements team here. Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as |
Hi @benluddy 👋🏽 checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as |
As #4223 is merged, marking this as |
Hey there @benluddy ! 👋, v1.29 Docs team shadow here. |
Hey there @benluddy ! ,The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you! |
Hi @taniaduggal, thanks for the reminder. I've opened a placeholder PR: kubernetes/website#43557. |
Hey again @benluddy 👋, 1.29 Enhancements team here, Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: . Here's where this enhancement currently stands:
For this enhancement, looks like the following PRs are open and needs to be merged before code freeze. The status of this KEP is currently Please update the issue description to include all the related PRs of this KEP under the As always, we are here to help if any questions come up. Thanks! |
Hi @benluddy, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release. If so, you need to open a PR placeholder in the website repository. |
@rayandas Thanks. This will have to target a later release, it won't be ready for 1.29. |
Hello @benluddy, 👋 1.29 Enhancements lead here, Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone. If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks! /milestone clear |
/remove-label lead-opted-in |
trying again for alpha in 1.30, with no KEP changes /milestone v1.30 |
cc @benluddy to double me here- We do want this in for alpha in 1.32, correct? |
Yes, thanks. |
I see that the feature gate is named
My thinking: For the first option, I'd rename the existing feature gate. For the second option (which I prefer), we'd make up two new names. Some code paths might become active if either of the two gates is enabled. For initial alpha, we could fail API server startup if the two gates are not set the same. Later in the lifecycle of this enhancement we could potentially graduate one side to beta but off by default whilst the other side is still alpha. We could also have one part be on by default and beta whilst the other side is off by default and beta. |
Also also, placeholder docs PR is due on 2024-10-24. I hope that kubernetes/website#46230 would be merged into main by then. |
Hello @benluddy 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024. This enhancement is targeting for stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
Good question. Can we imagine a latent issue that would be serious enough to warrant disabling either storage or serving, but not both? I hesitate to propose a second server-side gate unless it's necessary. |
You might have stored CBOR data and not want your control plane to break, but have found a bug in the beta (or alpha) implementation of serving. |
Decoding stored CBOR data can't be disabled by feature gate. The gate only controls the storage encoding for new resources. |
Re: feature gates This was discussed early on. My recollection is that we wanted to the ability to 'turn it off" in an emergency in the safest way possible. I'm onboard with a single feature gate where we stop storing an serving CBOR, but continue to support reading it from storage. My understanding is that this is the current proposal. I like it because, IF we are somehow corrupting data, it can be hard to know exactly what that is happening, so just turning of storing or just turning of serving code risks having a problem persist unexpectedly because the code path where the actual problem hasn't been turned off. |
Rereading @sftim's original comment, it seems the functionality of the proposed server-side gate may be unclear or incomplete in the current text. The intended functionality of the proposed server-side gate is to toggle both serving and the CR storage encoding. |
I'll try to follow up on Slack, to keep this KEP issue concise. |
With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀 |
Hey @benluddy 👋 from the v1.32 Communications Team! We'd love for you to consider writing a feature blog about your enhancement. To opt-in, let us know by opening a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines. Note: In your placeholder PR, use |
Hello @benluddy 👋, 1.32 Docs Shadow here. |
Thanks @AnshumanTripathi, I've opened a placeholder PR: kubernetes/website#48464. |
Hey hey :) |
Hello 👋, 1.33 Enhancements Lead here. I’m closing milestone 1.32 now. If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the /remove-label lead-opted-in |
Enhancement Description
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: