Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBOR Serializer #4222

Open
4 tasks
benluddy opened this issue Sep 19, 2023 · 13 comments
Open
4 tasks

CBOR Serializer #4222

benluddy opened this issue Sep 19, 2023 · 13 comments
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@benluddy
Copy link
Contributor

benluddy commented Sep 19, 2023

Enhancement Description

  • One-line enhancement description (can be used as a release note): Adds the CBOR data format as an efficient alternative to JSON.
  • Kubernetes Enhancement Proposal: KEP-4222: CBOR Serializer #4223
  • Discussion Link:
  • Primary contact (assignee): @benluddy
  • Responsible SIGs: sig-api-machinery
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.30
    • Beta release target (x.y):
    • Stable release target (x.y):
  • Alpha
    • KEP (k/enhancements) update PR(s):
    • Code (k/k) update PR(s):
    • Docs (k/website) update PR(s):

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 19, 2023
@benluddy
Copy link
Contributor Author

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 19, 2023
@npolshakova
Copy link

npolshakova commented Sep 22, 2023

Hello @benluddy, 1.29 Enhancements team here! Is this enhancement targeting 1.29? If it is, can you follow the instructions here to opt in the enhancements and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

@deads2k
Copy link
Contributor

deads2k commented Sep 25, 2023

/milestone v1.29
/label lead-opted-in
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 25, 2023
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 25, 2023
@rayandas
Copy link
Member

Hello @benluddy 👋, v1.29 Enhancements team here.

Just checking in as we approach enhancements freeze on 01:00 UTC, Friday, 6th October, 2023.

This enhancement is targeting for stage alpha for v1.29 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.29.
  • KEP readme has a updated detailed test plan section filled out
  • KEP readme has up to date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@rayandas
Copy link
Member

rayandas commented Oct 4, 2023

Hi @benluddy 👋🏽 checking in once more as we approach the 1.29 enhancement freeze deadline on 01:00 UTC, Friday, 6th October, 2023. The status of this enhancement is marked as at risk for enhancement freeze.
It looks like updating and merging PR #4223 will address most of the requirements. Let me know if I missed anything. Thanks.

@rayandas
Copy link
Member

rayandas commented Oct 5, 2023

As #4223 is merged, marking this as Tracked for Enhancements Freeze. 🚀 Thanks.

@taniaduggal
Copy link

Hey there @benluddy ! 👋, v1.29 Docs team shadow here.
Does this enhancement work planned for v1.29 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.29 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, 19 October 2023.
Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.
Thank you!

@taniaduggal
Copy link

Hey there @benluddy ! ,The deadline to open a placeholder PR against k/website for required documentation is Thursday, 19 October. Could you please update me on the status of docs for this enhancement? Thank you!

@benluddy
Copy link
Contributor Author

Hi @taniaduggal, thanks for the reminder. I've opened a placeholder PR: kubernetes/website#43557.

@rayandas
Copy link
Member

Hey again @benluddy 👋, 1.29 Enhancements team here,

Just checking in as we approach code freeze at 01:00 UTC Wednesday 1st November 2023: .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).

  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, looks like the following PRs are open and needs to be merged before code freeze.

The status of this KEP is currently at risk for Code Freeze.

Please update the issue description to include all the related PRs of this KEP under the alpha section in the issue description.

As always, we are here to help if any questions come up. Thanks!

@a-mccarthy
Copy link

Hi @benluddy, 👋 from the v1.29 Release Team-Communications! We would like to check if you have any plans to publish a blog for this KEP regarding new features, removals, and deprecations for this release.

If so, you need to open a PR placeholder in the website repository.
The deadline will be on Tuesday 14th November 2023 (after the Docs deadline PR ready for review)

Here is the 1.29 calendar

@benluddy
Copy link
Contributor Author

@rayandas Thanks. This will have to target a later release, it won't be ready for 1.29.

@npolshakova
Copy link

Hello @benluddy, 👋 1.29 Enhancements lead here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.29 milestone.

If you still wish to progress this enhancement in 1.29, please file an exception request. Thanks!

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.29 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Removed from Milestone
Development

No branches or pull requests

7 participants