Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom profile in kubectl debug #4292

Closed
12 tasks done
ardaguclu opened this issue Oct 13, 2023 · 45 comments
Closed
12 tasks done

Custom profile in kubectl debug #4292

ardaguclu opened this issue Oct 13, 2023 · 45 comments
Assignees
Labels
sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@ardaguclu
Copy link
Member

ardaguclu commented Oct 13, 2023

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 13, 2023
@ardaguclu
Copy link
Member Author

/sig cli

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 13, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Oct 13, 2023
@soltysh
Copy link
Contributor

soltysh commented Jan 16, 2024

/label lead-opted-in
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 16, 2024
@soltysh
Copy link
Contributor

soltysh commented Jan 16, 2024

/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status lead-opted-in Denotes that an issue has been opted in to a release labels Jan 16, 2024
@soltysh
Copy link
Contributor

soltysh commented Jan 26, 2024

/assign @ardaguclu

@tjons tjons moved this to At Risk for Enhancements Freeze in 1.30 Enhancements Tracking Jan 31, 2024
@tjons
Copy link
Contributor

tjons commented Jan 31, 2024

Hello @ardaguclu 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to complete the following:

  • Add graduation criteria to the KEP readme.
  • Merge the KEP readme into k/enhancements.
  • Complete the PRR review process and merge it into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@ardaguclu
Copy link
Member Author

@tjons thanks for checking the KEP. But I have added graduation criteria as you can see in https://github.com/kubernetes/enhancements/pull/4293/files#diff-708a3d9c4718ca7f3da37b08c6cbee5ff7fc7df4f496783dd213b7abf0f2c216R98, do you mean adding somewhere else?.

@tjons
Copy link
Contributor

tjons commented Jan 31, 2024

@ardaguclu whoops, missed that in the diff! thanks for updating me. I've updated my commend accordingly.

@tjons
Copy link
Contributor

tjons commented Feb 8, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@tjons tjons moved this from At Risk for Enhancements Freeze to Tracked for Enhancements Freeze in 1.30 Enhancements Tracking Feb 8, 2024
@natalisucks
Copy link

Hi @ardaguclu,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.

Here's the 1.30 Release Calendar

@Vyom-Yadav
Copy link
Member

Hello @ardaguclu 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

Going through the changes this PR entails, we'll need a docs PR. Marking this as Need Docs. Thanks for this cool feature!

@tjons
Copy link
Contributor

tjons commented Feb 25, 2024

Hey again @ardaguclu 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@tjons tjons moved this from Tracked for Enhancements Freeze to At Risk for Code Freeze in 1.30 Enhancements Tracking Feb 25, 2024
@tjons
Copy link
Contributor

tjons commented Mar 6, 2024

Hello @ardaguclu 👋, Enhancements team here.

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the 1.30 Code Freeze!

@tjons tjons moved this from At Risk for Code Freeze to Tracked for Code Freeze in 1.30 Enhancements Tracking Mar 6, 2024
@ardaguclu ardaguclu removed this from the v1.33 milestone Sep 17, 2024
@ardaguclu
Copy link
Member Author

/milestone v1.32

@dipesh-rawat
Copy link
Member

dipesh-rawat commented Sep 24, 2024

Hello @ardaguclu 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • Update kep.yaml to mention latest-milestone: v1.32 and stable: "v1.32"
  • Complete the PRR review process for stable stage and merge it into k/enhancements.

It looks like #4824 will address most of these issues.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat dipesh-rawat removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 24, 2024
@dipesh-rawat dipesh-rawat moved this to At risk for enhancements freeze in 1.32 Enhancements Tracking Sep 24, 2024
@dipesh-rawat
Copy link
Member

Hello @ardaguclu 👋, v1.32 Enhancements team here,

Now that PR #4824 has been merged, all the KEP requirements are in place and merged into k/enhancements.

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.32 Enhancements Tracking Oct 8, 2024
@dipesh-rawat dipesh-rawat added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 8, 2024
@edithturn
Copy link

Hello @ardaguclu , 👋🏼 this is Edith from the v1.32 Communications Team!

We’d love for you to consider writing a feature blog about your enhancement! ✍
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog, see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@rdalbuquerque
Copy link

Hello @ardaguclu 👋, 1.32 Docs Shadow here.
Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@dipesh-rawat
Copy link
Member

Hey again @ardaguclu 👋 v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

Additionally, please let me know if there are any other PRs in k/k not listed in the description or linked with this GitHub issue that we should track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat dipesh-rawat moved this from Tracked for enhancements freeze to At risk for code freeze in 1.32 Enhancements Tracking Oct 21, 2024
@dipesh-rawat
Copy link
Member

Hi @ardaguclu 👋 v1.32 Enhancements team here,

I see that PR kubernetes/kubernetes#127187 has been merged, adding E2E test related to this KEP-4292. Are there any additional code/test changes planned for this KEP needed to progress towards a stable release in v1.32? If there are, could you update the issue description so we can track them and ensure accurate status? And if no further changes are expected, please let me know as well. Once I have your update, I’ll adjust the status of this KEP accordingly.

The current status of this enhancement is marked as at risk for code freeze.

@ardaguclu
Copy link
Member Author

@dipesh-rawat There is no pending PRs other than website changes kubernetes/website#47805. I think, this KEP is almost completed.

@edithturn
Copy link

edithturn commented Oct 28, 2024

Hello @ardaguclu ! 🙂 👋

This is a reminder to author your feature blog post!

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Please feel free to reach out if you have any questions!

Thank you very much!
Edith from the v1.32 Shadow Communications Team

@dipesh-rawat
Copy link
Member

@ardaguclu Thanks for the confirmation (here).

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

@dipesh-rawat dipesh-rawat moved this from At risk for code freeze to Tracked for code freeze in 1.32 Enhancements Tracking Oct 28, 2024
@dipesh-rawat
Copy link
Member

Hi @ardaguclu , 👋 1.33 Enhancements lead here,

Now that this KEP has graduated to stable, could we update the KEP status in kep.yaml (here) from implementable to implemented? If yes, once the PR for the status change is merged, we should also close this issue.

@dipesh-rawat
Copy link
Member

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2025
@dipesh-rawat dipesh-rawat removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 12, 2025
@ardaguclu
Copy link
Member Author

#5057 marks the KEP as implemented. I think, we can close this issue as done.

@github-project-automation github-project-automation bot moved this from Needs Triage to Closed in SIG CLI Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Status: Tracked for Doc Freeze
Status: Closed
Status: Tracked for Doc Freeze
Status: Tracked for code freeze
Development

No branches or pull requests