Skip to content

Projected service account tokens for Kubelet image credential providers #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
16 of 22 tasks
aramase opened this issue Jan 17, 2024 · 31 comments
Open
16 of 22 tasks
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@aramase
Copy link
Member

aramase commented Jan 17, 2024

Enhancement Description

@aramase
Copy link
Member Author

aramase commented Jan 17, 2024

/sig auth

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 17, 2024
@enj enj added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 17, 2024
@enj enj added this to the v1.30 milestone Jan 17, 2024
@enj enj assigned enj and aramase Jan 17, 2024
@enj enj added this to SIG Auth Jan 18, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Auth Jan 18, 2024
@salehsedghpour
Copy link

Hello @aramase and @enj 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just need to update the following:

  • This enhancement seems to be fresh and thus I was not able to find any information about it in the PRs in k/enhancements. Please make sure to have a merged PR before Enhancements Freeze.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@salehsedghpour salehsedghpour moved this to At Risk for Enhancements Freeze in 1.30 Enhancements Tracking Jan 21, 2024
@enj
Copy link
Member

enj commented Jan 24, 2024

cc @mikebrow @SergeyKanzhelev @ndixita @ruiwen-zhao @harche @haircommander

Will have an KEP open for this soon.

@enj enj moved this from Needs Triage to In Progress in SIG Auth Jan 24, 2024
@enj
Copy link
Member

enj commented Feb 5, 2024

Per the slack thread conversation, I am moving this KEP out of the v1.30 release.

@enj enj removed this from the v1.30 milestone Feb 5, 2024
@enj enj removed the lead-opted-in Denotes that an issue has been opted in to a release label Feb 5, 2024
@salehsedghpour
Copy link

Hello @enj, thanks for the update. I'm changing the status of this enhancement to deferred. and we are not going to track this enhancement for this release anymore.

@salehsedghpour salehsedghpour moved this from At Risk for Enhancements Freeze to Deferred in 1.30 Enhancements Tracking Feb 5, 2024
@salehsedghpour salehsedghpour moved this from Deferred to Removed from Milestone in 1.30 Enhancements Tracking Feb 9, 2024
@salehsedghpour
Copy link

/milestone clear

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2024
@aramase
Copy link
Member Author

aramase commented May 9, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 9, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2024
@aramase
Copy link
Member Author

aramase commented Aug 7, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2024
@bianbbc87
Copy link

bianbbc87 commented Mar 4, 2025

Hey again @aramase 👋, v1.33 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PRs are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

If you anticipate missing code freeze, you can file an exception request in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

The status of this enhancement is marked as At risk for code freeze.

As always, we are here to help if any questions come up. Thanks!

@bianbbc87
Copy link

Hello @aramase @enj 👋, v1.33 Enhancements team here.

With all the implementation (code-related) PRs merged per the issue description:

This enhancement is now marked as Tracked for code freeze for the v1.33 Code Freeze!

Additionally, please let me know if there are any other PRs in k/k that we should track for this KEP, so that we can maintain accurate status.

Please note that KEPs targeting stable need to have the status field marked as implemented in the kep.yaml file after code PRs are merged and the feature gates are removed.

@bianbbc87 bianbbc87 moved this from At risk for code freeze to Tracked for code freeze in 1.33 Enhancements Tracking Mar 17, 2025
@haircommander haircommander moved this from Tracked to Implemented in SIG Node 1.33 KEPs planning Mar 24, 2025
@dshebib
Copy link

dshebib commented Mar 25, 2025

@aramase Friendly reminder that the deadline to have the doc PR ready for review is today Tuesday 25th March 2025 18:00 PDT

@rayandas rayandas moved this from Tracked for code freeze to At Risk for Docs Freeze in 1.33 Enhancements Tracking Apr 3, 2025
@michellengnx michellengnx moved this from At Risk for Docs Freeze to Tracked for Docs Freeze in 1.33 Enhancements Tracking Apr 7, 2025
@liggitt liggitt added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Apr 28, 2025
@liggitt liggitt modified the milestones: v1.33, v1.34 Apr 28, 2025
@liggitt
Copy link
Member

liggitt commented Apr 28, 2025

Targeting beta for 1.34

@haircommander haircommander moved this from Implemented to Done in SIG Node 1.33 KEPs planning May 13, 2025
patrickdillon added a commit to patrickdillon/installer that referenced this issue May 15, 2025
Removing the identity from the Azure nodes in
openshift#9538
broke the acr-credentials-provider, which allows pulling images
from private registries in Azure.

Instead of re-adding the identity attached to the node, we can
add a secret which will add credentials to the cloud provider config.

Upstream is working on a solution that will use credentials requests.
Once that is landed, we can remove this. Track:
kubernetes/enhancements#4412
@jenshu jenshu removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label May 17, 2025
patrickdillon added a commit to patrickdillon/installer that referenced this issue May 19, 2025
openshift#9538 switched the installer
to not create user-assigned identities for VMs, and exposed an API
for users to bring-their-own identities and attach them to nodes.

OCPBUGS-56008 shows that the kubelet still depends on the node
identity to pull images from Azure Container Registry (ACR). To
resolve this issue, this commit sets the default back to using
an installer-generated identity attached to the node. The API is
still exposed in the install config, so users who do not utilize
ACR can set the identity type to None and install with less privileged
credentials.

When upstream work lands to allow these credentials to be managed
via credentialsrequests, we can go set the default identity to None
and remove the logic for creating identities. The upstream work
is tracked here and looks like it should be available in the next
release:

kubernetes/enhancements#4412
patrickdillon added a commit to patrickdillon/installer that referenced this issue May 19, 2025
openshift#9538 switched the installer
to not create user-assigned identities for VMs, and exposed an API
for users to bring-their-own identities and attach them to nodes.

OCPBUGS-56008 shows that the kubelet still depends on the node
identity to pull images from Azure Container Registry (ACR). To
resolve this issue, this commit sets the default back to using
an installer-generated identity attached to the node. The API is
still exposed in the install config, so users who do not utilize
ACR can set the identity type to None and install with less privileged
credentials.

When upstream work lands to allow these credentials to be managed
via credentialsrequests, we can go set the default identity to None
and remove the logic for creating identities. The upstream work
is tracked here and looks like it should be available in the next
release:

kubernetes/enhancements#4412
patrickdillon added a commit to patrickdillon/installer that referenced this issue May 20, 2025
openshift#9538 switched the installer
to not create user-assigned identities for VMs, and exposed an API
for users to bring-their-own identities and attach them to nodes.

OCPBUGS-56008 shows that the kubelet still depends on the node
identity to pull images from Azure Container Registry (ACR). To
resolve this issue, this commit sets the default back to using
an installer-generated identity attached to the node. The API is
still exposed in the install config, so users who do not utilize
ACR can set the identity type to None and install with less privileged
credentials.

When upstream work lands to allow these credentials to be managed
via credentialsrequests, we can go set the default identity to None
and remove the logic for creating identities. The upstream work
is tracked here and looks like it should be available in the next
release:

kubernetes/enhancements#4412
patrickdillon added a commit to patrickdillon/installer that referenced this issue May 20, 2025
openshift#9538 switched the installer
to not create user-assigned identities for VMs, and exposed an API
for users to bring-their-own identities and attach them to nodes.

OCPBUGS-56008 shows that the kubelet still depends on the node
identity to pull images from Azure Container Registry (ACR). To
resolve this issue, this commit sets the default back to using
an installer-generated identity attached to the node. The API is
still exposed in the install config, so users who do not utilize
ACR can set the identity type to None and install with less privileged
credentials.

When upstream work lands to allow these credentials to be managed
via credentialsrequests, we can go set the default identity to None
and remove the logic for creating identities. The upstream work
is tracked here and looks like it should be available in the next
release:

kubernetes/enhancements#4412
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/installer that referenced this issue May 21, 2025
openshift#9538 switched the installer
to not create user-assigned identities for VMs, and exposed an API
for users to bring-their-own identities and attach them to nodes.

OCPBUGS-56008 shows that the kubelet still depends on the node
identity to pull images from Azure Container Registry (ACR). To
resolve this issue, this commit sets the default back to using
an installer-generated identity attached to the node. The API is
still exposed in the install config, so users who do not utilize
ACR can set the identity type to None and install with less privileged
credentials.

When upstream work lands to allow these credentials to be managed
via credentialsrequests, we can go set the default identity to None
and remove the logic for creating identities. The upstream work
is tracked here and looks like it should be available in the next
release:

kubernetes/enhancements#4412
patrickdillon added a commit to patrickdillon/installer that referenced this issue May 21, 2025
openshift#9538 switched the installer
to not create user-assigned identities for VMs, and exposed an API
for users to bring-their-own identities and attach them to nodes.

OCPBUGS-56008 shows that the kubelet still depends on the node
identity to pull images from Azure Container Registry (ACR). To
resolve this issue, this commit sets the default back to using
an installer-generated identity attached to the node. The API is
still exposed in the install config, so users who do not utilize
ACR can set the identity type to None and install with less privileged
credentials.

When upstream work lands to allow these credentials to be managed
via credentialsrequests, we can go set the default identity to None
and remove the logic for creating identities. The upstream work
is tracked here and looks like it should be available in the next
release:

kubernetes/enhancements#4412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/auth Categorizes an issue or PR as relevant to SIG Auth. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: No status
Status: In Progress
Status: Removed from Milestone
Status: Removed from Milestone
Status: Tracked for Docs Freeze
Status: Done
Development

No branches or pull requests