Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry Generate Name #4420

Open
12 tasks done
jpbetz opened this issue Jan 20, 2024 · 32 comments
Open
12 tasks done

Retry Generate Name #4420

jpbetz opened this issue Jan 20, 2024 · 32 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Jan 20, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 20, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Jan 20, 2024

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 20, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Feb 2, 2024

/label lead-opted-in
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 2, 2024
@tjons
Copy link
Contributor

tjons commented Feb 6, 2024

Hello @jpbetz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on Friday, February 9th, 2024 at 02:00 UTC.

This enhancement is targeting for stage alpha for 1.30 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: { CURRENT_RELEASE }. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@tjons tjons moved this to Tracked for Enhancements Freeze in 1.30 Enhancements Tracking Feb 6, 2024
@tjons
Copy link
Contributor

tjons commented Feb 9, 2024

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@kcmartin
Copy link

Hi @jpbetz,

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@Vyom-Yadav
Copy link
Member

Hello @jpbetz 👋, v1.30 Docs Shadow here.

Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday, February 22nd, 2024 18:00 PDT

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!


Does this enhancement work planned for v1.30 require any new docs or modification to existing docs?

I see the new NameGenerationRetries feature gate, so we'll need docs for that. Marking this as Need Docs. Thanks!

@jpbetz
Copy link
Contributor Author

jpbetz commented Feb 15, 2024

Draft Documentation PR: kubernetes/website#45154

@tjons
Copy link
Contributor

tjons commented Feb 25, 2024

Hey again @jpbetz 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

Everything looks good. Please let me know if there are any other PRs in k/k we should be tracking for this issue, other than kubernetes/kubernetes#122887.

@tjons tjons moved this from Tracked for Enhancements Freeze to Tracked for Code Freeze in 1.30 Enhancements Tracking Feb 25, 2024
@drewhagen drewhagen moved this to Tracked for Code Freeze in 1.30 Enhancements Tracking Apr 1, 2024
@drewhagen drewhagen moved this from Tracked for Code Freeze to Tracked for Doc Freeze in 1.30 Enhancements Tracking Apr 1, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented May 2, 2024

/milestone v1.31

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.30, v1.31 May 2, 2024
@sftim
Copy link
Contributor

sftim commented May 7, 2024

With #4592 merged, we should update the issue description.

@dipesh-rawat
Copy link
Member

@jpbetz Could I please get clarification on something. I see that in the upstream code for Alpha (PR https://github.com/kubernetes/kubernetes/pull/122887/files), the feature gate that was added was named as RetryGenerateName but in our documentation (here) and in the kep (here), we mentioned the feature gate name as NameGenerationRetries. What is the expected feature gate name, and should we make changes accordingly? Apologies for any confusion on my part.

@chanieljdan
Copy link

Hi @jpbetz 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.

Thank you!

Daniel

@hailkomputer
Copy link
Member

Hi @jpbetz

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@chanieljdan
Copy link

Hi @jpbetz 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.

Thank you!

Daniel

Hi @jpbetz 👋,

Just a reminder to open a placeholder PR against dev-1.31 branch in the k/website repo for this (steps available here). The deadline for this is a week away at Thursday June 27, 2024 18:00 PDT.

Thanks,

Daniel

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@hailkomputer
Copy link
Member

@jpbetz , friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

@jpbetz
Copy link
Contributor Author

jpbetz commented Jun 28, 2024

friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

Thanks, @hailkomputer I've created kubernetes/website#47022

@dipesh-rawat
Copy link
Member

Hey again @jpbetz 👋, 1.31 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With all the implementation(code related) PRs merged as per the issue description:

Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

This enhancement is now marked as tracked for code freeze for the 1.31 Code Freeze!

@dipesh-rawat dipesh-rawat moved this from Tracked for Enhancements Freeze to Tracked for Code Freeze in 1.31 Enhancements Tracking Jul 1, 2024
@Princesso Princesso moved this from Tracked for Code Freeze to Tracked for Doc Freeze in 1.31 Enhancements Tracking Jul 29, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 3, 2024

/milestone v1.32

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.31, v1.32 Sep 3, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Sep 3, 2024

/label lead-opted-in

@shecodesmagic
Copy link

shecodesmagic commented Sep 28, 2024

Hello @jpbetz 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage stable for v.132 (correct me, if otherwise)

Here’s where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.32. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@shecodesmagic shecodesmagic moved this to Tracked for enhancements freeze in 1.32 Enhancements Tracking Sep 28, 2024
@edithturn
Copy link

Hello @jpbetz, 👋🏼 this is Edith from the v1.32 Communications Team!

We’d love for you to consider writing a feature blog about your enhancement! ✍
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog, see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@AnshumanTripathi
Copy link

Hello @jpbetz 👋, this is Anshuman, 1.32 Docs Shadow here.
Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@edithturn
Copy link

edithturn commented Oct 28, 2024

Hello @jpbetz! 🙂 👋

This is a reminder to author your feature blog post!

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Thank you very much!
Edith from the v1.32 Shadow Communications Team

@shecodesmagic
Copy link

Hello @jpbetz 👋, Enhancements team here (again 😁 )

With all the implementation(code related) PRs merged as per the issue description:

This enhancement is now marked as tracked for code freeze for the v1.32 Code Freeze!

Please note that KEPs targeting stable need to have the status field marked as implemented in the kep.yaml file after code PRs are merged and the feature gates are removed.

@shecodesmagic shecodesmagic moved this from Tracked for enhancements freeze to Tracked for code freeze in 1.32 Enhancements Tracking Oct 30, 2024
@jpbetz
Copy link
Contributor Author

jpbetz commented Oct 30, 2024

Please note that KEPs targeting stable need to have the status field marked as implemented in the kep.yaml file after code PRs are merged and the feature gates are removed.

Thanks for the reminder!

With the introduction of emulation versions, we do need to start keeping feature gates in code for 3 additional releases after promotions to stable. Who on the release team should we talk to about changing this guidance to prevent contributors from removing feature gates too soon?

cc @aaron-prindle @yongruilin

@katcosgrove
Copy link
Contributor

Hey @jpbetz!

I'm one of the release team subproject owners. This feels out of scope for the release team. Updating the guidance around feature gate removal would belong to SIG Architecture, imo (either the Enhancements subproject or PRR). However, we're happy to help you publicize an update in that guidance either in the form of a feature blog for the release or an email to dev.

CCing the current Release Comms lead in case you want a feature blog: @mbianchidev

@mbianchidev
Copy link
Member

CCing the current Release Comms lead in case you want a feature blog: @mbianchidev

Thanks for mentioning me, Kat!

@jpbetz in case you want to write a blog you can find all the guidelines in the upper comment that Edith left on this very issue!

For anything else, e.g. a specific mention on the final release blog, let me know and we can work on that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked for Doc Freeze
Status: Tracked for code freeze
Status: Tracked for Doc Freeze
Development

No branches or pull requests