Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more granular failure reason for Job PodFailurePolicy #4443

Open
1 of 4 tasks
danielvegamyhre opened this issue Jan 26, 2024 · 23 comments
Open
1 of 4 tasks

Add more granular failure reason for Job PodFailurePolicy #4443

danielvegamyhre opened this issue Jan 26, 2024 · 23 comments
Assignees
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team wg/batch Categorizes an issue or PR as relevant to WG Batch.

Comments

@danielvegamyhre
Copy link
Member

danielvegamyhre commented Jan 26, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 26, 2024
@danielvegamyhre
Copy link
Member Author

/sig apps
/wg batch

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. wg/batch Categorizes an issue or PR as relevant to WG Batch. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 26, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jan 26, 2024
@soltysh
Copy link
Contributor

soltysh commented Feb 6, 2024

/label lead-opted-in
/milestone v1.30
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 6, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 6, 2024
@salehsedghpour
Copy link

Hello @danielvegamyhre 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just want to update the following but it's not required for alpha stage and it will serve for future stages:

The status of this enhancement is marked as At risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

@salehsedghpour salehsedghpour moved this to At Risk for Enhancements Freeze in 1.30 Enhancements Tracking Feb 8, 2024
@salehsedghpour
Copy link

Hello 👋, 1.30 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in 1.30, please file an exception request. Thanks!

@salehsedghpour salehsedghpour moved this from At Risk for Enhancements Freeze to Removed from Milestone in 1.30 Enhancements Tracking Feb 9, 2024
@salehsedghpour
Copy link

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.30 milestone Feb 9, 2024
@soltysh
Copy link
Contributor

soltysh commented Apr 26, 2024

/label lead-opted-in
/milestone v1.31
/stage alpha

@mickeyboxell
Copy link

mickeyboxell commented Jun 4, 2024

Hi @danielvegamyhre 👋 v1.31 Enhancements team here.

I wanted to check in as we approach the enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting alpha for v1.31. Please correct me if that isn't the case.

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP before the enhancements freeze.

For this KEP, we need to do the following:

The status of this enhancement is marked as at risk for enhancement freeze. We can mark it as tracked as soon as the above changes are merged. Please make sure to get this done before the enhancements freeze.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Let me know if you have any questions! Thank you!

@mickeyboxell mickeyboxell moved this to At Risk for Enhancements Freeze in 1.31 Enhancements Tracking Jun 4, 2024
@jpbetz jpbetz assigned jpbetz and unassigned jpbetz Jun 5, 2024
@salaxander
Copy link
Contributor

Hello @danielvegamyhre 👋, 1.31 Docs Shadow here.

Does the work related to this KEP planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

@sreeram-venkitesh
Copy link
Member

With #4479 merged, we can mark this KEP as tracked for enhancements freeze 🎉

@sreeram-venkitesh sreeram-venkitesh moved this from At Risk for Enhancements Freeze to Tracked for Enhancements Freeze in 1.31 Enhancements Tracking Jun 13, 2024
@mbianchidev
Copy link
Member

mbianchidev commented Jun 14, 2024

Hello there @danielvegamyhre

👋 from the v1.31 Communications Team!
We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Edit: @danielvegamyhre can you assign this issue to yourself? So it's easier to check the owner on the GitHub project.
Thanks a lot!

@Princesso
Copy link

Hello @danielvegamyhre 👋, 1.31 Docs Lead here.
Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?
If so, please follow the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.
Thank you!

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@mbianchidev
Copy link
Member

Hello there @danielvegamyhre

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

Edit: @danielvegamyhre can you assign this issue to yourself? So it's easier to check the owner on the GitHub project. Thanks a lot!

Reminder of the 3rd of July deadline!
It's totally fine to also opt out if you don't think that writing a blog is useful for our users or if you don't have time (in that case team comms can also help you out 👀 )

@danielvegamyhre
Copy link
Member Author

Added placeholder PR kubernetes/kubernetes#125804

@mickeyboxell
Copy link

mickeyboxell commented Jul 3, 2024

Hey again @danielvegamyhre 👋 Kubernetes 1.31 Enhancements team here.

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

If you anticipate missing code freeze, you can file an [exception request](https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md) in advance.

Also, please let me know if there are other PRs in k/k we should be tracking for this KEP.

As always, we are here to help if any questions come up. Thanks!

The status of this enhancement is marked as at risk for code freeze.

@mickeyboxell mickeyboxell moved this from Tracked for Enhancements Freeze to At Risk for Code Freeze in 1.31 Enhancements Tracking Jul 3, 2024
@mickeyboxell
Copy link

Hey @danielvegamyhre 👋 Kubernetes 1.31 Enhancements team here.

Following up on the message above as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024. Please let me know if you have any questions.

@mickeyboxell
Copy link

Hello @danielvegamyhre 👋 Kubernetes 1.31 Enhancements team here,

Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the v1.31 milestone.

If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

@mickeyboxell mickeyboxell moved this from At Risk for Code Freeze to Removed from Milestone in 1.31 Enhancements Tracking Jul 24, 2024
@sreeram-venkitesh
Copy link
Member

/milestone clear

@tjons
Copy link
Contributor

tjons commented Sep 16, 2024

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 16, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2024
@tenzen-y
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2024
@soltysh
Copy link
Contributor

soltysh commented Jan 20, 2025

@tenzen-y @danielvegamyhre are you planning any work on this enhancement in 1.33?

@tenzen-y
Copy link
Member

@tenzen-y @danielvegamyhre are you planning any work on this enhancement in 1.33?

AFAIK, @danielvegamyhre is still working on implementations at kubernetes/kubernetes#125804
@danielvegamyhre Do you have any plans during the v1.33 cycle?

@danielvegamyhre
Copy link
Member Author

@tenzen-y @danielvegamyhre are you planning any work on this enhancement in 1.33?

AFAIK, @danielvegamyhre is still working on implementations at kubernetes/kubernetes#125804 @danielvegamyhre Do you have any plans during the v1.33 cycle?

I don't have any plans to continue work on this at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/apps Categorizes an issue or PR as relevant to SIG Apps. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team wg/batch Categorizes an issue or PR as relevant to WG Batch.
Projects
Status: Removed from Milestone
Status: Needs Triage
Status: Removed from Milestone
Development

No branches or pull requests