Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resilient Watchcache Initialization #4568

Open
2 of 4 tasks
wojtek-t opened this issue Apr 4, 2024 · 20 comments
Open
2 of 4 tasks

Resilient Watchcache Initialization #4568

wojtek-t opened this issue Apr 4, 2024 · 20 comments
Assignees
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@wojtek-t
Copy link
Member

wojtek-t commented Apr 4, 2024

Enhancement Description

/sig api-machinery
/sig scalability
/milestone v1.31

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 4, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 4, 2024
@k8s-ci-robot k8s-ci-robot added the sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. label Apr 4, 2024
@wojtek-t
Copy link
Member Author

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 29, 2024
@wojtek-t wojtek-t self-assigned this Jun 3, 2024
@dipesh-rawat
Copy link
Member

Hello @wojtek-t 👋, 1.31 Enhancements team here.

Just checking in as we approach enhancements freeze on on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage beta for 1.31 (correct me, if otherwise)
/stage beta

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP.

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jun 5, 2024
@dipesh-rawat dipesh-rawat moved this to Tracked for Enhancements Freeze in 1.31 Enhancements Tracking Jun 5, 2024
@chanieljdan
Copy link

Hi @wojtek-t 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.

Thank you!

Daniel

@hailkomputer
Copy link
Member

Hi @wojtek-t

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@chanieljdan
Copy link

Hi @wojtek-t 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.

Thank you!

Daniel

Hi @wojtek-t 👋,

Just a reminder to open a placeholder PR against dev-1.31 branch in the k/website repo for this (steps available here). The deadline for this is a week away at Thursday June 27, 2024 18:00 PDT.

Thanks,

Daniel

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@chanieljdan
Copy link

Hi @wojtek-t 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarized with the docs requirement for the release.

Thank you!

Daniel

Hi @wojtek-t 👋,

Just a reminder to open a placeholder PR against dev-1.31 branch in the k/website repo for this (steps available here) if it requires docs. The deadline for this is tomorrow at Thursday June 27, 2024 18:00 PDT.

Thanks,

Daniel

@hailkomputer
Copy link
Member

@wojtek-t , friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

@dipesh-rawat
Copy link
Member

Hey again @wojtek-t 👋, 1.31 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 24th July 2024 / 19:00 PDT Tuesday 23rd July 2024.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

With all the implementation(code related) PRs merged as per the issue description:

Additionally, please let me know if there are any other PRs in k/k not listed in the description that we should track for this KEP, so that we can maintain accurate status.

This enhancement is now marked as tracked for code freeze for the 1.31 Code Freeze!

@dipesh-rawat dipesh-rawat moved this from Tracked for Enhancements Freeze to Tracked for Code Freeze in 1.31 Enhancements Tracking Jul 1, 2024
@wojtek-t
Copy link
Member Author

wojtek-t commented Jul 2, 2024

@dipesh-rawat - I just linked another PR for it - with the second one (already merged too), we're ready for code-freeze.

@dipesh-rawat
Copy link
Member

@wojtek-t Thanks for informing about the other PR kubernetes/kubernetes#125483 related to this KEP. Could we also please add this PR in the issue description (here) for tracking purposes?

@wojtek-t
Copy link
Member Author

Docs PR: kubernetes/website#47063

@Princesso Princesso moved this from Tracked for Code Freeze to Tracked for Doc Freeze in 1.31 Enhancements Tracking Jul 29, 2024
@tjons
Copy link
Contributor

tjons commented Sep 16, 2024

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 16, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 14, 2025
@wojtek-t
Copy link
Member Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 14, 2025
@jpbetz
Copy link
Contributor

jpbetz commented Jan 25, 2025

@wojtek-t @serathius Is there anything preventing this from graduating to GA in 1.33? Anyone willing to own graduating this? If so let me know and I'll add it to the v1.33 milestone.

@jpbetz
Copy link
Contributor

jpbetz commented Jan 27, 2025

Is there any plan to progress this to stable in 1.33? Should sig-api-machinery opt-in to this for milestone v1.33? (cc @serathius)

@serathius
Copy link
Contributor

@wojtek-t is out, I don't have enough context to know how much work is left. Will try to take a look.

@serathius
Copy link
Contributor

I think there are two parts of KEPs that need considered separately:

  • WatchCacheInitializationPostStartHook is Beta feature flag disabled by default, we might want to make it default, but I don't think did any additional experiments that would inform since we decided to not make it default.
  • ResilientWatchCacheInitialization has been enabled on since 1.31, so it seems mature enough, however I don't know if we have answered whether we should adjust requests delegated to etcd. I think the conditional passthrough based on labels and limit adds needless complexity, but I don't know how concrete is the risk of delayed initialization. Would be nice to confirm or reject it.

@wojtek-t
Copy link
Member Author

Sorry, I was OOO last weeks. I will not get to it for 1.33 upstream, but here is what I would like to happen:

  • WatchCacheInitializationPostStartHook - this is disabled because we originally agreed with David that he would like to see some production data before enabling it in upstream by default. We should try to enable it in GKE for 1.33 and based on that enable in upstream in 1.34
  • ResilientWatchCacheInitialization - I think this is ready for ga promotion. We can tune it further (e.g. what Marek wrote above), but this is imho incremental and I wouldn't block ga on it, and rather change is separately if we believe it would work better. So let's target ga of it for 1.34 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
No open projects
Status: Tracked for Doc Freeze
Development

No branches or pull requests

10 participants