-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4622: Add a TopologyManager policy option for MaxAllowableNUMANodes #4622
Comments
/sig node |
/assign @cyclinder |
I've added this to the tracking sheet for 1.31: |
/label lead-opted-in |
Hello @cyclinder @klueska 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024. This enhancement is targeting stage Here's where this enhancement currently stands:
For this KEP, it looks like we still need to do the following:
The status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
In this case we are opting in the new sig-arch recommendations: kubernetes/community@d060ec0 and starting directly to beta stage as the change is very safe and self-contained. |
@ffromani @cyclinder I can update targeting for this enhancement, could you please update the issue description with the stages and targeted milestones accordingly? |
/stage beta |
Hi @Priann, I've updated the PR descriptions, Is this okay with you? and please let me know if you need me to update anything else. |
@cyclinder: The description looks good, please make sure to get #4624 merged before the enhancements freeze deadline! |
@cyclinder @klueska This is super close to being merged it looks like, but we’re at the freeze deadline. Please file an exception if you want this included in the release. |
@prianna We've already received an exception request for this KEP for 1 day. We can keep this as |
Yes, I preemptively filed an exception request yesterday. It looks like the PR is now merged though. |
@klueska Awesome, thanks for the update! I will update the KEP once I get to my laptop. |
Hey @sreeram-venkitesh can you let me know if this one will be officially moved to Tracked for Enhancement Freeze? 👀 |
Yes it will be, I'm traveling right now. I will update it in the board in some time. |
Thanks @sreeram-venkitesh! Sooo hey @cyclinder 👋 from the v1.31 Communications Team! To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines. Note: In your placeholder PR, use |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Do we want to go ahead with graduation of this KEP to GA in v1.33? 1.33 planning will be happening soon. |
we totally should! |
hey @cyclinder ! are you willing to move forward towards GA in 1.33? If so we need to have a KEP update with PRR answers by Feb 6! |
@ffromani Yes, I will update this KEP these two days. thanks for your reminder. |
Hi @ffromani, As I recall it seems that all the PRRs have been passed, except that we may need to provide a metric for pod admission time, or to address the issue of state explosion as mentioned by https://github.com/kubernetes/enhancements/pull/4624#discussion_r1638757893? |
IIRC that should be correct. Nevertheless please make sure to push updates so the PRR team can make a pass and confirm or add further questions (apologies if you already pushed such PR, I missed it) |
Please note that KEP updates are needed at every stage for tracking purposes. Including any pending items from the last cycle, we need to ensure that the KEP metadata is updated. |
I think I have already pushed such PR, the only thing left is the pod admission time metric. Please correct me if I'm wrong. |
@swatisehgal I think the KEP metadata is up to date, I will update it if we have any updates. |
Take a look at this KEP which is also graduating to GA, as an example. It outlines the necessary steps to ensure this work is properly tracked. To ensure tracking by the PRR group, we need to update Please note that this is the minimum required for tracking purposes. The KEP update PR will also need approval from reviewers and approvers before we can proceed with the GA graduation. |
Hello @cyclinder, if you have submitted updates to graduate to GA, please link them in the issue body. Otherwise please consider posting such update so we can move forward to GA during this cycle. |
@ffromani sorry for the slow response, today I will submit the updates. thanks for your reminder. |
I just noticed that we have already the pod admission time metrics,see https://github.com/kubernetes/kubernetes/blob/9a9f10bc7b93ef13a83e39b262f4ea8bf2353e53/pkg/kubelet/cm/topologymanager/topology_manager.go#L219, so we have no more code changes. |
good, but we will still need some trivial code changes for the FG management and related |
Can you point out the potential place? I would appreciate it. thanks. |
something like https://github.com/kubernetes/kubernetes/pull/116525/files is the minimum:
|
yes correct! To summarize, I do expect some trivial code changes needed for GA graduation (vs no code changes needed). |
I submitted the updated kep to promote it to GA, see #5166. |
Enhancement Description
k/enhancements
) update PR(s): KEP-4622: New TopologyManager Policy: max-allowable-numa-nodes #4624k/k
) update PR(s): kubelet: Add a TopologyManager policy option: max-allowable-numa-nodes kubernetes#124148k/website
) update PR(s): KEP-4622: Add docs for TopologyManager policy option for MaxAllowableNUMANodes website#46870k/enhancements
) update PR(s): kep-4622: promote topologyMnagaer policy: max-allowable-numa-nodes to GA #5166k/k
) update PR(s):k/website
) update(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
Tasks
The text was updated successfully, but these errors were encountered: