Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VolumeSource: OCI Artifact and/or Image #4639

Open
5 of 9 tasks
sallyom opened this issue May 16, 2024 · 53 comments
Open
5 of 9 tasks

VolumeSource: OCI Artifact and/or Image #4639

sallyom opened this issue May 16, 2024 · 53 comments
Assignees
Labels
kind/design Categorizes issue or PR as related to design. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team

Comments

@sallyom
Copy link
Contributor

sallyom commented May 16, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 16, 2024
@sallyom
Copy link
Contributor Author

sallyom commented May 16, 2024

I've had informal discussions about this - there's enough interest IMO to open a KEP & I will present this issue at upcoming sig-node, sig-storage mtgs with a KEP draft

/sig node
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 16, 2024
@xing-yang
Copy link
Contributor

Can you use the Volume Populator? It allows you to create a PVC from an extenal data source. https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1495-volume-populators

@saschagrunert
Copy link
Member

Happy to support here from a SIG node perspective.

cc @kubernetes/sig-node-proposals

@k8s-ci-robot k8s-ci-robot added the kind/design Categorizes issue or PR as related to design. label May 16, 2024
@mikebrow
Copy link
Member

+1 happy to help from the SIG-Node/CRI and OCI image/distribution spec perspectives..

@SergeyKanzhelev
Copy link
Member

/label lead-opted-in
/milestone v1.31

as discussed at SIG Node meeting this week, we will try and see if this can make it to 1.31

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 23, 2024
@SergeyKanzhelev
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 23, 2024
@rhuss
Copy link

rhuss commented May 28, 2024

For reference, in KServe a workaround for directly accessing files within an OCI image is currently implemented and available via a sidecar approach ("modelcar") by leveraging root FS system access via the /proc filesystem when shareProcessNamespace: true is set on the Pod. You can find details in the KServe documentation and in the Design Document. It actually implements the desired behavior with current means, but of course is more or less just a workaround for the OCI volume type (as discussed here and raised already a long time ago in kubernetes/kubernetes#831).

So KServe would be more than happy to leverage such a volume type, and we are happy to support any efforts in this direction.

@sreeram-venkitesh
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jun 3, 2024
@sreeram-venkitesh
Copy link
Member

Hello @sallyom 👋, v1.31 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting for stage alpha for v1.31 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline (6th June) so that the PRR team has enough time to review your KEP before the enhancements freeze.

For this KEP, most of the above items are taken care of in #4642. We'd need to do the following:

  • Update the status from provisional to implementable in the kep.yaml file here
  • Create a prod-readiness yaml file as shown here.
  • Update the graduation criteria in the KEP readme file.
  • Make sure that the PRR questionnaire is filled.

The status of this enhancement is marked as At risk for enhancements freeze. Once the above tasks are done, I can mark it as tracked.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Let me know if you have any questions! Thank you!

@sreeram-venkitesh
Copy link
Member

@sallyom Pinging once again as a slight reminder that we're approaching the enhancements freeze deadline on 14th June, this Friday!

@dipesh-rawat
Copy link
Member

Hi @sallyom @SergeyKanzhelev 👋, 1.31 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze in few hours, at 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

The current status of this enhancement is marked as at risk for enhancement freeze. There are a few requirements mentioned in the comment #4639 (comment) that are addressed as part of PR #4642 which still needs to be merged.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat
Copy link
Member

dipesh-rawat commented Jun 14, 2024

Hello @sallyom @SergeyKanzhelev 👋, 1.31 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.31, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

@sreeram-venkitesh
Copy link
Member

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.31 milestone Jun 14, 2024
@bitoku
Copy link

bitoku commented Jun 21, 2024

/assign

@sreeram-venkitesh
Copy link
Member

Marked as tracked for enhancements freeze! Thanks everyone!

@Princesso
Copy link

Hello @bitoku, @sallyom 👋, 1.31 Docs Lead here.
Does this enhancement work planned for 1.31 require any new docs or modifications to existing docs?
If so, please follow the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.
Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.
Thank you!

@sudo-bmitch
Copy link
Contributor

Over on the OCI side, we've been seeing a lot of confusion on this new feature. People are getting the impression that OCI Artifacts are supported, while the non-goals exclude everything except an OCI Image from being supported without directly saying that OCI Artifacts are not supported. Can this be clarified in the KEP and blog posts, removing all references to OCI Artifacts or placing a large disclosure at the top, to avoid confusing users?

For reference, the guidance for creating an OCI Artifact is linked in the KEP already: https://github.com/opencontainers/image-spec/blob/main/artifacts-guidance.md. A key requirement listed there is that the config media type is not application/vnd.oci.image.config.v1+json, and it allows layer blobs with any arbitrary binary data, not limiting it to the tar layers.

@pacoxu
Copy link
Member

pacoxu commented Sep 14, 2024

kubernetes/kubernetes#108405 (comment)

  • Should oci volume pulling block other pod image pulls if the kubelet uses the default serialize-image-pulls? Currently, we shared the same image puller. A big model image pulling may block other new pod image pulling(startup) in the worst case.
  • And should we add this to the beta or GA criteria to change the image pull behavior or not count OCI volume as part of pod image pulling? Or is this expected behavior?

@saschagrunert
Copy link
Member

  • Should oci volume pulling block other pod image pulls if the kubelet uses the default serialize-image-pulls? Currently, we shared the same image puller. A big model image pulling may block other new pod image pulling(startup) in the worst case.
  • And should we add this to the beta or GA criteria to change the image pull behavior or not count OCI volume as part of pod image pulling? Or is this expected behavior?

Thank you for the input here! I personally think we should make as less exceptions in behavior as possible for OCI image volumes in comparison to regular images.

@tjons
Copy link
Contributor

tjons commented Sep 16, 2024

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 16, 2024
@saschagrunert
Copy link
Member

@tjons there is no graduation planned for this feature in v1.32.

@haircommander
Copy link
Contributor

/milestone v1.32
/label lead-opted-in

@tjons
Copy link
Contributor

tjons commented Sep 29, 2024

@saschagrunert @haircommander is there still no graduation planned for this feature in 1.32? If so, is the plan to iterate on alpha? and if not, why is this tracked for 1.32 :)?

@jenshu
Copy link

jenshu commented Oct 1, 2024

Hello @saschagrunert @sallyom 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting stage alpha for v1.32 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@sohankunkerkar
Copy link
Member

@saschagrunert @sallyom, I'm part of the SIG-NODE KEPs wrangler team for this release. It looks like the plan for this release is to push this feature to Beta. Could one of you open a PR to move it forward?

@haircommander
Copy link
Contributor

@saschagrunert is out this week, but I'm going to open a PR in his stead to get it on PRR's purview, then he'll probably correct all the incorrect stuff I've written next week 🙂

@haircommander
Copy link
Contributor

update: I've opened #4897

@haircommander
Copy link
Contributor

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Oct 2, 2024
@haircommander
Copy link
Contributor

/stage alpha
/remove-milestone v1.32
/remove-label lead-opted-in

I believe we won't make stage progress in 1.32. We can still push for subpath support but I don't think we need to track that here.

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status lead-opted-in Denotes that an issue has been opted in to a release labels Oct 10, 2024
@jenshu
Copy link

jenshu commented Oct 11, 2024

1.32 Enhancements team here. Per the above comments, I've updated the 1.32 status to deferred

@tjons
Copy link
Contributor

tjons commented Oct 11, 2024

/milestone clear

@k8s-ci-robot k8s-ci-robot modified the milestone: v1.32 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Deferred
Status: Removed
Status: Tracked for Doc Freeze
Development

No branches or pull requests