Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split L3 Cache Topology Awareness in CPU Manager #4800

Closed
4 tasks done
sphrasavath opened this issue Aug 21, 2024 · 28 comments
Closed
4 tasks done

Split L3 Cache Topology Awareness in CPU Manager #4800

sphrasavath opened this issue Aug 21, 2024 · 28 comments
Assignees
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Milestone

Comments

@sphrasavath
Copy link

sphrasavath commented Aug 21, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 21, 2024
@kannon92
Copy link
Contributor

Are you all going to update the KEP? That link is old so I'm not sure your design still applies?

@kannon92
Copy link
Contributor

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 22, 2024
@kannon92
Copy link
Contributor

First thing, please create a KEP PR where you fill in the template.

https://docs.google.com/document/d/1LpnMjGNsQyHOuVHMktIrjZsdRw9aKZ8djt354nAno6M/edit?usp=sharing

Does not suffice as a design doc.

@ffromani
Copy link
Contributor

First thing, please create a KEP PR where you fill in the template.

https://docs.google.com/document/d/1LpnMjGNsQyHOuVHMktIrjZsdRw9aKZ8djt354nAno6M/edit?usp=sharing

Does not suffice as a design doc.

@sphrasavath Please make sure to use the very latest KEP template (just use the tip of the main branch), the template changes over time.
I agree there are more details to be filled, most of them the KEP template will make explicit.

@haircommander
Copy link
Contributor

/assign @sphrasavath @wongchar @ajcaldelas

@k8s-ci-robot
Copy link
Contributor

@haircommander: GitHub didn't allow me to assign the following users: wongchar, ajcaldelas.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sphrasavath @wongchar @ajcaldelas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@haircommander
Copy link
Contributor

/milestone v1.32
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 17, 2024
@impact-maker
Copy link

impact-maker commented Sep 29, 2024

Hello @haircommander @sphrasavath 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@impact-maker impact-maker moved this to At risk for enhancements freeze in 1.32 Enhancements Tracking Sep 29, 2024
@sreeram-venkitesh sreeram-venkitesh moved this from Considered for release to Tracked in SIG Node 1.32 KEPs planning Oct 10, 2024
@impact-maker impact-maker moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.32 Enhancements Tracking Oct 11, 2024
@chanieljdan
Copy link

Hi @sphrasavath 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@wongchar
Copy link
Contributor

@chanieljdan created draft PR in k/website dev-1.32 for this enhancement. Docs in progress.
kubernetes/website#48340

@ajcaldelas
Copy link
Contributor

Hello @haircommander @sphrasavath 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@impact-maker I think we do have the prod-readiness merged already can we consider this checked marked as well?

@rytswd
Copy link
Member

rytswd commented Oct 16, 2024

Hi @sphrasavath @wongchar @ajcaldelas 👋 -- this is Ryota (@rytswd) from the v1.32 Communications Team!

For the v1.32 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

  • This introduces some breaking change(s)
  • This has significant impacts and/or implications to users
  • ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 30th Oct 2024? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

  • 02:00 UTC Wednesday, 30th Oct: Feature blog PR freeze
  • Monday, 25th Nov: Feature blogs ready for review
  • You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@BenTheElder
Copy link
Member

/retitle Split L3 Cache Topology Awareness in CPU Manager
[This is a Kubernetes Enhancement by definition of being an issue in this repo]

@k8s-ci-robot k8s-ci-robot removed this from the v1.32 milestone Jan 12, 2025
@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 12, 2025
bertinatto pushed a commit to bertinatto/kubernetes that referenced this issue Jan 16, 2025
similarly to what we do for the managed CPU (aka workload partitioning)
feature, introduce a master configuration file
`/etc/kubernetes/openshift-llc-alignment` which needs to be present for
the LLC alignment feature to be activated, in addition to the policy
option being required.

Note this replace the standard upstream feature gate check.

This can be dropped when the feature per  KEP
kubernetes/enhancements#4800 goes beta.

Signed-off-by: Francesco Romani <fromani@redhat.com>
bertinatto pushed a commit to bertinatto/kubernetes that referenced this issue Jan 16, 2025
similarly to what we do for the managed CPU (aka workload partitioning)
feature, introduce a master configuration file
`/etc/kubernetes/openshift-llc-alignment` which needs to be present for
the LLC alignment feature to be activated, in addition to the policy
option being required.

Note this replace the standard upstream feature gate check.

This can be dropped when the feature per  KEP
kubernetes/enhancements#4800 goes beta.

Signed-off-by: Francesco Romani <fromani@redhat.com>
bertinatto pushed a commit to bertinatto/kubernetes that referenced this issue Jan 24, 2025
similarly to what we do for the managed CPU (aka workload partitioning)
feature, introduce a master configuration file
`/etc/kubernetes/openshift-llc-alignment` which needs to be present for
the LLC alignment feature to be activated, in addition to the policy
option being required.

Note this replace the standard upstream feature gate check.

This can be dropped when the feature per  KEP
kubernetes/enhancements#4800 goes beta.

Signed-off-by: Francesco Romani <fromani@redhat.com>
bertinatto pushed a commit to bertinatto/kubernetes that referenced this issue Jan 27, 2025
similarly to what we do for the managed CPU (aka workload partitioning)
feature, introduce a master configuration file
`/etc/kubernetes/openshift-llc-alignment` which needs to be present for
the LLC alignment feature to be activated, in addition to the policy
option being required.

Note this replace the standard upstream feature gate check.

This can be dropped when the feature per  KEP
kubernetes/enhancements#4800 goes beta.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@haircommander haircommander moved this from Triage to Considered for release in SIG Node 1.33 KEPs planning Jan 28, 2025
@haircommander
Copy link
Contributor

/label lead-opted-in
/milestone v1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 31, 2025
@dipesh-rawat
Copy link
Member

Hello @sphrasavath @wongchar @ajcaldelas👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage beta for v1.33 (correct me, if otherwise)
/stage beta

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • Update the KEP README to include graduation criteria (here) for the Beta stage.
  • Ensure that the kep.yaml is update to mention latest-milestone: v1.33 and stage:beta
  • Ensure that the KEP has undergone a production readiness review and has been merged into k/enhancements.
  • Please update the issue description with the Beta stage PRs. This will assist the release team in tracking progress more effectively.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jan 31, 2025
@dipesh-rawat dipesh-rawat moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Jan 31, 2025
@wongchar
Copy link
Contributor

@dipesh-rawat this KEP will remain in alpha for v1.33.
We will target beta in the next cycle for v1.34

@dipesh-rawat
Copy link
Member

this KEP will remain in alpha for v1.33.

@wongchar Apologies for my oversight and lack of understanding here. Does this mean there is no planned work for this KEP in the v1.33 release? If so, could we remove the lead-opted-in label and v1.33 milestone (added as part of #4800 (comment)) so the release team stops tracking this? Additionally, updating the issue description would help provide more clarity.

@wongchar
Copy link
Contributor

@dipesh-rawat I see, we have a new issue created here (transferring owner) that will need the lead-opted-in label instead:
#5109

We will update the description for our plans in the v1.33 alpha cycle in the issue above

@haircommander
Copy link
Contributor

/remove-label lead-opted-in
/remove-milestone v1.33

should we close this then?

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jan 31, 2025
@kannon92
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@kannon92: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/node Categorizes an issue or PR as relevant to SIG Node. stage/beta Denotes an issue tracking an enhancement targeted for Beta status
Projects
Status: Done
Status: Tracked for code freeze
Status: Done
Development

No branches or pull requests