Allow zero value for Sleep Action of PreStop Hook

[sreeram-venkitesh]

Enhancement Description

• One-line enhancement description (can be used as a release note): Allows PreStop lifecycle handler's sleep action to have a zero value
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/4818-allow-zero-value-for-sleep-action-of-prestop-hook/README.md
• Discussion Link: Discussion in the GitHub thread of original KEP.
  • WIP: https://docs.google.com/document/d/1o01gH2ELPY-kjwgemjg3BbWiykx37ag-4VYwwJ1jBTw/edit?usp=sharing
• Primary contact (assignee): @sreeram-venkitesh
• Responsible SIGs: sig-node
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.32
  • Beta release target (x.y): 1.33
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-4818: Allow zero value for Sleep Action of PreStop Hook #4855
  • Code (k/k) update PR(s): KEP-4818: Relaxed validation for allowing zero in PreStop hook sleep action kubernetes#127094
  • Docs (k/website) update PR(s): KEP 4818: PodLifecycleSleepActionAllowZero website#48439
• Beta
  • KEP (k/enhancements) update PR(s): KEP 4818: Promote zero value for Pod Lifecycle Sleep action to beta #5139
  • Code (k/k) update PR(s):
    • fix(pod/util): fix typo in getting pod validation options kubernetes#129946
    • KEP 4818: PodLifecycleSleepActionAllowZero to Beta kubernetes#130621
  • Docs (k/website) update(s): KEP 4818: PodLifecycleSleepActionAllowZero beta graduation website#49858

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

[sreeram-venkitesh]

/sig node

[SergeyKanzhelev]

/milestone v1.32
/label lead-opted-in

[kannon92]

Based on @SergeyKanzhelev comments, I think we can move this to be "Considered For Release".

[impact-maker]

Hello @sreeram-venkitesh 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday, October 3rd, 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

• KEP has a production readiness review that has been merged into k/enhancements.
  The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[sreeram-venkitesh]

Thanks @impact-maker, the enhancements PR is already reviewed by the PRR team, I will resolve the comments and get it merged soon.

[sreeram-venkitesh]

@impact-maker The KEP PR #4855 has been merged!

[sreeram-venkitesh]

/stage alpha

[impact-maker]

@sreeram-venkitesh thanks! Everything looks good, I have updated the issue status to tracked for enhancements freeze

[chanieljdan]

Hi @sreeram-venkitesh 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[sreeram-venkitesh]

@chanieljdan This KEP would need docs! It needs the following (noting it down here for myself as well):

• Document the new feature gate
• Update the docs for the original Sleep Action docs to mention that people can use this feature gate to use the zero value.

I will open the PR soon! Thanks!

[dipesh-rawat]

Hi @sreeram-venkitesh 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #4818 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[sreeram-venkitesh]

@dipesh-rawat @lzung Please take a look, #5139 has been merged! Thanks!

[dipesh-rawat]

Hello @sreeram-venkitesh 👋, 1.33 Enhancements team here,

Now that PR #5139 has been merged, all the KEP requirements are in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

(cc: @lzung)

/label tracked/yes

[Urvashi0109]

Hello @sreeram-venkitesh 👋, v1.33 Docs Shadow here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[sreeram-venkitesh]

@Urvashi0109: Docs PR opened: kubernetes/website#49858. For this KEP, this would be all the changes I believe (unless some changes are requested in the review of course).

[lzung]

Hey again @sreeram-venkitesh 👋, 1.33 Enhancements team here,

Just checking in as we approach code freeze at at 2:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• KEP 4818: PodLifecycleSleepActionAllowZero to Beta kubernetes#130621
• fix(pod/util): fix typo in getting pod validation options kubernetes#129946

Additionally, please let me know if there are any other PRs in k/k not listed above that we should track for this KEP, so that we can maintain accurate status.

If you anticipate missing code freeze, you can file an exception request in advance.

The status of this enhancement is marked as at risk for code freeze.

[aakankshabhende]

Hi @sreeram-venkitesh 👋 -- this is Aakanksha (@aakankshabhende ) from the 1.33 Communications Team!

For the 1.33 release, we are currently in the process of collecting and curating a list of potential feature blogs, and we'd love for you to consider writing one for your enhancement!

As you may be aware, feature blogs are a great way to communicate to users about features which fall into (but not limited to) the following categories:

• This introduces some breaking change(s)
• This has significant impacts and/or implications to users
• ...Or this is a long-awaited feature, which would go a long way to cover the journey more in detail 🎉

To opt in to write a feature blog, could you please let us know and open a "Feature Blog placeholder PR" (which can be only a skeleton at first) against the website repository by Wednesday, 5th March, 2025? For more information about writing a blog, please find the blog contribution guidelines 📚

Tip

Some timeline to keep in mind:

• 02:00 UTC Wednesday, 5th March, 2025: Feature blog PR freeze
• Monday, 7th April, 2025: Feature blogs ready for review
• You can find more in the release document

Note

In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[sreeram-venkitesh]

@aakankshabhende: Thanks for reaching out! This KEP doesn't require a feature blog. This is a small change involving the feature gate graduation only.

@lzung: I've updated the code PRs in the issue description. There would be another PR which does the featute gate graduation, I will update this soon.

[dipesh-rawat]

Hi @sreeram-venkitesh 👋, v1.33 Enhancements team here,

Just a quick friendly reminder as we approach the code freeze later this week, at 02:00 UTC Friday 21st March 2025 / 19:00 PDT Thursday 20th March 2025.

The current status of this enhancement is marked as At risk for code freeze. There are a few requirements mentioned in the comment #4818 (comment) that still need to be completed.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

[dipesh-rawat]

Hello @sreeram-venkitesh 👋, v1.33 Enhancements team here.

With all the implementation (code-related) PRs merged per the issue description:

• fix(pod/util): fix typo in getting pod validation options kubernetes#129946
• KEP 4818: PodLifecycleSleepActionAllowZero to Beta kubernetes#130621

This enhancement is now marked as Tracked for code freeze for the v1.33 Code Freeze!

Additionally, please let me know if there are any other PRs in k/k that we should track for this KEP, so that we can maintain accurate status.

[jenshu]

Hi @sreeram-venkitesh 👋, 1.34 Enhancements Lead here.

I am closing the v1.33 milestone now.

If you'd like to work on this enhancement in v1.34, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.34 using /milestone v1.34.

Thanks!

/remove-label lead-opted-in
/remove-label tracked/yes
/milestone clear