Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubectl Diff #491

Closed
seans3 opened this issue Oct 23, 2017 · 83 comments · Fixed by #1627
Closed

Kubectl Diff #491

seans3 opened this issue Oct 23, 2017 · 83 comments · Fixed by #1627
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@seans3
Copy link
Contributor

seans3 commented Oct 23, 2017

Feature Description

  • One-line feature description (can be used as a release note): Users can run a
    kubectl command to view the difference between a locally declared object
    configuration and the current state of a live object.
  • Primary contact (assignee): @apelisse
  • Responsible SIGs: @kubernetes/sig-cli
  • Design proposal link (community repo): https://goo.gl/UVsM6A
  • KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/20200115-kubectl-diff.md
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from
    code-area OWNERS file) agreed to review. Reviewers from multiple companies
    preferred: @pwittrock, @mengqiy
  • Approver (likely from SIG/area to which feature belongs): @pwittrock
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.8)
    • Beta release target (1.13)
    • Stable release target (1.18)
@seans3
Copy link
Contributor Author

seans3 commented Oct 23, 2017

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 23, 2017
@seans3
Copy link
Contributor Author

seans3 commented Oct 23, 2017

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Oct 23, 2017
@apelisse apelisse added this to the 1.9 milestone Oct 24, 2017
@apelisse apelisse self-assigned this Oct 24, 2017
@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Oct 24, 2017
@idvoretskyi idvoretskyi changed the title Kubectl Alpha Diff Kubectl Diff Nov 13, 2017
@zacharysarah
Copy link
Contributor

zacharysarah commented Nov 27, 2017

@seans3 👋 Please open a documentation PR and add a link to the 1.9 tracking spreadsheet. Thanks in advance!

@zacharysarah
Copy link
Contributor

zacharysarah commented Nov 28, 2017

@seans3 Bump for docs ☝️

/cc @idvoretskyi

@idvoretskyi
Copy link
Member

idvoretskyi commented Nov 30, 2017

@seans3 @apelisse @kubernetes/sig-cli-feature-requests any updates on the docs status?

A friendly reminder on docs deadline tomorrow.

/cc @zacharysarah

@apelisse
Copy link
Member

apelisse commented Nov 30, 2017

I've removed the needs-doc. Alpha features doesn't have to be documented on day one. Thanks

@fejta-bot
Copy link

fejta-bot commented Feb 28, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2018
@nottrobin
Copy link

nottrobin commented Mar 14, 2018

Where's the code for this feature? I understand there's not yet proper documentation, but I was hoping I might be able to read the code so understand what might be causing kubernetes/kubernetes#61145, which is an issue for me too.

@fejta-bot
Copy link

fejta-bot commented Apr 13, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 13, 2018
@nottrobin
Copy link

nottrobin commented Apr 13, 2018

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 13, 2018
@justaugustus
Copy link
Member

justaugustus commented Apr 17, 2018

@apelisse
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@pwittrock
Copy link
Member

pwittrock commented Apr 17, 2018

@apelisse Think we could move this out of alpha for 1.11?

@apelisse apelisse modified the milestones: v1.9, v1.11 Apr 17, 2018
@apelisse
Copy link
Member

apelisse commented Apr 17, 2018

@justaugustus We'll try to get everything ready for a nice alpha release in 1.11. Labels are up-to-date, I updated the milestone, thanks!

@justaugustus
Copy link
Member

justaugustus commented Apr 17, 2018

Thanks for getting the labels updated, @apelisse!
Would you mind also updating the feature targets within the description?

@palnabarun
Copy link
Member

palnabarun commented Jan 21, 2020

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jan 21, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 21, 2020

@palnabarun: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member

palnabarun commented Jan 21, 2020

Sorry, I accidentally closed the issue.

@palnabarun
Copy link
Member

palnabarun commented Jan 21, 2020

As an added note, I am updating the issue description with KEP PR.

@apelisse
Copy link
Member

apelisse commented Jan 21, 2020

@palnabarun
Copy link
Member

palnabarun commented Jan 26, 2020

@apelisse Just a friendly reminder, we are just 2 days away from the Enhancement Freeze (3 PM Pacific Time, Tuesday, January 28th).

@palnabarun
Copy link
Member

palnabarun commented Jan 27, 2020

@apelisse I see that the last activity on the KEP PR was 10 days ago. Let us know if any help is required from the release team to get more traction on this.

@apelisse
Copy link
Member

apelisse commented Jan 27, 2020

I'm on it today, thanks!

@palnabarun
Copy link
Member

palnabarun commented Jan 27, 2020

Awesome!

@palnabarun
Copy link
Member

palnabarun commented Jan 29, 2020

Updated the KEP link in the description.

@palnabarun
Copy link
Member

palnabarun commented Jan 29, 2020

@apelisse A small nit, the KEP status is set to Implemented whereas it should have been Implementable. Implemented is set after the release cycle when the enhancement graduates to stable.

Can you please set it to Implementable?

@palnabarun
Copy link
Member

palnabarun commented Feb 5, 2020

Hi @apelisse, just a friendly reminder that the Code Freeze will go into effect on Thursday 5th March.

Can you please link all the k/k PRs or any other PRs which should be tracked for this enhancement?

Thank You :)

@apelisse
Copy link
Member

apelisse commented Feb 5, 2020

We don't have any changes to do for this. We're working on improving the documentation at this point:

kubernetes/kubernetes#87805

@palnabarun
Copy link
Member

palnabarun commented Feb 5, 2020

Thank you @apelisse for the updates. :)

@sethmccombs
Copy link

sethmccombs commented Feb 6, 2020

Hey @apelisse -

Seth here, Docs shadow on the 1.18 release team.

Does this enhancement work planned for 1.18 require any new docs or modifications to existing docs?

If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If doc updates are required, reminder that the placeholder PRs against k/website (branch dev-1.18) are due by Friday, Feb 28th.

Let me know if you have any questions!

@apelisse
Copy link
Member

apelisse commented Feb 6, 2020

I think we've already updated the docs for this feature, but I'll make sure everything is up-to-date, thanks!

@VineethReddy02
Copy link

VineethReddy02 commented Feb 15, 2020

@apelisse If you have already updated the docs, Can you share the link to the PR here.
Thanks!

@apelisse
Copy link
Member

apelisse commented Feb 15, 2020

@julianvmodesto Do you happen to remember?

@julianvmodesto
Copy link
Member

julianvmodesto commented Feb 18, 2020

@zhouya0 merged a couple of PRs for docs here:

kubernetes/website#18665
kubernetes/website#18481

Issue: kubernetes/kubernetes#86525

@palnabarun
Copy link
Member

palnabarun commented Mar 23, 2020

Hi @apelisse, since this enhancement graduated to Stable this release 🚀, the status can now be set to be Implemented.

Can you please update the status? After that, we will close this issue.

@apelisse
Copy link
Member

apelisse commented Mar 23, 2020

#1627

@liskl
Copy link

liskl commented Mar 28, 2020

@julianvmodesto does this support the -k argument if you remember

Like can it diff what a kubectl apply -k --dry-run outputs agianst what's in the cluster?

@apelisse
Copy link
Member

apelisse commented Mar 28, 2020

I'm pretty sure it does. If it doesn't, then there must be a bug that should be fixed. I couldn't find a test that tests that so we should probably write one.

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.