Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubectl Diff #491

Open
seans3 opened this Issue Oct 23, 2017 · 38 comments

Comments

Projects
None yet
@seans3
Copy link

seans3 commented Oct 23, 2017

Feature Description

  • One-line feature description (can be used as a release note): Users can run a
    kubectl command to view the difference between a locally declared object
    configuration and the current state of a live object.
  • Primary contact (assignee): @apelisse
  • Responsible SIGs: @kubernetes/sig-cli
  • Design proposal link (community repo): https://goo.gl/UVsM6A
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from
    code-area OWNERS file) agreed to review. Reviewers from multiple companies
    preferred: @pwittrock, @mengqiy
  • Approver (likely from SIG/area to which feature belongs): @pwittrock
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.8)
    • Beta release target (1.13)
    • Stable release target (TBD)
@seans3

This comment has been minimized.

Copy link
Author

seans3 commented Oct 23, 2017

/kind feature

@seans3

This comment has been minimized.

Copy link
Author

seans3 commented Oct 23, 2017

/sig cli

@apelisse apelisse added this to the 1.9 milestone Oct 24, 2017

@apelisse apelisse self-assigned this Oct 24, 2017

@idvoretskyi idvoretskyi changed the title Kubectl Alpha Diff Kubectl Diff Nov 13, 2017

@zacharysarah

This comment has been minimized.

Copy link
Contributor

zacharysarah commented Nov 27, 2017

@seans3 👋 Please open a documentation PR and add a link to the 1.9 tracking spreadsheet. Thanks in advance!

@zacharysarah

This comment has been minimized.

Copy link
Contributor

zacharysarah commented Nov 28, 2017

@seans3 Bump for docs ☝️

/cc @idvoretskyi

@idvoretskyi

This comment has been minimized.

Copy link
Member

idvoretskyi commented Nov 30, 2017

@seans3 @apelisse @kubernetes/sig-cli-feature-requests any updates on the docs status?

A friendly reminder on docs deadline tomorrow.

/cc @zacharysarah

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Nov 30, 2017

I've removed the needs-doc. Alpha features doesn't have to be documented on day one. Thanks

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 28, 2018

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@nottrobin

This comment has been minimized.

Copy link

nottrobin commented Mar 14, 2018

Where's the code for this feature? I understand there's not yet proper documentation, but I was hoping I might be able to read the code so understand what might be causing kubernetes/kubernetes#61145, which is an issue for me too.

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Apr 13, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@nottrobin

This comment has been minimized.

Copy link

nottrobin commented Apr 13, 2018

/remove-lifecycle rotten

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Apr 17, 2018

@apelisse
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@pwittrock

This comment has been minimized.

Copy link
Member

pwittrock commented Apr 17, 2018

@apelisse Think we could move this out of alpha for 1.11?

@apelisse apelisse modified the milestones: v1.9, v1.11 Apr 17, 2018

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Apr 17, 2018

@justaugustus We'll try to get everything ready for a nice alpha release in 1.11. Labels are up-to-date, I updated the milestone, thanks!

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Apr 17, 2018

Thanks for getting the labels updated, @apelisse!
Would you mind also updating the feature targets within the description?

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jun 4, 2018

@apelisse -- We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

I'm also noticing that you've moved this to the 1.12 milestone. Was this intentional? Is there no work planned for the 1.11 milestone?

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Jun 4, 2018

Hi @justaugustus, this feature was already released as alpha feature a couple of releases before. I don't plan on getting this out of alpha before 1.12. So technically, I think we could get rid of it from the tracking spreadsheet?

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jun 4, 2018

Sounds good. Thanks @apelisse!

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 18, 2018

@apelisse @kubernetes/sig-cli-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@apelisse apelisse modified the milestones: v1.12, v1.13 Jul 18, 2018

@apelisse apelisse added stage/beta and removed stage/alpha labels Jul 18, 2018

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Jul 18, 2018

@justaugustus this is already in alpha for a while, it will move to beta in 1.13.

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 18, 2018

Thanks for the update, @apelisse!

@jordansissel

This comment has been minimized.

Copy link

jordansissel commented Aug 30, 2018

I had trouble finding out how to invoke diff from this and other issues.

Documenting for posterity, the alpha diff command is available as a subcommand under kubectl alpha, for example:

kubectl alpha diff -f mything.yml
@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Oct 17, 2018

@apelisse what work remains to be done to move this to beta in v1.13? are there issues or PRs we could link to track this?

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Oct 17, 2018

kubernetes/kubernetes#68526. Very close to be ready, I suspect we mostly need documentation!

@npentrel

This comment has been minimized.

Copy link

npentrel commented Oct 25, 2018

Hi @apelisse, I'm Naomi and working on docs for the 1.13 release. Could you open up a docs PR against the dev-1.13 branch as a placeholder for the needed docs updates?

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Oct 30, 2018

@npentrel Where should I open the PR (which repo?) and what should be the content (what do you mean placeholder)? Thanks!

@npentrel

This comment has been minimized.

Copy link

npentrel commented Oct 31, 2018

The PR should be opened against kubernetes/website and the branchdev-1.13. Let me know once you've created that and I will add it to the tracking sheet! Thanks!

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Oct 31, 2018

Is that good: kubernetes/website#10789?

@npentrel

This comment has been minimized.

Copy link

npentrel commented Oct 31, 2018

Perfect, thanks!

@AishSundar

This comment has been minimized.

Copy link

AishSundar commented Nov 12, 2018

@npentrel and @apelisse could you provide the latest status on this please? The last update was quite a while before and I dont see any active progress post that. Please list any pending PRs (code, test and doc) needed for 1.13 and ETA for those to be merged. We are nearing Code freeze ths Friday 11/16 and we would like all PRs merged early this week to watch and stabilize the feature.

Please let us know asap if that isn't feasible.

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Nov 12, 2018

Hey @AishSundar, I consider this feature complete for a while now, I'll send another PR early next week with an extra test to make sure everything works fine, and also there is the documentation PR open, but we're good to go!

@apelisse apelisse referenced this issue Nov 21, 2018

Open

Kubectl Diff path to GA #68526

12 of 13 tasks complete
@claurence

This comment has been minimized.

Copy link

claurence commented Jan 14, 2019

@apelisse Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - I can't find a KEP for this issue, if one exists can you drop a link?

@apelisse apelisse removed this from the v1.13 milestone Jan 14, 2019

@apelisse

This comment has been minimized.

Copy link
Member

apelisse commented Jan 14, 2019

No plans for now. This feature was started before the KEP process was initiated. I'll try to come-up with something one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.