Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable tolerance for Horizontal Pod Autoscalers #4951

Open
1 of 4 tasks
jm-franc opened this issue Nov 6, 2024 · 15 comments
Open
1 of 4 tasks

Configurable tolerance for Horizontal Pod Autoscalers #4951

jm-franc opened this issue Nov 6, 2024 · 15 comments
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@jm-franc
Copy link
Contributor

jm-franc commented Nov 6, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 6, 2024
@jm-franc
Copy link
Contributor Author

jm-franc commented Nov 6, 2024

/sig autoscaling

@k8s-ci-robot k8s-ci-robot added sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 6, 2024
@jm-franc jm-franc changed the title Allow Horizontal Pod Autoscalers to set custom tolerances Allow Horizontal Pod Autoscalers to configure tolerances Nov 6, 2024
@jm-franc jm-franc changed the title Allow Horizontal Pod Autoscalers to configure tolerances Configurable tolerance for Horizontal Pod Autoscalers Nov 6, 2024
@adrianmoisey adrianmoisey moved this to Uncommitted or new in SIG Autoscaling KEPs Jan 20, 2025
@adrianmoisey
Copy link
Member

If we plan for this KEP to land in 1.33, there are a few more steps needed to be completed: https://github.com/kubernetes/community/blob/master/sig-architecture/production-readiness.md#submitting-a-kep-for-production-readiness-approval

@gjtempleton
Copy link
Member

/label lead-opted-in
/milestone 1.33

@k8s-ci-robot
Copy link
Contributor

@gjtempleton: The provided milestone is not valid for this repository. Milestones in this repository: [v1.25, v1.27, v1.28, v1.29, v1.30, v1.31, v1.32, v1.33, v1.34]

Use /milestone clear to clear the milestone.

In response to this:

/label lead-opted-in
/milestone 1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gjtempleton
Copy link
Member

/milestone v1.33

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Jan 23, 2025
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Jan 23, 2025
@adrianmoisey
Copy link
Member

Hey @jm-franc,
Your PR was approved and merged, and we have a lead-opted-in label here, so it seems like this KEP may be almost good to go with 1.33!
Just to help push it along, I think the following needs to happen:

My main worry is the Production Readiness Review. I'm not too familiar with the process, and I think the deadline is soon.
Let me know if there's anything I can do to help push this forward, it would be nice to see sig-autoscaling landing a KEP in 1.33!

@jm-franc
Copy link
Contributor Author

My main worry is the Production Readiness Review. I'm not too familiar with the process, and I think the deadline is soon. Let me know if there's anything I can do to help push this forward, it would be nice to see sig-autoscaling landing a KEP in 1.33!

Thanks Adrian! I sent #5094 and
#5093 for review, I hope they'll be merged before the Feb 6th deadline.

@adrianmoisey
Copy link
Member

Perfect, thanks!

@fykaa
Copy link
Member

fykaa commented Feb 4, 2025

Hello @jm-franc 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise)
/stage alpha

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.33.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

  • KEP status should be marked as implementable
  • KEP should have a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Feb 4, 2025
@fykaa fykaa moved this to At risk for enhancements freeze in 1.33 Enhancements Tracking Feb 4, 2025
@jm-franc
Copy link
Contributor Author

jm-franc commented Feb 4, 2025

Hello @jm-franc 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.
This enhancement is targeting stage alpha for v1.33 (correct me, if otherwise) /stage alpha
[...]

  • KEP should have a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

Thank you @fykaa ! I've submitted the PRR questionnaire that marks this feature as 'implementable' for review (#5094) and I hope to have it approved before the deadline. Fingers crossed :)

Thank you,
JM

@dipesh-rawat
Copy link
Member

Hi @jm-franc 👋, 1.33 Enhancements team here,

Just a quick friendly reminder as we approach the enhancements freeze later this week, at 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

The current status of this enhancement is marked as At risk for enhancement freeze. There are a few requirements mentioned in the comment #4951 (comment) that still need to be completed.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@dipesh-rawat
Copy link
Member

Hello @jm-franc 👋, 1.33 Enhancements team here.

Now that PR #5094 has been merged, all the KEP requirements are in place and merged into k/enhancements.

Before the enhancement freeze, it would be appreciated if following nit could be addressed:

Aside from the minor nit mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is now marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!
(cc: @fykaa)

/label tracked/yes

@k8s-ci-robot k8s-ci-robot added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 12, 2025
@dipesh-rawat dipesh-rawat moved this from At risk for enhancements freeze to Tracked for enhancements freeze in 1.33 Enhancements Tracking Feb 12, 2025
@jm-franc
Copy link
Contributor Author

Done & thank you Dipesh!

@rayandas
Copy link
Member

Hello @jm-franc 👋, v1.33 Docs Lead here.

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

If so, please follow the steps here to open a PR against dev-1.33 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday 27th February 2025 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@jm-franc
Copy link
Contributor Author

Does this enhancement work planned for v1.33 require any new docs or modification to existing docs?

Thank you Ryan, will do! There are indeed updates required to the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked for enhancements freeze
Status: Uncommitted or new
Development

No branches or pull requests

7 participants