Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configurable pod resolv.conf #504

Closed
MrHohn opened this issue Oct 27, 2017 · 46 comments

Comments

@MrHohn
Copy link
Member

commented Oct 27, 2017

Feature Description

  • One-line feature description (can be used as a release note): Support configurable pod resolv.conf.
  • Primary contact (assignee): @MrHohn
  • Responsible SIGs: sig-network
  • Design proposal link (community repo): kubernetes/community#1276
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @bowei
  • Approver (likely from SIG/area to which feature belongs): @thockin
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.9)
    • Beta release target (1.10)
    • Stable release target (1.14)
@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Oct 27, 2017

/sig network

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Oct 27, 2017

/assign

@idvoretskyi idvoretskyi added this to the v1.9 milestone Nov 13, 2017

vdemeester pushed a commit to vdemeester/kubernetes that referenced this issue Nov 16, 2017

Kubernetes Submit Queue
Merge pull request kubernetes#55651 from MrHohn/kubelet-dns-pkg
Automatic merge from submit-queue (batch tested with PRs 55657, 54758, 47584, 55758, 55651). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Move DNS related kubelet codes into its own package

**What this PR does / why we need it**:
Ref kubernetes/enhancements#504, this PR rearranges DNS related kubelet codes into its own pacakge and adds an OWNERS file.

Again, there is no functional changes, just that codes are moved around and couple fields (`clusterDomain`, `clusterDNS`, `resolverConfig`) are replaced with a `dnsConfigurer` struct.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE 

**Special notes for your reviewer**:
/assign @bowei @thockin 

**Release note**:

```release-note
NONE
```

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Nov 22, 2017

Kubernetes Submit Queue
Merge pull request #55848 from MrHohn/custom-pod-dns-api
Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add Custom Pod DNS to Kubernetes API

**What this PR does / why we need it**:
Ref:
- Feature issue: kubernetes/enhancements#504
- Proposal: kubernetes/community#1276

This PR adds the relevant APIs, validation check and the underlying kubelet changes.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE 

**Special notes for your reviewer**:
/sig network 
@kubernetes/sig-network-api-reviews 
/assign @bowei @thockin 

**Release note**:

```release-note
Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha).
```

sttts pushed a commit to sttts/api that referenced this issue Nov 27, 2017

Merge pull request #55848 from MrHohn/custom-pod-dns-api
Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add Custom Pod DNS to Kubernetes API

**What this PR does / why we need it**:
Ref:
- Feature issue: kubernetes/enhancements#504
- Proposal: kubernetes/community#1276

This PR adds the relevant APIs, validation check and the underlying kubelet changes.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE

**Special notes for your reviewer**:
/sig network
@kubernetes/sig-network-api-reviews
/assign @bowei @thockin

**Release note**:

```release-note
Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha).
```

Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

sttts pushed a commit to sttts/api that referenced this issue Nov 27, 2017

Merge pull request #55848 from MrHohn/custom-pod-dns-api
Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add Custom Pod DNS to Kubernetes API

**What this PR does / why we need it**:
Ref:
- Feature issue: kubernetes/enhancements#504
- Proposal: kubernetes/community#1276

This PR adds the relevant APIs, validation check and the underlying kubelet changes.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE

**Special notes for your reviewer**:
/sig network
@kubernetes/sig-network-api-reviews
/assign @bowei @thockin

**Release note**:

```release-note
Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha).
```

Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

sttts pushed a commit to sttts/api that referenced this issue Nov 28, 2017

Merge pull request #55848 from MrHohn/custom-pod-dns-api
Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add Custom Pod DNS to Kubernetes API

**What this PR does / why we need it**:
Ref:
- Feature issue: kubernetes/enhancements#504
- Proposal: kubernetes/community#1276

This PR adds the relevant APIs, validation check and the underlying kubelet changes.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE

**Special notes for your reviewer**:
/sig network
@kubernetes/sig-network-api-reviews
/assign @bowei @thockin

**Release note**:

```release-note
Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha).
```

Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

sttts pushed a commit to sttts/api that referenced this issue Nov 28, 2017

Merge pull request #55848 from MrHohn/custom-pod-dns-api
Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add Custom Pod DNS to Kubernetes API

**What this PR does / why we need it**:
Ref:
- Feature issue: kubernetes/enhancements#504
- Proposal: kubernetes/community#1276

This PR adds the relevant APIs, validation check and the underlying kubelet changes.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE

**Special notes for your reviewer**:
/sig network
@kubernetes/sig-network-api-reviews
/assign @bowei @thockin

**Release note**:

```release-note
Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha).
```

Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

sttts pushed a commit to sttts/api that referenced this issue Nov 28, 2017

Merge pull request #55848 from MrHohn/custom-pod-dns-api
Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add Custom Pod DNS to Kubernetes API

**What this PR does / why we need it**:
Ref:
- Feature issue: kubernetes/enhancements#504
- Proposal: kubernetes/community#1276

This PR adds the relevant APIs, validation check and the underlying kubelet changes.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE

**Special notes for your reviewer**:
/sig network
@kubernetes/sig-network-api-reviews
/assign @bowei @thockin

**Release note**:

```release-note
Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha).
```

Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

sttts pushed a commit to sttts/api that referenced this issue Nov 28, 2017

Merge pull request #55848 from MrHohn/custom-pod-dns-api
Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add Custom Pod DNS to Kubernetes API

**What this PR does / why we need it**:
Ref:
- Feature issue: kubernetes/enhancements#504
- Proposal: kubernetes/community#1276

This PR adds the relevant APIs, validation check and the underlying kubelet changes.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE

**Special notes for your reviewer**:
/sig network
@kubernetes/sig-network-api-reviews
/assign @bowei @thockin

**Release note**:

```release-note
Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha).
```

Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

k8s-publishing-bot pushed a commit to k8s-publishing-bot/api that referenced this issue Nov 29, 2017

Merge pull request #55848 from MrHohn/custom-pod-dns-api
Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add Custom Pod DNS to Kubernetes API

**What this PR does / why we need it**:
Ref:
- Feature issue: kubernetes/enhancements#504
- Proposal: kubernetes/community#1276

This PR adds the relevant APIs, validation check and the underlying kubelet changes.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE

**Special notes for your reviewer**:
/sig network
@kubernetes/sig-network-api-reviews
/assign @bowei @thockin

**Release note**:

```release-note
Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha).
```

Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

k8s-publishing-bot pushed a commit to k8s-publishing-bot/api that referenced this issue Dec 7, 2017

Merge pull request #55848 from MrHohn/custom-pod-dns-api
Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add Custom Pod DNS to Kubernetes API

**What this PR does / why we need it**:
Ref:
- Feature issue: kubernetes/enhancements#504
- Proposal: kubernetes/community#1276

This PR adds the relevant APIs, validation check and the underlying kubelet changes.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #NONE

**Special notes for your reviewer**:
/sig network
@kubernetes/sig-network-api-reviews
/assign @bowei @thockin

**Release note**:

```release-note
Add DNSConfig field to PodSpec and support "None" mode for DNSPolicy (Alpha).
```

Kubernetes-commit: 8a5cf788b0560c176bf219f26e893d97a19de1e2

@freehan freehan modified the milestones: v1.9, v1.10 Jan 22, 2018

@idvoretskyi

This comment has been minimized.

Copy link
Member

commented Jan 29, 2018

@MrHohn the feature is still labeled as alpha, but your plans for 1.10 were beta. What is the actual status of the feature for 1.10?

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2018

@idvoretskyi Thanks for checking in. This feature is targeting beta for 1.10.

/stage beta

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2018

Seems like I don't have the label privilege though. @idvoretskyi Would be great to use your help :)

@idvoretskyi idvoretskyi added stage/beta and removed stage/alpha labels Jan 29, 2018

@claurence claurence added this to the v1.14 milestone Jan 22, 2019

@claurence claurence added tracked/yes and removed tracked/no labels Jan 22, 2019

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2019

@claurence Thanks for handling the milestone and labels. To confirm, we need to merge the KEP PR (#700) before the Enhancements freeze, right?

@claurence

This comment has been minimized.

Copy link

commented Jan 24, 2019

@MrHohn we'd like the KEP in an implementable state by enhancements freeze.

@claurence

This comment has been minimized.

Copy link

commented Feb 11, 2019

@MrHohn Hello - enhancements lead here - looking at the KEP it is still marked as "provisional". What more is needed for it to move to "implementable"

Additionally are there any open PRs that should be tracked for this issue for the 1.14 release?

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Feb 11, 2019

@claurence Thanks for checking in. The KEP should be implementable --- I will update that.

One more open PR is kubernetes/website#12514 for the doc change.

@liggitt

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

kubernetes/kubernetes#72832 merged, no visible API changes

@claurence

This comment has been minimized.

Copy link

commented Feb 22, 2019

@MrHohn looking over the KEP I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Feb 22, 2019

@claurence We have comprehensive e2e tests implemented a while back, and that task was tracked by kubernetes/kubernetes#56521. I can retrospectively add testing plans to the KEP if that is preferable.

@claurence

This comment has been minimized.

Copy link

commented Feb 22, 2019

@MrHohn if you can add them to the KEP that would be great!

@lledru

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Hello @MrHohn , 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

@lledru Thanks for checking in. There is no open K/K PRs that need to merge. (I do need to send a PR to add testing plans to KEP but that is not K/K.)

@lledru

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Hi @MrHohn, when do you think you could merge PR #867 ? Just checked with my enhancement teammates, this information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.
If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release. Best regards

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2019

@lledru We will make sure to get that in before 1.14 code freeze (hopefully next Monday-ish).

@spiffxp

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

/remove-stage beta
/stage stable

@MrHohn

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

Closing this as it is GA with 1.14.

@MrHohn MrHohn closed this Apr 4, 2019

SIG-NETWORK automation moved this from KEP to Done Apr 4, 2019

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Jul 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.