New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NodePort IP address configurable #539

Closed
m1093782566 opened this Issue Jan 17, 2018 · 5 comments

Comments

Projects
None yet
6 participants
@m1093782566
Copy link
Member

m1093782566 commented Jan 17, 2018

Feature Description

  • One-line feature description (can be used as a release note):
    Make NodePort IP address configurable
  • Primary contact (assignee):
    @m1093782566
  • Responsible SIGs:
    /sig network
  • Design proposal link (community repo):
    kubernetes/community#1547
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
    @thockin @brendandburns
  • Approver (likely from SIG/area to which feature belongs):
    @thockin
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.10)
    • Beta release target (x.y)
    • Stable release target (x.y)
@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Jan 17, 2018

/assign

@idvoretskyi idvoretskyi added this to the v1.10 milestone Jan 22, 2018

heckj pushed a commit to heckj/kubernetes that referenced this issue Feb 27, 2018

Kubernetes Submit Queue
Merge pull request kubernetes#58052 from m1093782566/nodeip-config
Automatic merge from submit-queue (batch tested with PRs 60430, 60115, 58052, 60355, 60116). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Make nodeport ip configurable

**What this PR does / why we need it**:

By default, kube-proxy accepts everything from NodePort without any filter. It can be a problem for nodes which has both public and private NICs, and people only want to provide a service in private network and avoid exposing any internal service on the public IPs.

This PR makes nodeport ip configurable.

**Which issue(s) this PR fixes**:
Closes: kubernetes#21070

**Special notes for your reviewer**:

Design proposal see: kubernetes/community#1547

Issue in feature repo: kubernetes/enhancements#539

**Release note**:

```release-note
Make NodePort IP addresses configurable
```
@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Mar 3, 2018

Thanks @idvoretskyi !

@m1093782566

This comment has been minimized.

Copy link
Member Author

m1093782566 commented Mar 3, 2018

@islinwb we may need some documents.

@islinwb

This comment has been minimized.

Copy link
Member

islinwb commented Mar 3, 2018

@m1093782566 I'll work on that :)

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Apr 17, 2018

@m1093782566
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment