New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenRequest API and Kubelet integration #542

Open
mikedanese opened this Issue Jan 18, 2018 · 20 comments

Comments

Projects
None yet
10 participants
@mikedanese
Member

mikedanese commented Jan 18, 2018

Feature Description

  • One-line feature description (can be used as a release note): Add a TokenRequest API to request bound serviceaccount tokens.
  • Primary contact (assignee): @mikedanese
  • Responsible SIGs: sig-auth
  • Design proposal link (community repo): kubernetes/community#1460
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @liggitt @smarterclayton @cjcullen
  • Approver (likely from SIG/area to which feature belongs): @liggitt
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.10)
    • Beta release target (1.12)
    • Stable release target (x.y)

@mikedanese mikedanese added the sig/auth label Jan 18, 2018

@mikedanese mikedanese self-assigned this Jan 18, 2018

@mikedanese mikedanese added this to the v1.10 milestone Jan 18, 2018

@smarterclayton

This comment has been minimized.

Contributor

smarterclayton commented Jan 24, 2018

Should we add the use of the token request API to this bug as well? Specifically, consuming those tokens and allowing the service account token injector to be specialized?

@mikedanese mikedanese changed the title from TokenRequest API to TokenRequest API and Kubelet integration Jan 25, 2018

@mikedanese

This comment has been minimized.

Member

mikedanese commented Jan 25, 2018

@smarterclayton added that to this feature.

@Bradamant3

This comment has been minimized.

Member

Bradamant3 commented Mar 2, 2018

@mikedanese this item is listed on the feature tracking spreadsheet for 1.10 as needing docs. Does it in fact need them? If not, could you please update here? If so, could you please get a docs PR in against the 1.10 branch of the k8s/website repo asap? Thanks!

@Bradamant3

This comment has been minimized.

Member

Bradamant3 commented Mar 6, 2018

@mikedanese @smarterclayton docs update please? We need to get docs PRs merged by this Friday (March 9). Thanks!
/cc @idvoretskyi

@mikedanese

This comment has been minimized.

Member

mikedanese commented Mar 7, 2018

I added a comment. No docs needed.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

@mikedanese
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@mistyhacks

This comment has been minimized.

mistyhacks commented May 24, 2018

@mikedanese please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 4, 2018

@mikedanese -- We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Jul 23, 2018

@mikedanese This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12.

If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@justaugustus justaugustus removed this from the v1.11 milestone Jul 31, 2018

@mikedanese mikedanese added stage/beta and removed stage/alpha labels Jul 31, 2018

@mikedanese mikedanese added this to the v1.12 milestone Jul 31, 2018

@mikedanese

This comment has been minimized.

Member

mikedanese commented Jul 31, 2018

This is going to beta in 1.12

@justaugustus

This comment has been minimized.

Member

justaugustus commented Aug 4, 2018

Thanks for the update. I've added this to the 1.12 tracking sheet.

cc: @kacole2 @wadadli @robertsandoval @rajendar38

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @mikedanese I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

@mikedanese --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@mikedanese

This comment has been minimized.

Member

mikedanese commented Sep 7, 2018

Placeholder PR here: kubernetes/website#10216

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 11, 2018

Hey @mikedanese, as the docs are overdue, I'm removing this from the milestone.
If this assessment is incorrect, please let me know ASAP.

/milestone clear

@mikedanese

This comment has been minimized.

Member

mikedanese commented Sep 12, 2018

My understanding is that we have until Friday for docs. What am I missing?

@liggitt

This comment has been minimized.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 12, 2018

@mikedanese -- yep, what Jordan said. Docs submission deadline for SIGs was 9/7. The time between that deadline and the "Docs ready" date (9/18) is for the Docs team to do final copyedits.

Where are you at with docs for this?

@mikedanese mikedanese added this to the v1.12 milestone Sep 20, 2018

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Sep 28, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.12, v1.13 Sep 28, 2018

@mikedanese mikedanese removed this from the v1.13 milestone Oct 3, 2018

@mikedanese

This comment has been minimized.

Member

mikedanese commented Oct 3, 2018

Removing from v1.13. This will move from Beta to GA in a milestone after v1.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment