Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow end users to tweak maximum number of pids #546

Closed
dims opened this Issue Jan 23, 2018 · 16 comments

Comments

Projects
None yet
7 participants
@dims
Copy link
Member

dims commented Jan 23, 2018

Feature Description

  • One-line feature description (can be used as a release note): The alpha feature "SupportPodPidsLimit" is set by the cluster administrator. Application deployers should be able to request/tweak the limits for their own applications.
  • Primary contact (assignee): @dims
  • Responsible SIGs: /sig-node
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @derekwaynecarr @thockin @mtaufen @yujuhong
  • Approver (likely from SIG/area to which feature belongs): @thockin @derekwaynecarr
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.11
    • Beta release target (x.y): 1.12
    • Stable release target (x.y): 1.13
@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jan 23, 2018

Please see kubernetes/kubernetes#57973 for the alpha feature

@idvoretskyi

This comment has been minimized.

Copy link
Member

idvoretskyi commented Apr 12, 2018

@dims @kubernetes/sig-node-feature-requests can you confirm that this feature is targeting 1.11 as an alpha?

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Apr 12, 2018

@idvoretskyi apologies for not updating this issue. the code actually landed in 1.10 itself as alpha : https://k8s-code.appspot.com/?q=SupportPodPidsLimit&i=nope&files=&repos=

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Apr 12, 2018

@dims would you mind updating the description with anything that's changed since it was created?
/assign @dims

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jun 4, 2018

@dims --
We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

Also, is this feature graduating to Beta for 1.11? You mentioned that there was already work done for 1.10, so I just want to make sure we're tracking this accurately.

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jun 4, 2018

@justaugustus nothing has changed in v1.11 (compared to v1.10). No status change to Beta either. So we should be good for this one

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jun 4, 2018

@dims Thanks for the update!

@justaugustus justaugustus removed this from the v1.11 milestone Jun 4, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 18, 2018

@dims @kubernetes/sig-node-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@sjenning

This comment has been minimized.

Copy link
Contributor

sjenning commented Jul 23, 2018

fyi @smarterclayton @stevekuznetsov

any update on a plan to get this to Beta?

@dims

This comment has been minimized.

Copy link
Member Author

dims commented Jul 23, 2018

@sjenning i haven't gotten much feedback on the alpha. Other than one reference in a blog https://blog.jetstack.io/blog/hidden-gems-1.10/#pids-per-pod-limit

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 25, 2018

Sounds like this won't be making it in for 1.12, but let me know if that changes.

@kacole2

This comment has been minimized.

Copy link
Member

kacole2 commented Oct 8, 2018

Hi @dims
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post or take the opportunity to develop a KEP.

Thanks!

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 6, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Feb 5, 2019

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Mar 7, 2019

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 7, 2019

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.