New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows Container Configuration in CRI #547

Open
feiskyer opened this Issue Jan 24, 2018 · 19 comments

Comments

Projects
None yet
9 participants
@feiskyer
Member

feiskyer commented Jan 24, 2018

Feature Description

  • One-line feature description (can be used as a release note): Add support for Windows Container Configuration in CRI
  • Primary contact (assignee): @feiskyer @PatrickLang
  • Responsible SIGs: sig-node
  • Design proposal link (community repo): kubernetes/community#1510
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @yujuhong @dchen1107 @PatrickLang @michmike
  • Approver (likely from SIG/area to which feature belongs): sig-node sig-windows
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.10)
    • Beta release target (1.11)
    • Stable release target (1.12)
@PatrickLang

This comment has been minimized.

PatrickLang commented Apr 10, 2018

Should we close this issue since PRs are merged?

@JiangtianLi

This comment has been minimized.

JiangtianLi commented Apr 10, 2018

I think so. @feiskyer what do you think?

@feiskyer

This comment has been minimized.

Member

feiskyer commented Apr 11, 2018

@PatrickLang @JiangtianLi The original PR only adds CPU and memory. We should also add security context.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

@feiskyer @JiangtianLi
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@feiskyer feiskyer added stage/beta and removed stage/alpha labels Apr 17, 2018

@PatrickLang

This comment has been minimized.

PatrickLang commented Apr 25, 2018

I'll add some more comments on security contexts

@PatrickLang

This comment has been minimized.

PatrickLang commented May 14, 2018

I'm emailing with @feiskyer on this. I think the proposal will be just username at this time. Other options around namespaces, read only root, SELinux, ... aren't available on Windows.

@mistyhacks

This comment has been minimized.

mistyhacks commented May 24, 2018

@feiskyer please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 1, 2018

@feiskyer -- What's the current status of this feature?
As we haven't heard from you with regards to some items, this feature has been moved to the Milestone risks sheet within the 1.11 Features tracking spreadsheet.

Please update the line item for this feature on the Milestone risks sheet ASAP AND ping myself and @idvoretskyi, so we can assess the feature status or we will need to officially remove it from the milestone.

@feiskyer

This comment has been minimized.

Member

feiskyer commented Jun 4, 2018

@mistyhacks @justaugustus Sorry, OOF last week. The feature is on track and related codes change PR (kubernetes/kubernetes#64009) is under review. Please help to move it back. Thanks.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 4, 2018

@feiskyer I've moved it back into the main sheet.
Would you mind giving a look at each of the columns one more time to make sure everything is up to date?

@feiskyer

This comment has been minimized.

Member

feiskyer commented Jun 5, 2018

@justaugustus Already updated. Thanks

@feiskyer feiskyer modified the milestones: v1.11, v1.12 Jul 11, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

@feiskyer --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 29, 2018

/assign @JiangtianLi
/remove-stage beta
/stage stable

@feiskyer

This comment has been minimized.

Member

feiskyer commented Jul 30, 2018

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @feiskyer I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

@feiskyer @PatrickLang --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@feiskyer

This comment has been minimized.

Member

feiskyer commented Sep 6, 2018

No updates on this feature, let's move this out of v1.12.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.12 milestone Sep 6, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 6, 2018

Thanks for the update!

@justaugustus justaugustus added tracked/no and removed tracked/yes labels Sep 6, 2018

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 8, 2018

Hi @feiskyer @JiangtianLi
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment