New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule DaemonSet Pods by kube-scheduler #548

Open
k82cn opened this Issue Jan 29, 2018 · 31 comments

Comments

Projects
None yet
@k82cn
Member

k82cn commented Jan 29, 2018

Feature Description

@k82cn k82cn self-assigned this Jan 29, 2018

@bsalamat

This comment has been minimized.

Contributor

bsalamat commented Jan 31, 2018

@yastij

This comment has been minimized.

Member

yastij commented Feb 1, 2018

/cc

@kow3ns

This comment has been minimized.

Member

kow3ns commented Feb 2, 2018

  1. We had a long discussion about doing this here and decided not to. Is there a particular reason we should reconsider doing this now.
  2. Features are closed for 1.10. Also, I don't see how you could reasonably release this as stable in 1.10.
  3. We had the discussion in (1) prior to releasing DaemonSet to GA, is there a strong motivation to reconsider this now?
    /cc @janetkuo @bgrant0607
@bsalamat

This comment has been minimized.

Contributor

bsalamat commented Feb 3, 2018

@kow3ns There has been more discussions and the SIG scheduling has decided to go in this direction. @bgrant0607 has been in the loop in the discussions.

Please refer to this doc for more details: https://docs.google.com/document/d/1v7hsusMaeImQrOagktQb40ePbK6Jxp1hzgFB9OZa_ew/edit

@janetkuo

This comment has been minimized.

Member

janetkuo commented Mar 2, 2018

  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y) 1.10

From kubernetes/kubernetes#59630 this feature should be alpha, instead of stable. And if this targets 1.10, it needs to be added to 1.10 milestone.

Also, have any of you filed exception request for this feature?

@janetkuo

This comment has been minimized.

Member

janetkuo commented Mar 6, 2018

@jberkus the exception is filed here: https://groups.google.com/forum/#!topic/kubernetes-milestone-burndown/sPvjpRMf5es

Adding to v1.10 milestone to get attention from release team.

@janetkuo janetkuo added this to the v1.10 milestone Mar 6, 2018

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this issue Mar 11, 2018

Merge pull request #59862 from k82cn/k8s_59194_3
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Task 2: Schedule DaemonSet Pods by default scheduler.

Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>


**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
part of #59194
kubernetes/enhancements#548

**Release note**:

```release-note
When ScheduleDaemonSetPods is enabled, the DaemonSet controller will delegate Pods scheduling to default scheduler.
```

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this issue Mar 20, 2018

Merge pull request #61411 from liggitt/remove-ds-scheduling
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

disable DaemonSet scheduling feature for 1.10

The DaemonSet scheduling feature has blocked the alpha CI job being green and is preventing getting good CI signal for v1.10

It still contains pod scheduling races (#61050) and fundamental issues with the affinity terms it creates (#61410)

As such, there is not significant value in having the feature available in 1.10 in the current state

This PR disables the feature in order to regain green signal on the alpha CI job (reverting commits is likely to be more disruptive at this point)

related to #61050

```release-note
DaemonSet scheduling associated with the alpha ScheduleDaemonSetPods feature flag has been removed from the 1.10 release. See kubernetes/enhancements#548 for feature status.
```

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this issue Mar 21, 2018

Merge pull request #61412 from liggitt/automated-cherry-pick-of-#61411-…
…upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #61411: disable DaemonSet scheduling feature for 1.10

Cherry pick of #61411 on release-1.10.

related to #61050

#61411: disable DaemonSet scheduling feature for 1.10

```release-note
DaemonSet scheduling associated with the alpha ScheduleDaemonSetPods feature flag has been removed from the 1.10 release. See kubernetes/enhancements#548 for feature status.
```

@k82cn k82cn modified the milestones: v1.10, v1.11 Apr 4, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

@k82cn
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@k82cn

This comment has been minimized.

Member

k82cn commented Apr 17, 2018

  • Milestone: 1.11
  • Assignee(s): @k82cn

/stage alpha
/sig scheduling
/kind feature

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

Thanks for the update, @k82cn!

@mistyhacks

This comment has been minimized.

mistyhacks commented May 24, 2018

@k82cn please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@k82cn

This comment has been minimized.

Member

k82cn commented May 31, 2018

Doc for 1.11: kubernetes/website#8842

@mistyhacks

This comment has been minimized.

mistyhacks commented May 31, 2018

@justaugustus @idvoretskyi apparently this feature went in for 1.10 and it's just that it was missing docs until now. So I don't think it should be considered a 1.11 feature. Is that correct? At least the docs submitted in the linked docs PR only mention "1.10 and higher" several times.

@k82cn

This comment has been minimized.

Member

k82cn commented May 31, 2018

@mistyhacks , that should be 1.11; part of this feature are merged in 1.10 (which is considered as separate part), so I mark them 1.10 :).

@mistyhacks

This comment has been minimized.

mistyhacks commented May 31, 2018

Oh, ok. Thanks for the clarification.

@janetkuo

This comment has been minimized.

Member

janetkuo commented Jun 6, 2018

@k82cn

This comment has been minimized.

Member

k82cn commented Jul 3, 2018

/milestone v1.12
/stage beta

Assignee: @k82cn

We'd like to move this to beta in 1.12, so it can work together with priority/preemption :)

@k8s-ci-robot k8s-ci-robot added stage/beta and removed stage/alpha labels Jul 3, 2018

@k82cn

This comment has been minimized.

Member

k82cn commented Jul 3, 2018

We'd like to move this to beta in 1.12, so it can work together with priority/preemption :)

@mistyhacks , @justaugustus :)

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Jul 16, 2018

/cc

@bsalamat

This comment has been minimized.

Contributor

bsalamat commented Jul 16, 2018

@k82cn we should enable this feature by default in 1.12. I think it would be great if we could enable this as soon as possible and let it soak for a while before 1.12 code freeze.

@k82cn

This comment has been minimized.

Member

k82cn commented Jul 16, 2018

Sure, I'll work with Huang-Wei@ to make ready ASAP :)

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Jul 23, 2018

@k82cn @bsalamat is this still targeting Beta in 1.12? This still has the 1.11 milestone tagged as well so we need to update it accordingly.

If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Jul 23, 2018

@kacole2 as far as I know, yes. I'm working on it and will ping you guys for updates. Thanks!

@justaugustus justaugustus modified the milestones: v1.11, v1.12 Jul 25, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 25, 2018

Thanks for the update! This has been added to the 1.12 Tracking sheet.

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @k82cn I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Aug 21, 2018

@zparnold kubernetes/website#9923 is the placeholder.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

@k82cn @Huang-Wei --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@Huang-Wei

This comment has been minimized.

Member

Huang-Wei commented Sep 5, 2018

@justaugustus Yes, it's still targeting for 1.12.

  • code review is still in progress, and close to be merged
  • docs update (kubernetes/website#9923) is ready for review
@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 6, 2018

Thanks for the update!

@claurence

This comment has been minimized.

claurence commented Oct 5, 2018

Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP

@bsalamat

This comment has been minimized.

Contributor

bsalamat commented Oct 5, 2018

@claurence This feature is promoted to beta in 1.12 and there is no plan to graduate it in 1.13.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 5, 2018

thanks for the update!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.12 milestone Oct 5, 2018

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment