Schedule DaemonSet Pods by kube-scheduler

[k82cn]

Feature Description

• One-line feature description (can be used as a release note):
• Primary contact (assignee): @k82cn
• Responsible SIGs: sig-scheduling, sig-apps
• Design proposal link (community repo): Preemption support in DaemonSet controller , Schedule DaemonSet Pods by default scheduler
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @bsalamat , @timothysc , @bgrant0607 @janetkuo
• Approver (likely from SIG/area to which feature belongs): @bsalamat , @timothysc, @janetkuo
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y): 1.11
  • Beta release target (x.y): 1.12
  • Stable release target (x.y):

[bsalamat]

ref/ kubernetes/kubernetes#57471

[yastij]

/cc

[kow3ns]

1. We had a long discussion about doing this here and decided not to. Is there a particular reason we should reconsider doing this now.
2. Features are closed for 1.10. Also, I don't see how you could reasonably release this as stable in 1.10.
3. We had the discussion in (1) prior to releasing DaemonSet to GA, is there a strong motivation to reconsider this now?
   /cc @janetkuo @bgrant0607

[bsalamat]

@kow3ns There has been more discussions and the SIG scheduling has decided to go in this direction. @bgrant0607 has been in the loop in the discussions.

Please refer to this doc for more details: https://docs.google.com/document/d/1v7hsusMaeImQrOagktQb40ePbK6Jxp1hzgFB9OZa_ew/edit

[janetkuo]

• Feature target (which target equals to which milestone):
  • Alpha release target (x.y)
  • Beta release target (x.y)
  • Stable release target (x.y) 1.10

From kubernetes/kubernetes#59630 this feature should be alpha, instead of stable. And if this targets 1.10, it needs to be added to 1.10 milestone.

Also, have any of you filed exception request for this feature?

[janetkuo]

@jberkus the exception is filed here: https://groups.google.com/forum/#!topic/kubernetes-milestone-burndown/sPvjpRMf5es

Adding to v1.10 milestone to get attention from release team.

[justaugustus]

@k82cn
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

• Description
• Milestone
• Assignee(s)
• Labels:
  • stage/{alpha,beta,stable}
  • sig/*
  • kind/feature

cc @idvoretskyi

[k82cn]

• Milestone: 1.11
• Assignee(s): @k82cn

/stage alpha
/sig scheduling
/kind feature

[justaugustus]

Thanks for the update, @k82cn!

[mistyhacks]

@k82cn please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

[k82cn]

Doc for 1.11: kubernetes/website#8842

[mistyhacks]

@justaugustus @idvoretskyi apparently this feature went in for 1.10 and it's just that it was missing docs until now. So I don't think it should be considered a 1.11 feature. Is that correct? At least the docs submitted in the linked docs PR only mention "1.10 and higher" several times.

[k82cn]

@mistyhacks , that should be 1.11; part of this feature are merged in 1.10 (which is considered as separate part), so I mark them 1.10 :).

[mistyhacks]

Oh, ok. Thanks for the clarification.

[janetkuo]

@k82cn we need to change feature gate comment of this to 1.11 (instead of 1.10):
https://github.com/kubernetes/kubernetes/blob/c2e3d0526d788ae3792626bbc165101b8f5ada8e/pkg/features/kube_features.go#L251

[k82cn]

/milestone v1.12
/stage beta

Assignee: @k82cn

We'd like to move this to beta in 1.12, so it can work together with priority/preemption :)

[k82cn]

We'd like to move this to beta in 1.12, so it can work together with priority/preemption :)

@mistyhacks , @justaugustus :)

[Huang-Wei]

/cc

[bsalamat]

@k82cn we should enable this feature by default in 1.12. I think it would be great if we could enable this as soon as possible and let it soak for a while before 1.12 code freeze.

[k82cn]

Sure, I'll work with Huang-Wei@ to make ready ASAP :)

[kacole2]

@k82cn @bsalamat is this still targeting Beta in 1.12? This still has the 1.11 milestone tagged as well so we need to update it accordingly.

If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

---

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

[Huang-Wei]

@kacole2 as far as I know, yes. I'm working on it and will ping you guys for updates. Thanks!

[justaugustus]

Thanks for the update! This has been added to the 1.12 Tracking sheet.

[zparnold]

Hey there! @k82cn I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[Huang-Wei]

@zparnold kubernetes/website#9923 is the placeholder.

[justaugustus]

@k82cn @Huang-Wei --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[Huang-Wei]

@justaugustus Yes, it's still targeting for 1.12.

• code review is still in progress, and close to be merged
• docs update (kubernetes/website#9923) is ready for review

[justaugustus]

Thanks for the update!

[claurence]

Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP

[bsalamat]

@claurence This feature is promoted to beta in 1.12 and there is no plan to graduate it in 1.13.

[kacole2]

thanks for the update!
/milestone clear