Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule DaemonSet Pods by kube-scheduler #548

Closed
k82cn opened this issue Jan 29, 2018 · 53 comments
Closed

Schedule DaemonSet Pods by kube-scheduler #548

k82cn opened this issue Jan 29, 2018 · 53 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@k82cn
Copy link
Member

k82cn commented Jan 29, 2018

Feature Description

@k82cn k82cn self-assigned this Jan 29, 2018
@k82cn k82cn added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 29, 2018
@bsalamat
Copy link
Member

bsalamat commented Jan 31, 2018

ref/ kubernetes/kubernetes#57471

@yastij
Copy link
Member

yastij commented Feb 1, 2018

/cc

@kow3ns
Copy link
Member

kow3ns commented Feb 2, 2018

  1. We had a long discussion about doing this here and decided not to. Is there a particular reason we should reconsider doing this now.
  2. Features are closed for 1.10. Also, I don't see how you could reasonably release this as stable in 1.10.
  3. We had the discussion in (1) prior to releasing DaemonSet to GA, is there a strong motivation to reconsider this now?
    /cc @janetkuo @bgrant0607

@bsalamat
Copy link
Member

bsalamat commented Feb 3, 2018

@kow3ns There has been more discussions and the SIG scheduling has decided to go in this direction. @bgrant0607 has been in the loop in the discussions.

Please refer to this doc for more details: https://docs.google.com/document/d/1v7hsusMaeImQrOagktQb40ePbK6Jxp1hzgFB9OZa_ew/edit

@janetkuo
Copy link
Member

janetkuo commented Mar 2, 2018

  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y) 1.10

From kubernetes/kubernetes#59630 this feature should be alpha, instead of stable. And if this targets 1.10, it needs to be added to 1.10 milestone.

Also, have any of you filed exception request for this feature?

@janetkuo janetkuo added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Mar 6, 2018
@janetkuo
Copy link
Member

janetkuo commented Mar 6, 2018

@jberkus the exception is filed here: https://groups.google.com/forum/#!topic/kubernetes-milestone-burndown/sPvjpRMf5es

Adding to v1.10 milestone to get attention from release team.

@janetkuo janetkuo added this to the v1.10 milestone Mar 6, 2018
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Mar 11, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Task 2: Schedule DaemonSet Pods by default scheduler.

Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>


**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
part of #59194
kubernetes/enhancements#548

**Release note**:

```release-note
When ScheduleDaemonSetPods is enabled, the DaemonSet controller will delegate Pods scheduling to default scheduler.
```
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Mar 20, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

disable DaemonSet scheduling feature for 1.10

The DaemonSet scheduling feature has blocked the alpha CI job being green and is preventing getting good CI signal for v1.10

It still contains pod scheduling races (#61050) and fundamental issues with the affinity terms it creates (#61410)

As such, there is not significant value in having the feature available in 1.10 in the current state

This PR disables the feature in order to regain green signal on the alpha CI job (reverting commits is likely to be more disruptive at this point)

related to #61050

```release-note
DaemonSet scheduling associated with the alpha ScheduleDaemonSetPods feature flag has been removed from the 1.10 release. See kubernetes/enhancements#548 for feature status.
```
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Mar 21, 2018
…1-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #61411: disable DaemonSet scheduling feature for 1.10

Cherry pick of #61411 on release-1.10.

related to #61050

#61411: disable DaemonSet scheduling feature for 1.10

```release-note
DaemonSet scheduling associated with the alpha ScheduleDaemonSetPods feature flag has been removed from the 1.10 release. See kubernetes/enhancements#548 for feature status.
```
@k82cn k82cn modified the milestones: v1.10, v1.11 Apr 4, 2018
@justaugustus
Copy link
Member

justaugustus commented Apr 17, 2018

@k82cn
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

cc @idvoretskyi

@k82cn
Copy link
Member Author

k82cn commented Apr 17, 2018

  • Milestone: 1.11
  • Assignee(s): @k82cn

/stage alpha
/sig scheduling
/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 17, 2018
@0xmichalis 0xmichalis added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 17, 2018
@justaugustus
Copy link
Member

justaugustus commented Apr 17, 2018

Thanks for the update, @k82cn!

@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2018
@mdlinville
Copy link

mdlinville commented May 24, 2018

@k82cn please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@k82cn
Copy link
Member Author

k82cn commented May 31, 2018

Doc for 1.11: kubernetes/website#8842

@mdlinville
Copy link

mdlinville commented May 31, 2018

@justaugustus @idvoretskyi apparently this feature went in for 1.10 and it's just that it was missing docs until now. So I don't think it should be considered a 1.11 feature. Is that correct? At least the docs submitted in the linked docs PR only mention "1.10 and higher" several times.

@k82cn
Copy link
Member Author

k82cn commented May 31, 2018

@mistyhacks , that should be 1.11; part of this feature are merged in 1.10 (which is considered as separate part), so I mark them 1.10 :).

@mdlinville
Copy link

mdlinville commented May 31, 2018

Oh, ok. Thanks for the clarification.

@janetkuo
Copy link
Member

janetkuo commented Jun 6, 2018

@k82cn we need to change feature gate comment of this to 1.11 (instead of 1.10):
https://github.com/kubernetes/kubernetes/blob/c2e3d0526d788ae3792626bbc165101b8f5ada8e/pkg/features/kube_features.go#L251

@kacole2
Copy link
Member

kacole2 commented Apr 12, 2019

Hello @k82cn , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@mariantalla
Copy link
Contributor

mariantalla commented Jul 11, 2019

Hi @k82cn - I'm an Enhancements shadow for 1.16.

Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

I noticed there's no KEP linked in the issue description; as a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

As a reminder, 1.16 milestone dates are: Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

@k82cn
Copy link
Member Author

k82cn commented Sep 12, 2019

we'd like to promote this feature to GA in 1.17 :)

@kacole2 kacole2 added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 12, 2019
@kacole2 kacole2 added this to the v1.17 milestone Sep 12, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 23, 2019

👋 hey there @k82cn -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@palnabarun
Copy link
Member

palnabarun commented Oct 10, 2019

Hi @k82cn , -- 1.17 enhancements shadow here.

Just a friendly reminder. We are just 5 days away from the Enhancements Freeze.

For the KEP to be considered for 1.17,

  1. KEP PR must be merged
  2. KEP should be in an implementable state
  3. KEP should have test plans and graduation criteria.

@k82cn
Copy link
Member Author

k82cn commented Oct 12, 2019

1.17 enhancements shadow here.

ack :)

@mrbobbytables mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 13, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Oct 15, 2019

Looking over the KEP, the test plan references tests for ScheduleDaemonSetPods - is it possible to add a link to the tests or preferably a testgrid dashboard?

Thanks!

@guineveresaenger
Copy link

guineveresaenger commented Oct 16, 2019

@draveness @k82cn - release lead here.
Especially given kubernetes/kubernetes#83829, we would very much like there to be a link to existing tests, and drop a few words about the test plan specifics in the KEP. Can you add such and update?

Overall, this graduation seems to be very much in line with reality and experience, we just want a bit more visibility to detail. I'd also second the request for more elaboration in kubernetes/kubernetes#83829.

@draveness
Copy link
Member

draveness commented Oct 17, 2019

Looking over the KEP, the test plan references tests for ScheduleDaemonSetPods - is it possible to add a link to the tests or preferably a testgrid dashboard?

I'll update the KEP

Overall, this graduation seems to be very much in line with reality and experience, we just want a bit more visibility to detail. I'd also second the request for more elaboration in kubernetes/kubernetes#83829.

Sure

@irvifa
Copy link
Member

irvifa commented Oct 21, 2019

Hello @k82cn I'm one of the v1.17 docs shadows.
Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@irvifa
Copy link
Member

irvifa commented Nov 1, 2019

@k82cn

Since we're approaching Docs placeholder PR deadline on Nov 8th. Please try to get one in against k/website dev-1.17 branch.

@draveness
Copy link
Member

draveness commented Nov 2, 2019

@k82cn

Since we're approaching Docs placeholder PR deadline on Nov 8th. Please try to get one in against k/website dev-1.17 branch.

The document PR is here kubernetes/website#17350

@mrbobbytables
Copy link
Member

mrbobbytables commented Nov 4, 2019

Hey there @draveness -- 1.17 Enhancements lead here. I just wanted to check back in regarding the upcoming code freeze on November 14th. It looks like just about everything is done going by the list in kubernetes/kubernetes#82702. Do you know if the last outstanding issue ("Refactor nodeShouldRunDaemonPod to remove useless return values") will make be merged in time?

@k82cn
Copy link
Member Author

k82cn commented Nov 6, 2019

"Refactor nodeShouldRunDaemonPod to remove useless return values" is optional to me, it's just code refactor, no behaviour change :)

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 3, 2020

Hey @draveness @k82cn, Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

@jeremyrickard jeremyrickard removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 3, 2020
@draveness
Copy link
Member

draveness commented Jan 3, 2020

Hey @draveness @k82cn, Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

We could close this issue since this is already GA'ed

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 3, 2020

@draveness: Closing this issue.

In response to this:

Hey @draveness @k82cn, Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

We could close this issue since this is already GA'ed

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 3, 2020

@draveness yes, I was just asking if you could update the status of the KEP :) It's still marked as implementable, but should be updated to say implemented...since it was :)

@draveness
Copy link
Member

draveness commented Jan 7, 2020

@draveness yes, I was just asking if you could update the status of the KEP :) It's still marked as implementable, but should be updated to say implemented...since it was :)

Thanks, I've opened #1437 to mark it as implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests