Schedule DaemonSet Pods by kube-scheduler #548

k82cn · 2018-01-29T08:54:59Z

Feature Description

One-line feature description (can be used as a release note):
Primary contact (assignee): @k82cn
Responsible SIGs: sig-scheduling, sig-apps
Design proposal link (community repo): Preemption support in DaemonSet controller , Schedule DaemonSet Pods by default scheduler
Link to e2e and/or unit tests:
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @bsalamat , @timothysc , @bgrant0607 @janetkuo
Approver (likely from SIG/area to which feature belongs): @bsalamat , @timothysc, @janetkuo
Feature target (which target equals to which milestone):
- Alpha release target (x.y): 1.11
- Beta release target (x.y): 1.12
- Stable release target (x.y):

bsalamat · 2018-01-31T05:25:46Z

ref/ kubernetes/kubernetes#57471

yastij · 2018-02-01T13:29:44Z

/cc

kow3ns · 2018-02-02T15:48:32Z

We had a long discussion about doing this here and decided not to. Is there a particular reason we should reconsider doing this now.
Features are closed for 1.10. Also, I don't see how you could reasonably release this as stable in 1.10.
We had the discussion in (1) prior to releasing DaemonSet to GA, is there a strong motivation to reconsider this now?
/cc @janetkuo @bgrant0607

bsalamat · 2018-02-03T01:34:23Z

@kow3ns There has been more discussions and the SIG scheduling has decided to go in this direction. @bgrant0607 has been in the loop in the discussions.

Please refer to this doc for more details: https://docs.google.com/document/d/1v7hsusMaeImQrOagktQb40ePbK6Jxp1hzgFB9OZa_ew/edit

janetkuo · 2018-03-02T18:09:41Z

Feature target (which target equals to which milestone):

Alpha release target (x.y)

Beta release target (x.y)

Stable release target (x.y) 1.10

From kubernetes/kubernetes#59630 this feature should be alpha, instead of stable. And if this targets 1.10, it needs to be added to 1.10 milestone.

Also, have any of you filed exception request for this feature?

janetkuo · 2018-03-06T00:45:03Z

@jberkus the exception is filed here: https://groups.google.com/forum/#!topic/kubernetes-milestone-burndown/sPvjpRMf5es

Adding to v1.10 milestone to get attention from release team.

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Task 2: Schedule DaemonSet Pods by default scheduler. Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com> **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: part of #59194 kubernetes/enhancements#548 **Release note**: ```release-note When ScheduleDaemonSetPods is enabled, the DaemonSet controller will delegate Pods scheduling to default scheduler. ```

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. disable DaemonSet scheduling feature for 1.10 The DaemonSet scheduling feature has blocked the alpha CI job being green and is preventing getting good CI signal for v1.10 It still contains pod scheduling races (#61050) and fundamental issues with the affinity terms it creates (#61410) As such, there is not significant value in having the feature available in 1.10 in the current state This PR disables the feature in order to regain green signal on the alpha CI job (reverting commits is likely to be more disruptive at this point) related to #61050 ```release-note DaemonSet scheduling associated with the alpha ScheduleDaemonSetPods feature flag has been removed from the 1.10 release. See kubernetes/enhancements#548 for feature status. ```

…1-upstream-release-1.10 Automatic merge from submit-queue. Automated cherry pick of #61411: disable DaemonSet scheduling feature for 1.10 Cherry pick of #61411 on release-1.10. related to #61050 #61411: disable DaemonSet scheduling feature for 1.10 ```release-note DaemonSet scheduling associated with the alpha ScheduleDaemonSetPods feature flag has been removed from the 1.10 release. See kubernetes/enhancements#548 for feature status. ```

justaugustus · 2018-04-17T03:49:41Z

@k82cn
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

Description
Milestone
Assignee(s)
Labels:
- stage/{alpha,beta,stable}
- sig/*
- kind/feature

cc @idvoretskyi

k82cn · 2018-04-17T11:28:46Z

Milestone: 1.11
Assignee(s): @k82cn

/stage alpha
/sig scheduling
/kind feature

justaugustus · 2018-04-17T20:52:53Z

Thanks for the update, @k82cn!

mdlinville · 2018-05-24T23:39:54Z

@k82cn please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

k82cn · 2018-05-31T14:09:40Z

Doc for 1.11: kubernetes/website#8842

mdlinville · 2018-05-31T23:10:25Z

@justaugustus @idvoretskyi apparently this feature went in for 1.10 and it's just that it was missing docs until now. So I don't think it should be considered a 1.11 feature. Is that correct? At least the docs submitted in the linked docs PR only mention "1.10 and higher" several times.

k82cn · 2018-05-31T23:23:17Z

@mistyhacks , that should be 1.11; part of this feature are merged in 1.10 (which is considered as separate part), so I mark them 1.10 :).

mdlinville · 2018-05-31T23:23:51Z

Oh, ok. Thanks for the clarification.

janetkuo · 2018-06-06T22:16:20Z

@k82cn we need to change feature gate comment of this to 1.11 (instead of 1.10):
https://github.com/kubernetes/kubernetes/blob/c2e3d0526d788ae3792626bbc165101b8f5ada8e/pkg/features/kube_features.go#L251

kacole2 · 2019-04-12T18:35:28Z

Hello @k82cn , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

mariantalla · 2019-07-11T10:39:36Z

Hi @k82cn - I'm an Enhancements shadow for 1.16.

Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

I noticed there's no KEP linked in the issue description; as a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

As a reminder, 1.16 milestone dates are: Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

k82cn · 2019-09-12T09:17:12Z

we'd like to promote this feature to GA in 1.17 :)

mrbobbytables · 2019-09-23T23:16:22Z

👋 hey there @k82cn -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.17?

The current release schedule is:

Monday, September 23 - Release Cycle Begins
Tuesday, October 15, EOD PST - Enhancements Freeze
Thursday, November 14, EOD PST - Code Freeze
Tuesday, November 19 - Docs must be completed and reviewed
Monday, December 9 - Kubernetes 1.17.0 Released

If you do, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

palnabarun · 2019-10-10T19:14:24Z

Hi @k82cn , -- 1.17 enhancements shadow here.

Just a friendly reminder. We are just 5 days away from the Enhancements Freeze.

For the KEP to be considered for 1.17,

KEP PR must be merged
KEP should be in an implementable state
KEP should have test plans and graduation criteria.

k82cn · 2019-10-12T08:25:40Z

1.17 enhancements shadow here.

ack :)

mrbobbytables · 2019-10-15T11:50:59Z

Looking over the KEP, the test plan references tests for ScheduleDaemonSetPods - is it possible to add a link to the tests or preferably a testgrid dashboard?

Thanks!

guineveresaenger · 2019-10-16T17:44:47Z

@draveness @k82cn - release lead here.
Especially given kubernetes/kubernetes#83829, we would very much like there to be a link to existing tests, and drop a few words about the test plan specifics in the KEP. Can you add such and update?

Overall, this graduation seems to be very much in line with reality and experience, we just want a bit more visibility to detail. I'd also second the request for more elaboration in kubernetes/kubernetes#83829.

draveness · 2019-10-17T00:57:45Z

Looking over the KEP, the test plan references tests for ScheduleDaemonSetPods - is it possible to add a link to the tests or preferably a testgrid dashboard?

I'll update the KEP

Overall, this graduation seems to be very much in line with reality and experience, we just want a bit more visibility to detail. I'd also second the request for more elaboration in kubernetes/kubernetes#83829.

Sure

irvifa · 2019-10-21T15:38:15Z

Hello @k82cn I'm one of the v1.17 docs shadows.
Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

irvifa · 2019-11-01T18:05:45Z

@k82cn

Since we're approaching Docs placeholder PR deadline on Nov 8th. Please try to get one in against k/website dev-1.17 branch.

draveness · 2019-11-02T02:33:58Z

@k82cn

Since we're approaching Docs placeholder PR deadline on Nov 8th. Please try to get one in against k/website dev-1.17 branch.

The document PR is here kubernetes/website#17350

mrbobbytables · 2019-11-04T23:36:47Z

Hey there @draveness -- 1.17 Enhancements lead here. I just wanted to check back in regarding the upcoming code freeze on November 14th. It looks like just about everything is done going by the list in kubernetes/kubernetes#82702. Do you know if the last outstanding issue ("Refactor nodeShouldRunDaemonPod to remove useless return values") will make be merged in time?

k82cn · 2019-11-06T02:22:39Z

"Refactor nodeShouldRunDaemonPod to remove useless return values" is optional to me, it's just code refactor, no behaviour change :)

jeremyrickard · 2020-01-03T15:18:30Z

Hey @draveness @k82cn, Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

draveness · 2020-01-03T16:08:04Z

Hey @draveness @k82cn, Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

We could close this issue since this is already GA'ed

/close

k8s-ci-robot · 2020-01-03T16:08:07Z

@draveness: Closing this issue.

In response to this:

Hey @draveness @k82cn, Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

We could close this issue since this is already GA'ed

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jeremyrickard · 2020-01-03T17:06:27Z

@draveness yes, I was just asking if you could update the status of the KEP :) It's still marked as implementable, but should be updated to say implemented...since it was :)

draveness · 2020-01-07T14:30:11Z

@draveness yes, I was just asking if you could update the status of the KEP :) It's still marked as implementable, but should be updated to say implemented...since it was :)

Thanks, I've opened #1437 to mark it as implemented

k82cn self-assigned this Jan 29, 2018

k82cn added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jan 29, 2018

This was referenced Feb 1, 2018

Design doc of 'Schedule DS Pod by default scheduler'. kubernetes/community#1714

Merged

Schedule DaemonSet Pods by default scheduler kubernetes/kubernetes#59194

Closed

janetkuo mentioned this issue Mar 2, 2018

Task 2: Schedule DaemonSet Pods by default scheduler. kubernetes/kubernetes#59862

Merged

janetkuo added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Mar 6, 2018

janetkuo added this to the v1.10 milestone Mar 6, 2018

k82cn modified the milestones: v1.10, v1.11 Apr 4, 2018

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 17, 2018

0xmichalis added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 17, 2018

justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2018

kacole2 added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Sep 12, 2019

kacole2 added this to the v1.17 milestone Sep 12, 2019

draveness mentioned this issue Sep 13, 2019

Graduate ScheduleDaemonSet to GA kubernetes/kubernetes#82702

Closed

6 tasks

This was referenced Oct 12, 2019

feat(scheduling): initialize kep for graduating schedule daemonset pods #1299

Merged

Performance concern for the graduation of ScheduleDaemonSetPods kubernetes/kubernetes#83829

Closed

mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 13, 2019

draveness mentioned this issue Nov 2, 2019

feat: graduate ScheduleDaemonSetPods to GA kubernetes/website#17350

Merged

jeremyrickard removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 3, 2020

k8s-ci-robot closed this as completed Jan 3, 2020

Schedule DaemonSet Pods by kube-scheduler #548

Schedule DaemonSet Pods by kube-scheduler #548

k82cn commented Jan 29, 2018 •

edited

bsalamat commented Jan 31, 2018 •

edited

yastij commented Feb 1, 2018

kow3ns commented Feb 2, 2018

bsalamat commented Feb 3, 2018

janetkuo commented Mar 2, 2018

janetkuo commented Mar 6, 2018 •

edited

justaugustus commented Apr 17, 2018

k82cn commented Apr 17, 2018

justaugustus commented Apr 17, 2018

mdlinville commented May 24, 2018

k82cn commented May 31, 2018

mdlinville commented May 31, 2018

k82cn commented May 31, 2018

mdlinville commented May 31, 2018

janetkuo commented Jun 6, 2018

kacole2 commented Apr 12, 2019

mariantalla commented Jul 11, 2019

k82cn commented Sep 12, 2019

mrbobbytables commented Sep 23, 2019

palnabarun commented Oct 10, 2019

k82cn commented Oct 12, 2019

mrbobbytables commented Oct 15, 2019

guineveresaenger commented Oct 16, 2019

draveness commented Oct 17, 2019

irvifa commented Oct 21, 2019

irvifa commented Nov 1, 2019

draveness commented Nov 2, 2019

mrbobbytables commented Nov 4, 2019

k82cn commented Nov 6, 2019 •

edited

jeremyrickard commented Jan 3, 2020 •

edited

draveness commented Jan 3, 2020

k8s-ci-robot commented Jan 3, 2020

jeremyrickard commented Jan 3, 2020

draveness commented Jan 7, 2020

Schedule DaemonSet Pods by kube-scheduler #548

Schedule DaemonSet Pods by kube-scheduler #548

Comments

k82cn commented Jan 29, 2018 • edited

Feature Description

bsalamat commented Jan 31, 2018 • edited

yastij commented Feb 1, 2018

kow3ns commented Feb 2, 2018

bsalamat commented Feb 3, 2018

janetkuo commented Mar 2, 2018

janetkuo commented Mar 6, 2018 • edited

justaugustus commented Apr 17, 2018

k82cn commented Apr 17, 2018

justaugustus commented Apr 17, 2018

mdlinville commented May 24, 2018

k82cn commented May 31, 2018

mdlinville commented May 31, 2018

k82cn commented May 31, 2018

mdlinville commented May 31, 2018

janetkuo commented Jun 6, 2018

kacole2 commented Apr 12, 2019

mariantalla commented Jul 11, 2019

k82cn commented Sep 12, 2019

mrbobbytables commented Sep 23, 2019

palnabarun commented Oct 10, 2019

k82cn commented Oct 12, 2019

mrbobbytables commented Oct 15, 2019

guineveresaenger commented Oct 16, 2019

draveness commented Oct 17, 2019

irvifa commented Oct 21, 2019

irvifa commented Nov 1, 2019

draveness commented Nov 2, 2019

mrbobbytables commented Nov 4, 2019

k82cn commented Nov 6, 2019 • edited

jeremyrickard commented Jan 3, 2020 • edited

draveness commented Jan 3, 2020

k8s-ci-robot commented Jan 3, 2020

jeremyrickard commented Jan 3, 2020

draveness commented Jan 7, 2020

k82cn commented Jan 29, 2018 •

edited

bsalamat commented Jan 31, 2018 •

edited

janetkuo commented Mar 6, 2018 •

edited

k82cn commented Nov 6, 2019 •

edited

jeremyrickard commented Jan 3, 2020 •

edited