Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Failure Recover with ForceEvictione Taint #551

Open
yastij opened this Issue Feb 3, 2018 · 23 comments

Comments

Projects
None yet
@yastij
Copy link
Member

yastij commented Feb 3, 2018

Feature Description

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee): @yastij
  • Responsible SIGs: sig-node, sig-storage
  • Design proposal link (community repo): kubernetes/kubernetes#58635 (design proposal will be added later under kubernetes/community)
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @jingxu97 @saad-ali
  • Approver (likely from SIG/area to which feature belongs): @jingxu97 @yujuhong
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y) 1.14
    • Beta release target (x.y) 1.15
    • Stable release target (x.y)
@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented Feb 3, 2018

/assign

@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented Feb 3, 2018

/kind feature
/sig storage
/sig node

@idvoretskyi

This comment has been minimized.

Copy link
Member

idvoretskyi commented Apr 12, 2018

@yastij can you confirm that this feature targets 1.11 as an alpha?

cc @justaugustus

@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented Apr 12, 2018

I guess, we do have a PR opened for this on the taint side.

cc @jingxu97 @zetaab

@justaugustus justaugustus added this to the v1.11 milestone Apr 17, 2018

@mistyhacks

This comment has been minimized.

Copy link
Member

mistyhacks commented May 24, 2018

@yastij please fill out the appropriate line item of the
1.11 feature tracking spreadsheet
and open a placeholder docs PR against the
release-1.11 branch
by 5/25/2018 (tomorrow as I write this) if new docs or docs changes are
needed and a relevant PR has not yet been opened.

@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented May 25, 2018

@mistyhacks - This isn't targeting 1.11 anymore, it is planned for 1.12 instead.

@mistyhacks

This comment has been minimized.

Copy link
Member

mistyhacks commented May 25, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 18, 2018

@yastij @kubernetes/sig-node-feature-requests @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented Jul 18, 2018

@justaugustus - This is targeting 1.12, updated the issue. The last PR kubernetes/kubernetes#66213 is in flight, Thanks !

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 18, 2018

Thanks for the update, @yastij!

@zparnold

This comment has been minimized.

Copy link
Member

zparnold commented Aug 20, 2018

Hey there! @yastij I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Sep 5, 2018

@yastij --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented Sep 6, 2018

@justaugustus - this was descoped from 1.12 see kubernetes/kubernetes#65392

@adampl

This comment has been minimized.

Copy link

adampl commented Sep 6, 2018

@yastij that's a different issue (unresponsive kubelet), so is there any reason to descope this feature?

@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented Sep 6, 2018

@adampl - this issue discusses also the taint shutdown solution. we are holding this feature in order to have another approach.

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Sep 6, 2018

Thanks for the update!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.12 milestone Sep 6, 2018

@kacole2 kacole2 added the tracked/no label Oct 8, 2018

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 6, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@yastij

This comment has been minimized.

Copy link
Member Author

yastij commented Jan 7, 2019

/remove-lifecycle stale

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 16, 2019

@yastij Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

@jingxu97

This comment has been minimized.

Copy link

jingxu97 commented Jan 20, 2019

@claurence Yes, we plan to to work on alpha feature in 1.14. Will add KEP very soon. Thanks!

@claurence claurence added this to the v1.14 milestone Jan 23, 2019

@claurence claurence added tracked/yes and removed tracked/no labels Jan 23, 2019

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 23, 2019

Thanks @jingxu97 - are there any open PRs we should track for 1.14?

@jingxu97

This comment has been minimized.

Copy link

jingxu97 commented Jan 23, 2019

I just added KEP #719

@jingxu97 jingxu97 changed the title taint node "shutdown" condition Node Failure Recover with ForceEvictione Taint Jan 23, 2019

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 30, 2019

@jingxu97 since theKEP for this issue hasn't been merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.