Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side Apply #555

Closed
apelisse opened this issue Apr 6, 2018 · 153 comments
Closed

Server-side Apply #555

apelisse opened this issue Apr 6, 2018 · 153 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@apelisse
Copy link
Member

apelisse commented Apr 6, 2018

Feature Description

@apelisse apelisse added this to the v1.11 milestone Apr 7, 2018
@apelisse apelisse added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 7, 2018
@idvoretskyi idvoretskyi added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 12, 2018
@idvoretskyi
Copy link
Member

idvoretskyi commented Apr 12, 2018

/assign @apelisse

@seans3 seans3 mentioned this issue Apr 17, 2018
@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2018
@lavalamp lavalamp modified the milestones: v1.11, v1.12 May 30, 2018
@zparnold
Copy link
Member

zparnold commented May 30, 2018

Looks like we still need some docs to get this feature ready for release @apelisse
Could I please get some help with that? If there’s anything I can do to assist please let me know

At a minimum we're looking to have a placeholder PR on the kubernetes/website repo. The process is fairly straightforward: checkout release-1.11 branch, make a placeholder commit, push it to your fork, and raise a PR between it and the release-1.11 branch, with /hold status.

THANKS SO MUCH!!!!!

@justaugustus
Copy link
Member

justaugustus commented May 31, 2018

@apelisse I noticed the milestone change. Are you planning on pulling this from the 1.11 release?

@apelisse
Copy link
Member Author

apelisse commented May 31, 2018

Yeah, not in 1.11. I'm updating the body.

@justaugustus
Copy link
Member

justaugustus commented Jun 1, 2018

Thanks @apelisse!

@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 1, 2018
@kwiesmueller
Copy link
Member

kwiesmueller commented Jul 5, 2018

Unsure if it is the right place to comment about this, but we have been working on our own kind of "server side apply" by building https://github.com/seibert-media/dimios
While this is solely a slack time project which we hope to build our future interaction with Kubernetes on, we both stumbled into problems with the entire apply process (discussed on slack with some people) but also did some thinking on how to best approach this.

While I haven't worked on K8s directly myself yet, I could imagine to contribute to this idea/feature if possible/wanted.

@apelisse
Copy link
Member Author

apelisse commented Jul 6, 2018

Can you send this as an email to kubernetes-wg-apply@googlegroups.com? We can follow-up there.

@kwiesmueller
Copy link
Member

kwiesmueller commented Jul 12, 2018

@apelisse I am not allowed to post messages to said group (kwiesmueller@seibert-media.net)

@apelisse
Copy link
Member Author

apelisse commented Jul 12, 2018

Sorry, you may need to join the group first: https://groups.google.com/forum/#!forum/kubernetes-wg-apply

Blue button, "Join group to post" (top left)

@justaugustus
Copy link
Member

justaugustus commented Jul 18, 2018

@apelisse @kubernetes/sig-api-machinery-feature-requests @kubernetes/sig-cli-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@apelisse
Copy link
Member Author

apelisse commented Jul 18, 2018

I think everything is there @justaugustus! Thank you

@justaugustus
Copy link
Member

justaugustus commented Jul 18, 2018

Thanks for the update, @apelisse!

@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 18, 2018
@zparnold
Copy link
Member

zparnold commented Aug 20, 2018

Hey there! @apelisse I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@apelisse apelisse modified the milestones: v1.12, v1.13 Aug 21, 2018
@apelisse
Copy link
Member Author

apelisse commented Aug 21, 2018

@zparnold Changed the milestone from 1.12 to 1.13 :-). You can forget about this for now, thanks.

@lavalamp
Copy link
Member

lavalamp commented Aug 21, 2018

@reylejano
Copy link
Member

reylejano commented Mar 12, 2021

Hello @apelisse , 1.21 Docs lead here.
Does this enhancement work planned for 1.21 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@annajung annajung removed this from the v1.21 milestone Mar 12, 2021
@annajung annajung removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Mar 12, 2021
@annajung
Copy link
Member

annajung commented Mar 12, 2021

After speaking with @apelisse, this enhancement has been deferred and will no longer be tracked for 1.21

@apelisse
Copy link
Member Author

apelisse commented Apr 29, 2021

We've updated the tracking sheet, can we mark this as a 1.22 milestone? Also, this is code complete already.

@JamesLaverack
Copy link
Member

JamesLaverack commented Apr 29, 2021

@apelisse Of course. Thanks for updating the tracking sheet!

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 29, 2021
@JamesLaverack JamesLaverack added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2021
@salaxander
Copy link

salaxander commented May 9, 2021

@apelisse - 1.22 enhancements team here! Looks like we're on track for 1.22. I think the only thing would maybe be updating the graduation criteria of the KEP to reference 1.22 rather than 1.21 for GA. Also, if you're able to update the structure of the KEP for the latest template (https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template), that would be awesome. Though, I don't think any of that would be a problem for enhancements freeze on 5/13.

Let us know If there's anything we can do to help!

CC @JamesLaverack

@apelisse
Copy link
Member Author

apelisse commented May 12, 2021

Not super excited to spend some time updating the KEP template now that we're all done with the feature ;-)

@salaxander
Copy link

salaxander commented May 13, 2021

Tracking #2732 for the updates. Thanks!

@PI-Victor
Copy link
Member

PI-Victor commented May 18, 2021

Hello @apelisse 👋, 1.22 Docs release lead here.
This enhancement is marked as ‘Needs Docs’ for 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

p.s.: please don't forget to update the ServerSideApply feature gate in the feature gates table to reflect the graduation.

@apelisse
Copy link
Member Author

apelisse commented May 18, 2021

Thanks, we've already updated most of the documentation in master branch, earlier this cycle. We should be good to go!

p.s.: please don't forget to update the ServerSideApply feature gate in the feature gates table to reflect the graduation.

Done here: kubernetes/website#28038

@salaxander
Copy link

salaxander commented Jun 23, 2021

Hi @apelisse! Checking in from the enhancements team as we're just over 2 weeks away from code freeze. Are there any open or merged k/k PRs we should be tracking for this? Thanks!

@kwiesmueller
Copy link
Member

kwiesmueller commented Jun 23, 2021

Hi @salaxander! To my knowledge there is nothing waiting for the code freeze.
We have some work happening in controller-runtime but that's not affected.
So we should be good for v1.22.

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 12, 2021
@salaxander
Copy link

salaxander commented Aug 18, 2021

Hey @apelisse and @kwiesmueller - Can you open a PR on the KEP to change to status to implemented? At that point we can close out the issue :)

Thanks!

@salaxander salaxander removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Aug 19, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented Sep 30, 2021

@salaxander @apelisse Can we close this issue? We're all done here right after 1.22? :D

@apelisse
Copy link
Member Author

apelisse commented Sep 30, 2021

Yep, sounds good!

@apelisse
Copy link
Member Author

apelisse commented Sep 30, 2021

3.5 years later ;-)

@sbose78
Copy link

sbose78 commented Oct 25, 2021

Could we update this in the description https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/0006-apply.md .. to something that works, please :-) ?

@apelisse
Copy link
Member Author

apelisse commented Oct 25, 2021

Could we update this in the description https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/0006-apply.md .. to something that works, please :-) ?

Done! Thanks for noticing ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests